From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D9D6C4167B for ; Thu, 15 Dec 2022 16:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbiLOQYH (ORCPT ); Thu, 15 Dec 2022 11:24:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230113AbiLOQXf (ORCPT ); Thu, 15 Dec 2022 11:23:35 -0500 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E85FF396D3; Thu, 15 Dec 2022 08:22:17 -0800 (PST) Received: by mail-ot1-f54.google.com with SMTP id m7-20020a9d6447000000b0066da0504b5eso3856000otl.13; Thu, 15 Dec 2022 08:22:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5lvp+Rra/J+0wVWurvbgG0Bk7qShU+6ZOVAk+JE7aHs=; b=xWml9QbxpMOa2ekPwryWxLXpaSuCWrhupKpu4VuYFpMkhSpBY+egWUFKy/s1BpAd9m +xKyVJin2Y1QoOUQjiVZWFNG34t9twUEcnluDcVscs2neDJliUs20JhD4GOKTPPXX3Cv YUZhonSPUMYk3jD6xvqxHiScsdBJ3n9CMrV7nFUZ1byHSeYEy4Z9DEO+ts056YYkXHB0 xFkSPkA7uiX7slhS0+oEjVKexllRBRjGVGXi5nTyz4HTJZQHvmF8UZd5Lou3+OhpfAjO HGQ4dDu2F9Q7G8VC4gIFsUNYCMAB3Ksobm4F5Oq2KszVRjkJGpb0yCDNNVPFZUtFyk7u xALQ== X-Gm-Message-State: ANoB5pncLq8ts+YT4trDNHS4JEQ2aqlym8TWY6gjfHSZOZsCMx4B5nbk wwLSur+3sxN/JiMPWcyoGA== X-Google-Smtp-Source: AA0mqf7X/PFzmParAODHOyFtTJjq+Nk9hxsJMAGA3If31IqPxkC3c3wsbOlFneYtyPmQ2EVOqVfozw== X-Received: by 2002:a05:6830:2098:b0:670:6976:a864 with SMTP id y24-20020a056830209800b006706976a864mr14501417otq.29.1671121337113; Thu, 15 Dec 2022 08:22:17 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d21-20020a056830139500b0066ec7ace428sm3698309otq.10.2022.12.15.08.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 08:22:16 -0800 (PST) Received: (nullmailer pid 145631 invoked by uid 1000); Thu, 15 Dec 2022 16:22:16 -0000 Date: Thu, 15 Dec 2022 10:22:16 -0600 From: Rob Herring To: Laurent Pinchart Cc: Kieran Bingham , devicetree@vger.kernel.org, linux-media@vger.kernel.org, Jacopo Mondi , Niklas =?iso-8859-1?Q?S=F6derlund?= , Krzysztof Kozlowski , Thomas Nizan , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 02/12] dt-bindings: media: i2c: max9286: Add property to select I2C speed Message-ID: <20221215162216.GA141183-robh@kernel.org> References: <20221214233825.13050-1-laurent.pinchart+renesas@ideasonboard.com> <20221214233825.13050-3-laurent.pinchart+renesas@ideasonboard.com> <167111060968.3140791.14917058235505688958.robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Dec 15, 2022 at 03:43:28PM +0200, Laurent Pinchart wrote: > Hi Rob, > > On Thu, Dec 15, 2022 at 07:24:38AM -0600, Rob Herring wrote: > > On Thu, 15 Dec 2022 01:38:15 +0200, Laurent Pinchart wrote: > > > The I2C speed on the remote side (the I2C master bus of the connected > > > serializers) is configurable, and doesn't need to match the speed of the > > > local bus (the slave bus of the MAX9286). All remote buses must use the > > > same speed, and the MAX9286 needs to be programmed accordingly. Add a > > > new DT property to select the speed to make it configurable. > > > > > > Signed-off-by: Laurent Pinchart > > > Reviewed-by: Rob Herring > > > --- > > > Changes since v2: > > > > > > - Rename property to maxim,i2c-remote-bus-hz > > > - Specify the property type > > > --- > > > .../devicetree/bindings/media/i2c/maxim,max9286.yaml | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml: properties:maxim,i2c-remote-bus-hz: '$ref' should not be valid under {'const': '$ref'} > > hint: Standard unit suffix properties don't need a type $ref > > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > > I wonder how I missed that, as I've run dt_binding_check before > submitting. I'll fix it. > > I'm a bit surprised though, all unit-suffixed properties use 32-bit > integers in the DT schema, while I can imagine that some may need a > 64-bit integer. What's the recommendation in that case ? Use -mhz. Anything outside the norm we have to special case in property-units.yaml. Rob