From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C1DC4167B for ; Fri, 16 Dec 2022 11:03:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230309AbiLPLDG (ORCPT ); Fri, 16 Dec 2022 06:03:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230250AbiLPLDE (ORCPT ); Fri, 16 Dec 2022 06:03:04 -0500 Received: from relay02.th.seeweb.it (relay02.th.seeweb.it [IPv6:2001:4b7a:2000:18::163]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1F6E54348 for ; Fri, 16 Dec 2022 03:03:03 -0800 (PST) Received: from SoMainline.org (94-209-172-39.cable.dynamic.v4.ziggo.nl [94.209.172.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 7A88220094; Fri, 16 Dec 2022 12:03:01 +0100 (CET) Date: Fri, 16 Dec 2022 12:03:00 +0100 From: Marijn Suijten To: Krzysztof Kozlowski Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Jonathan Cameron , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] arm64: dts: qcom: Use labels with generic node names for ADC channels Message-ID: <20221216110300.rnlblgfjuojhlxny@SoMainline.org> Mail-Followup-To: Marijn Suijten , Krzysztof Kozlowski , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Jonathan Cameron , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221209215308.1781047-1-marijn.suijten@somainline.org> <3d5b29f3-8d8d-93a7-a485-5261e2d8891d@linaro.org> <20221210165434.3hhen5mgtvflghks@SoMainline.org> <0bc1eba8-bc26-0bdb-16bf-78160c27c57b@linaro.org> <20221214205556.jdbcv3e4fkvm7f3y@SoMainline.org> <49be7501-916a-8d84-9757-fd31fab991dd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49be7501-916a-8d84-9757-fd31fab991dd@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-12-16 11:49:09, Krzysztof Kozlowski wrote: > [..] > > My commit message explains why the ADC5/VADC driver should really > > receive a label property instead of using the node name. > > The reason "unpleasant file-browsing experience" is usually OS specific, > so it does not justify requiring a label property. Label is just a > helper for the users. Ack. Then it's up to the driver to figure out what's best here. My suggestion on top of the proposed handling by Jonathan: a) Use label if present. b) Use node name if it's not adc-chan but strip the @xxx off it. c) Use (currently unused) hardcoded name in the driver. Unfortunately we have two drivers (VADC and ADC5) to deal with, where the VADC driver is not affected by any of these filename problems, nor won't be. It doesn't have a label in Linux at all yet so there's no userspace ABI to (un)break, only DT ABI. - Marijn