* [PATCH] dt-bindings: usb: tegra-xusb: Remove path references
@ 2022-11-30 15:41 Thierry Reding
2022-11-30 15:43 ` Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Thierry Reding @ 2022-11-30 15:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: devicetree, linux-usb, linux-tegra, Conor Dooley
From: Thierry Reding <treding@nvidia.com>
Unresolved path references are now flagged as errors when checking the
device tree binding examples, so convert them into label references.
Reported-by: Conor Dooley <conor.dooley@microchip.com>
Suggested-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
.../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml | 4 +---
.../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml | 4 +---
.../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml | 8 ++------
.../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml | 8 ++------
4 files changed, 6 insertions(+), 18 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
index 4a6616bf9bab..d6ca8c93073d 100644
--- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml
@@ -186,9 +186,7 @@ examples:
nvidia,xusb-padctl = <&padctl>;
- phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
- <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
- <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
+ phys = <&phy_usb2_1>, <&phy_usb2_2>, <&phy_pcie_0>;
phy-names = "usb2-1", "usb2-2", "usb3-0";
avddio-pex-supply = <&vdd_1v05_run>;
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
index 6f62944fc597..a04c6ce1e0f6 100644
--- a/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml
@@ -166,8 +166,6 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
- phys = <&{/padctl@3520000/pads/usb2/lanes/usb2-0}>,
- <&{/padctl@3520000/pads/usb2/lanes/usb2-1}>,
- <&{/padctl@3520000/pads/usb3/lanes/usb3-0}>;
+ phys = <&phy_usb2_0>, <&phy_usb2_1>, <&phy_usb3_0>;
phy-names = "usb2-0", "usb2-1", "usb3-0";
};
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml
index 65ae9ae9b0b7..b356793f73a1 100644
--- a/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml
@@ -169,11 +169,7 @@ examples:
nvidia,xusb-padctl = <&xusb_padctl>;
- phys = <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-0}>,
- <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-1}>,
- <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-3}>,
- <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-0}>,
- <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-2}>,
- <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-3}>;
+ phys = <&phy_usb2_0>, <&phy_usb2_1>, <&phy_usb2_3>, <&phy_usb3_0>,
+ <&phy_usb3_2>, <&phy_usb3_3>;
phy-names = "usb2-0", "usb2-1", "usb2-3", "usb3-0", "usb3-2", "usb3-3";
};
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml
index da1e1ec0e7c8..90296613b3a5 100644
--- a/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml
@@ -173,12 +173,8 @@ examples:
nvidia,xusb-padctl = <&padctl>;
- phys = <&{/padctl@7009f000/pads/usb2/lanes/usb2-0}>,
- <&{/padctl@7009f000/pads/usb2/lanes/usb2-1}>,
- <&{/padctl@7009f000/pads/usb2/lanes/usb2-2}>,
- <&{/padctl@7009f000/pads/usb2/lanes/usb2-3}>,
- <&{/padctl@7009f000/pads/pcie/lanes/pcie-6}>,
- <&{/padctl@7009f000/pads/pcie/lanes/pcie-5}>;
+ phys = <&phy_usb2_0>, <&phy_usb2_1>, <&phy_usb2_2>, <&phy_usb2_3>,
+ <&phy_pcie_6>, <&phy_pcie_5>;
phy-names = "usb2-0", "usb2-1", "usb2-2", "usb2-3", "usb3-0",
"usb3-1";
dvddio-pex-supply = <&vdd_pex_1v05>;
--
2.38.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: tegra-xusb: Remove path references
2022-11-30 15:41 [PATCH] dt-bindings: usb: tegra-xusb: Remove path references Thierry Reding
@ 2022-11-30 15:43 ` Krzysztof Kozlowski
2022-11-30 16:39 ` Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-30 15:43 UTC (permalink / raw)
To: Thierry Reding, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, linux-usb, linux-tegra, Conor Dooley
On 30/11/2022 16:41, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Unresolved path references are now flagged as errors when checking the
> device tree binding examples, so convert them into label references.
>
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: tegra-xusb: Remove path references
2022-11-30 15:41 [PATCH] dt-bindings: usb: tegra-xusb: Remove path references Thierry Reding
2022-11-30 15:43 ` Krzysztof Kozlowski
@ 2022-11-30 16:39 ` Geert Uytterhoeven
2022-11-30 20:48 ` Rob Herring
2022-12-16 17:40 ` Rob Herring
3 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2022-11-30 16:39 UTC (permalink / raw)
To: Thierry Reding
Cc: Rob Herring, Krzysztof Kozlowski, devicetree, linux-usb,
linux-tegra, Conor Dooley
On Wed, Nov 30, 2022 at 4:52 PM Thierry Reding <thierry.reding@gmail.com> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Unresolved path references are now flagged as errors when checking the
> device tree binding examples, so convert them into label references.
>
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
This fixes "make dt_binding_check" for me, so
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: tegra-xusb: Remove path references
2022-11-30 15:41 [PATCH] dt-bindings: usb: tegra-xusb: Remove path references Thierry Reding
2022-11-30 15:43 ` Krzysztof Kozlowski
2022-11-30 16:39 ` Geert Uytterhoeven
@ 2022-11-30 20:48 ` Rob Herring
2022-12-16 17:40 ` Rob Herring
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-11-30 20:48 UTC (permalink / raw)
To: Thierry Reding
Cc: Krzysztof Kozlowski, devicetree, linux-usb, linux-tegra,
Conor Dooley
On Wed, Nov 30, 2022 at 04:41:11PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Unresolved path references are now flagged as errors when checking the
> device tree binding examples, so convert them into label references.
>
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml | 4 +---
> .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml | 4 +---
> .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml | 8 ++------
> .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml | 8 ++------
> 4 files changed, 6 insertions(+), 18 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: tegra-xusb: Remove path references
2022-11-30 15:41 [PATCH] dt-bindings: usb: tegra-xusb: Remove path references Thierry Reding
` (2 preceding siblings ...)
2022-11-30 20:48 ` Rob Herring
@ 2022-12-16 17:40 ` Rob Herring
2022-12-21 9:18 ` Thierry Reding
3 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2022-12-16 17:40 UTC (permalink / raw)
To: Thierry Reding
Cc: Krzysztof Kozlowski, devicetree, linux-usb, linux-tegra,
Conor Dooley
On Wed, Nov 30, 2022 at 04:41:11PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Unresolved path references are now flagged as errors when checking the
> device tree binding examples, so convert them into label references.
>
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml | 4 +---
> .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml | 4 +---
> .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml | 8 ++------
> .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml | 8 ++------
> 4 files changed, 6 insertions(+), 18 deletions(-)
As this is the only binding issue remaining in Linus's tree and it's the
only thing in the Tegra tree, I've applied it for rc1.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: tegra-xusb: Remove path references
2022-12-16 17:40 ` Rob Herring
@ 2022-12-21 9:18 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2022-12-21 9:18 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, devicetree, linux-usb, linux-tegra,
Conor Dooley
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
On Fri, Dec 16, 2022 at 11:40:34AM -0600, Rob Herring wrote:
> On Wed, Nov 30, 2022 at 04:41:11PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Unresolved path references are now flagged as errors when checking the
> > device tree binding examples, so convert them into label references.
> >
> > Reported-by: Conor Dooley <conor.dooley@microchip.com>
> > Suggested-by: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml | 4 +---
> > .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml | 4 +---
> > .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml | 8 ++------
> > .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml | 8 ++------
> > 4 files changed, 6 insertions(+), 18 deletions(-)
>
> As this is the only binding issue remaining in Linus's tree and it's the
> only thing in the Tegra tree, I've applied it for rc1.
I was waiting for more fixes to come in before sending out another PR,
but nothing else showed up, so taking this through your tree makes more
sense.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-12-21 9:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-30 15:41 [PATCH] dt-bindings: usb: tegra-xusb: Remove path references Thierry Reding
2022-11-30 15:43 ` Krzysztof Kozlowski
2022-11-30 16:39 ` Geert Uytterhoeven
2022-11-30 20:48 ` Rob Herring
2022-12-16 17:40 ` Rob Herring
2022-12-21 9:18 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).