From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: heiko@sntech.de, hjc@rock-chips.com,
krzysztof.kozlowski+dt@linaro.org, airlied@gmail.com,
daniel@ffwll.ch, vkoul@kernel.org, kishon@kernel.org,
linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml
Date: Tue, 20 Dec 2022 14:00:54 -0600 [thread overview]
Message-ID: <20221220200054.GA953433-robh@kernel.org> (raw)
In-Reply-To: <e54f7b52-3530-59c4-90c6-1fb5a17d6491@gmail.com>
On Mon, Dec 19, 2022 at 05:56:55PM +0100, Johan Jonker wrote:
> On Rockchip rk3399 a port node with one endpoint can be connected
> to a USB Type-C connector node.
> Add a port node to the phy-rockchip-inno-usb2.yaml file.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml
> index f71920082..ffc7e7560 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml
> @@ -115,6 +115,11 @@ properties:
> required:
> - "#phy-cells"
>
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Port node with one endpoint connected to a USB Type-C connector node.
> +
This doesn't make sense. First, this phy has an otg and host phy, so
which one is it? Second, the USB connector graph is supposed to be
connected to the USB controllers, not a phy.
But I guess we already have this in use, so I guess just mark it
deprecated to discourage more usage..
Rob
next prev parent reply other threads:[~2022-12-20 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 16:54 [PATCH v4 1/5] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML Johan Jonker
2022-12-19 16:56 ` [PATCH v4 2/5] dt-bindings: soc: rockchip: grf: add rockchip,lvds.yaml Johan Jonker
2022-12-20 16:07 ` Rob Herring
2022-12-19 16:56 ` [PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml Johan Jonker
2022-12-20 20:00 ` Rob Herring [this message]
2022-12-19 16:57 ` [PATCH v4 4/5] ARM: dts: rockchip: rk3288: add lvds_out node Johan Jonker
2022-12-19 16:57 ` [PATCH v4 5/5] arm64: dts: rockchip: px30: " Johan Jonker
2022-12-20 16:05 ` [PATCH v4 1/5] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220200054.GA953433-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).