[PATCH] regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema

[PATCH] regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema

[Rob Herring]

Convert the Fairchild FAN53555 and compatible variants binding to DT
schema format.

The example was missing 'reg', so add it.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/regulator/fan53555.txt           | 24 --------
 .../bindings/regulator/fcs,fan53555.yaml      | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/regulator/fan53555.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml

diff --git a/Documentation/devicetree/bindings/regulator/fan53555.txt b/Documentation/devicetree/bindings/regulator/fan53555.txt
deleted file mode 100644
index 013f096ac0aa..000000000000
--- a/Documentation/devicetree/bindings/regulator/fan53555.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-Binding for Fairchild FAN53555 regulators
-
-Required properties:
-  - compatible: one of "fcs,fan53555", "fcs,fan53526", "silergy,syr827",
-		"silergy,syr828" or "tcs,tcs4525".
-  - reg: I2C address
-
-Optional properties:
-  - fcs,suspend-voltage-selector: declare which of the two available
-		voltage selector registers should be used for the suspend
-		voltage. The other one is used for the runtime voltage setting
-		Possible values are either <0> or <1>
-  - vin-supply: regulator supplying the vin pin
-
-Example:
-
-	regulator@40 {
-		compatible = "fcs,fan53555";
-		regulator-name = "fan53555";
-		regulator-min-microvolt = <1000000>;
-		regulator-max-microvolt = <1800000>;
-		vin-supply = <&parent_reg>;
-		fcs,suspend-voltage-selector = <1>;
-	};
diff --git a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
new file mode 100644
index 000000000000..9610e48c5b8a
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/fcs,fan53555.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Fairchild FAN53555 regulators
+
+maintainers:
+  - Heiko Stuebner <heiko@sntech.de>
+
+allOf:
+  - $ref: regulator.yaml#
+
+properties:
+  compatible:
+    enum:
+      - fcs,fan53555
+      - fcs,fan53526
+      - silergy,syr827
+      - silergy,syr828
+      - tcs,tcs4525
+
+  reg:
+    maxItems: 1
+
+  fcs,suspend-voltage-selector:
+    description: Declares which of the two available voltage selector
+      registers should be used for the suspend voltage. The other one is used
+      for the runtime voltage setting.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [ 0, 1 ]
+
+  vin-supply:
+    description: Supply for the vin pin
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        regulator@40 {
+            compatible = "fcs,fan53555";
+            reg = <0x40>;
+            regulator-name = "fan53555";
+            regulator-min-microvolt = <1000000>;
+            regulator-max-microvolt = <1800000>;
+            vin-supply = <&parent_reg>;
+            fcs,suspend-voltage-selector = <1>;
+        };
+    };
+...
-- 
2.35.1

Re: [PATCH] regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema

[Rob Herring]

On Mon, 19 Dec 2022 13:11:25 -0600, Rob Herring wrote:
> Convert the Fairchild FAN53555 and compatible variants binding to DT
> schema format.
> 
> The example was missing 'reg', so add it.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/regulator/fan53555.txt           | 24 --------
>  .../bindings/regulator/fcs,fan53555.yaml      | 59 +++++++++++++++++++
>  2 files changed, 59 insertions(+), 24 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/regulator/fan53555.txt
>  create mode 100644 Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221219191125.1974879-1-robh@kernel.org


regulator@40: Unevaluated properties are not allowed ('regulator-compatible', 'vsel-gpios' were unexpected)
	arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dtb

regulator@40: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)
	arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dtb
	arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg503.dtb

regulator@41: Unevaluated properties are not allowed ('regulator-compatible', 'vsel-gpios' were unexpected)
	arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dtb

regulator@60: Unevaluated properties are not allowed ('vsel-gpios' was unexpected)
	arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb
	arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb
	arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb

syr827@40: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
	arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dtb

syr828@41: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
	arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dtb

Re: [PATCH] regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema

[Rob Herring]

On Mon, Dec 19, 2022 at 03:22:08PM -0600, Rob Herring wrote:
> 
> On Mon, 19 Dec 2022 13:11:25 -0600, Rob Herring wrote:
> > Convert the Fairchild FAN53555 and compatible variants binding to DT
> > schema format.
> > 
> > The example was missing 'reg', so add it.
> > 
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../bindings/regulator/fan53555.txt           | 24 --------
> >  .../bindings/regulator/fcs,fan53555.yaml      | 59 +++++++++++++++++++
> >  2 files changed, 59 insertions(+), 24 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/regulator/fan53555.txt
> >  create mode 100644 Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
> > 
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221219191125.1974879-1-robh@kernel.org
> 
> 
> regulator@40: Unevaluated properties are not allowed ('regulator-compatible', 'vsel-gpios' were unexpected)
> 	arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dtb

The h/w does have a VSEL pin, so I'll respin adding that.

> 
> regulator@40: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)
> 	arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dtb
> 	arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg503.dtb

Humm, not in the kernel. Seems u-boot has added some of their own 
properties...

Rob

Re: [PATCH] regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema

[Mark Brown]

On Mon, 19 Dec 2022 13:11:25 -0600, Rob Herring wrote:
> Convert the Fairchild FAN53555 and compatible variants binding to DT
> schema format.
> 
> The example was missing 'reg', so add it.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: dt-bindings: Convert Fairchild FAN53555 to DT schema
      commit: 6cea468b680e1254c7e8f95b70f4c3798985f05a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark