From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Richard Leitner <richard.leitner@skidata.com>
Subject: Re: [PATCH v2 00/21] Add Tegra20 parallel video input capture
Date: Thu, 22 Dec 2022 10:03:28 +0100 [thread overview]
Message-ID: <20221222100328.6e341874@booty> (raw)
In-Reply-To: <a99fa7e5-31bc-4286-17e5-6ba6e4932bcf@gmail.com>
Hello Dmitry,
thanks for your review.
On Tue, 20 Dec 2022 23:21:49 +0300
Dmitry Osipenko <digetx@gmail.com> wrote:
> 28.11.2022 18:23, Luca Ceresoli пишет:
> > Tegra20 and other Tegra SoCs have a video input (VI) peripheral that can
> > receive from either MIPI CSI-2 or parallel video (called respectively "CSI"
> > and "VIP" in the documentation). The kernel currently has a staging driver
> > for Tegra210 CSI capture. This patch set adds support for Tegra20 VIP
> > capture.
> >
> > Unfortunately I had no real documentation available to base this work on.
> > I only had a working downstream 3.1 kernel, so I started with the driver
> > found there and heavily reworked it to fit into the mainline tegra-video
> > driver structure. The existing code appears written with the intent of
> > being modular and allow adding new input mechanisms and new SoCs while
> > keeping a unique VI core module. However its modularity and extensibility
> > was not enough to add Tegra20 VIP support, so I added some hooks to turn
> > hard-coded behaviour into per-SoC or per-bus customizable code. There are
> > also a fix, some generic cleanups and DT bindings.
> >
> > Quick tour of the patches:
> >
> > * Device tree bindings and minor DTS improvements
> >
> > 01. dt-bindings: display: tegra: add Tegra20 VIP
> > 02. dt-bindings: display: tegra: vi: add 'vip' property and example
>
> This series adds the new DT node, but there are no board DTs in upstream
> that will use VIP? Will we see the board patches?
I'm afraid I have no such plan. I don't have any public hardware with
Tegra20, with or without a parallel sensor. I have a custom board.
> In any case, given that you're likely the only one here who has access
> to hardware with VIP,
Likely indeed.
> you should promote yourself to the tegra-video
> driver maintainers and confirm that you will be able to maintain and
> test this code for years to come.
I can definitely add myself as a maintainer of this driver and join the
maintenance effort, I'm adding that in v3. I also have a board that I
can permanently use for testing.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2022-12-22 9:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 15:23 [PATCH v2 00/21] Add Tegra20 parallel video input capture Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 01/21] dt-bindings: display: tegra: add Tegra20 VIP Luca Ceresoli
2022-12-01 23:19 ` Rob Herring
2022-12-02 8:11 ` Luca Ceresoli
2022-12-20 20:13 ` Dmitry Osipenko
2022-12-22 9:03 ` Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 02/21] dt-bindings: display: tegra: vi: add 'vip' property and example Luca Ceresoli
2022-12-01 23:16 ` Rob Herring
2022-12-02 8:11 ` Luca Ceresoli
2022-12-02 11:34 ` Krzysztof Kozlowski
2022-11-28 15:23 ` [PATCH v2 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 04/21] staging: media: tegra-video: improve documentation of tegra_video_format fields Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 05/21] staging: media: tegra-video: document tegra_channel_get_remote_source_subdev Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 06/21] staging: media: tegra-video: fix typos in comment Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 07/21] staging: media: tegra-video: improve error messages Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 08/21] staging: media: tegra-video: slightly simplify cleanup on errors Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 09/21] staging: media: tegra-video: move private struct declaration to C file Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 10/21] staging: media: tegra-video: remove unneeded include Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 11/21] staging: media: tegra-video: Kconfig: allow TPG only on Tegra210 Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 12/21] staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 13/21] staging: media: tegra-video: move default format to soc-specific data Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 14/21] staging: media: tegra-video: move MIPI calibration calls from VI to CSI Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 15/21] staging: media: tegra-video: add a per-soc enable/disable op Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 16/21] staging: media: tegra-video: move syncpt init/free to a per-soc op Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 17/21] staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 18/21] staging: media: tegra-video: add hooks for planar YUV and H/V flip Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 19/21] staging: media: tegra-video: add H/V flip controls Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 20/21] staging: media: tegra-video: add support for VIP (parallel video input) Luca Ceresoli
2022-11-28 15:23 ` [PATCH v2 21/21] staging: media: tegra-video: add tegra20 variant Luca Ceresoli
2022-12-20 21:40 ` Dmitry Osipenko
2022-12-22 9:03 ` Luca Ceresoli
2022-12-23 12:15 ` Dmitry Osipenko
2022-12-23 12:27 ` Dmitry Osipenko
2022-12-23 12:35 ` Dmitry Osipenko
2022-12-28 10:46 ` Luca Ceresoli
2022-12-23 13:02 ` Dmitry Osipenko
2022-12-23 13:18 ` Dmitry Osipenko
2022-12-20 20:21 ` [PATCH v2 00/21] Add Tegra20 parallel video input capture Dmitry Osipenko
2022-12-22 9:03 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221222100328.6e341874@booty \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).