* [PATCH] arm64: dts: imx8mm-evk: update leds node
@ 2022-12-23 3:02 Peng Fan (OSS)
2022-12-23 8:33 ` Marco Felsch
2022-12-27 21:54 ` Pavel Machek
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan (OSS) @ 2022-12-23 3:02 UTC (permalink / raw)
To: shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, devicetree, linux-kernel,
linux-arm-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Drop deprecated label property, update node name as leds-gpio.yaml
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
index e0b604ac0da4..0f87991dcb57 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
@@ -24,8 +24,7 @@ leds {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpio_led>;
- status {
- label = "status";
+ led-0 {
gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
default-state = "on";
};
--
2.37.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm-evk: update leds node
2022-12-23 3:02 [PATCH] arm64: dts: imx8mm-evk: update leds node Peng Fan (OSS)
@ 2022-12-23 8:33 ` Marco Felsch
2022-12-27 21:54 ` Pavel Machek
1 sibling, 0 replies; 3+ messages in thread
From: Marco Felsch @ 2022-12-23 8:33 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: shawnguo, s.hauer, devicetree, Peng Fan, linux-kernel, linux-imx,
kernel, festevam, linux-arm-kernel
Hi Peng,
On 22-12-23, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Drop deprecated label property, update node name as leds-gpio.yaml
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index e0b604ac0da4..0f87991dcb57 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -24,8 +24,7 @@ leds {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_gpio_led>;
>
> - status {
> - label = "status";
> + led-0 {
We can use just 'led' since this is a single led.
Regards,
Marco
> gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> };
> --
> 2.37.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm-evk: update leds node
2022-12-23 3:02 [PATCH] arm64: dts: imx8mm-evk: update leds node Peng Fan (OSS)
2022-12-23 8:33 ` Marco Felsch
@ 2022-12-27 21:54 ` Pavel Machek
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2022-12-27 21:54 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, devicetree,
linux-kernel, linux-arm-kernel, Peng Fan
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
On Fri 2022-12-23 11:02:27, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Drop deprecated label property, update node name as leds-gpio.yaml
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index e0b604ac0da4..0f87991dcb57 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -24,8 +24,7 @@ leds {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_gpio_led>;
>
> - status {
> - label = "status";
> + led-0 {
> gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> };
Please cc led lists on led changes.
And don't do this, this will change userland interface.
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-27 21:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-23 3:02 [PATCH] arm64: dts: imx8mm-evk: update leds node Peng Fan (OSS)
2022-12-23 8:33 ` Marco Felsch
2022-12-27 21:54 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).