From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9DDC4332F for ; Fri, 23 Dec 2022 17:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231241AbiLWR40 (ORCPT ); Fri, 23 Dec 2022 12:56:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230489AbiLWR4Z (ORCPT ); Fri, 23 Dec 2022 12:56:25 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4311C1BEA9; Fri, 23 Dec 2022 09:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5tyPCZzSf4fJF+O4ymtoHkWVf8rcASMcDBrCq5a8OMQ=; b=zEDelKH6Vhu+vv0S4WXkVMCVqi 73AmPD/hDUGQQXoPo3EbZvvu2XqCYPfaXaIys3k4qDmPfOljTx30+o2voz3zLy/bIo+S+cw13WQbC vgb1jRdBDv2Mq5ocaw63REvfUA5SY7ahu9lB0gRGAriIztYi4GxiG9ndT8Ey54ZrIcBg=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:48998 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1p8mHI-0003Bs-3Y; Fri, 23 Dec 2022 12:56:16 -0500 Date: Fri, 23 Dec 2022 12:56:15 -0500 From: Hugo Villeneuve To: Jonathan Cameron Cc: Krzysztof Kozlowski , hvilleneuve@dimonoff.com, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20221223125615.4932b8ac2a8d0cf82b4807e8@hugovil.com> In-Reply-To: <20221223140908.3b4a5458@jic23-huawei> References: <20221222203610.2571287-1-hugo@hugovil.com> <20221222203610.2571287-4-hugo@hugovil.com> <01a5f912-10d2-d5fe-023e-e2e6613ac03b@linaro.org> <20221223140908.3b4a5458@jic23-huawei> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH v1 3/3] dt-bindings: iio: adc: add ADS7924 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 23 Dec 2022 14:09:08 +0000 Jonathan Cameron wrote: > > > > > + description: > > > + Child nodes needed for each channel that the platform uses. > > > > I cannot understand this sentence at all. Instead describe the hardware > > you are here representing. What's this? > > Needs rewording, but basically - "Which pins are connected to anything?" Hi Jonathan and Krzysztof, when writing this driver a few months ago, I used as a starting point the C source file and the YAML file of the TI ADS1015 driver. I cannot say that I fully understand the sentence myself :) So I will reword it. I will also take care of the other dt-bindings comments for version 2. Thank you for your feedback. Hugo V. -- Hugo Villeneuve