From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
mturquette@baylibre.com
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, sboyd@kernel.org,
matthias.bgg@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
angelogioacchino.delregno@collabora.com, wenst@chromium.org,
johnson.wang@mediatek.com, miles.chen@mediatek.com,
fparent@baylibre.com, chun-jie.chen@mediatek.com,
sam.shih@mediatek.com, y.oudjana@protonmail.com,
nfraprado@collabora.com, rex-bc.chen@mediatek.com,
ryder.lee@kernel.org, daniel@makrotopia.org,
jose.exposito89@gmail.com, yangyingliang@huawei.com,
pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com,
ikjn@chromium.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v2 10/23] clk: mediatek: mt8173: Break down clock drivers and allow module build
Date: Sat, 24 Dec 2022 10:13:52 +0300 [thread overview]
Message-ID: <202212240437.1D3FXJyP-lkp@intel.com> (raw)
In-Reply-To: <20221223094259.87373-11-angelogioacchino.delregno@collabora.com>
Hi AngeloGioacchino,
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/AngeloGioacchino-Del-Regno/clk-mediatek-mt8192-Correctly-unregister-and-free-clocks-on-failure/20221223-174705
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link: https://lore.kernel.org/r/20221223094259.87373-11-angelogioacchino.delregno%40collabora.com
patch subject: [PATCH v2 10/23] clk: mediatek: mt8173: Break down clock drivers and allow module build
config: parisc-randconfig-m031-20221219
compiler: hppa-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/clk/mediatek/clk-mt8173-apmixedsys.c:95 clk_mt8173_apmixed_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +95 drivers/clk/mediatek/clk-mt8173-apmixedsys.c
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 85 static int clk_mt8173_apmixed_probe(struct platform_device *pdev)
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 86 {
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 87 struct device_node *node = pdev->dev.of_node;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 88 struct clk_hw_onecell_data *clk_data;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 89 void __iomem *base;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 90 struct clk_hw *hw;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 91 int r;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 92
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 93 base = of_iomap(node, 0);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 94 if (!base)
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 @95 return PTR_ERR(base);
return -ENOMEM?
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 96
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 97 clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 98 if (IS_ERR_OR_NULL(clk_data))
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 99 return -ENOMEM;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 100
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 101 r = mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 102 if (r)
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 103 goto free_clk_data;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 104
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 105 hw = mtk_clk_register_ref2usb_tx("ref2usb_tx", "clk26m", base + REGOFF_REF2USB);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 106 if (IS_ERR(hw)) {
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 107 r = PTR_ERR(hw);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 108 dev_err(&pdev->dev, "Failed to register ref2usb_tx: %d\n", r);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 109 goto unregister_plls;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 110 }
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 111 clk_data->hws[CLK_APMIXED_REF2USB_TX] = hw;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 112
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 113 hw = devm_clk_hw_register_divider(&pdev->dev, "hdmi_ref", "tvdpll_594m", 0,
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 114 base + REGOFF_HDMI_REF, 16, 3,
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 115 CLK_DIVIDER_POWER_OF_TWO, NULL);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 116 clk_data->hws[CLK_APMIXED_HDMI_REF] = hw;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 117
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 118 r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 119 if (r)
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 120 goto unregister_ref2usb;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 121
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 122 return 0;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 123
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 124 unregister_ref2usb:
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 125 mtk_clk_unregister_ref2usb_tx(clk_data->hws[CLK_APMIXED_REF2USB_TX]);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 126 unregister_plls:
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 127 mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 128 free_clk_data:
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 129 mtk_free_clk_data(clk_data);
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 130 return r;
c10b45573221c8 AngeloGioacchino Del Regno 2022-12-23 131 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-12-24 7:14 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 9:42 [PATCH v2 00/23] MediaTek clocks cleanups and improvements AngeloGioacchino Del Regno
2022-12-23 9:42 ` [PATCH v2 01/23] clk: mediatek: mt8192: Correctly unregister and free clocks on failure AngeloGioacchino Del Regno
2022-12-26 6:55 ` Chen-Yu Tsai
2023-01-04 10:55 ` Markus Schneider-Pargmann
2022-12-23 9:42 ` [PATCH v2 02/23] clk: mediatek: mt8192: Propagate struct device for gate clocks AngeloGioacchino Del Regno
2022-12-26 6:56 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 03/23] clk: mediatek: clk-gate: Propagate struct device with mtk_clk_register_gates() AngeloGioacchino Del Regno
2022-12-26 7:05 ` Chen-Yu Tsai
2023-01-04 11:21 ` Markus Schneider-Pargmann
2023-01-10 11:05 ` AngeloGioacchino Del Regno
2022-12-23 9:42 ` [PATCH v2 04/23] clk: mediatek: cpumux: Propagate struct device where possible AngeloGioacchino Del Regno
2022-12-26 7:07 ` Chen-Yu Tsai
2023-01-06 17:00 ` Markus Schneider-Pargmann
2022-12-23 9:42 ` [PATCH v2 05/23] clk: mediatek: clk-mtk: Propagate struct device for composites AngeloGioacchino Del Regno
2022-12-30 4:37 ` Chen-Yu Tsai
2023-01-06 17:09 ` Markus Schneider-Pargmann
2022-12-23 9:42 ` [PATCH v2 06/23] clk: mediatek: clk-mux: Propagate struct device for mtk-mux AngeloGioacchino Del Regno
2022-12-30 4:43 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 07/23] clk: mediatek: clk-mtk: Add dummy clock ops AngeloGioacchino Del Regno
2022-12-28 7:24 ` Miles Chen
2022-12-30 5:19 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 08/23] clk: mediatek: mt8173: Migrate to platform driver and common probe AngeloGioacchino Del Regno
2022-12-30 8:22 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 09/23] clk: mediatek: mt8173: Remove mtk_clk_enable_critical() AngeloGioacchino Del Regno
2022-12-30 4:58 ` Chen-Yu Tsai
2023-01-10 12:32 ` AngeloGioacchino Del Regno
2023-01-11 2:27 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 10/23] clk: mediatek: mt8173: Break down clock drivers and allow module build AngeloGioacchino Del Regno
2022-12-24 1:47 ` kernel test robot
2022-12-24 7:13 ` Dan Carpenter [this message]
2022-12-23 9:42 ` [PATCH v2 11/23] clk: mediatek: Switch to mtk_clk_simple_probe() where possible AngeloGioacchino Del Regno
2022-12-28 7:50 ` Miles Chen
2022-12-30 5:12 ` Chen-Yu Tsai
2023-01-10 13:31 ` AngeloGioacchino Del Regno
2023-01-11 2:47 ` Chen-Yu Tsai
2023-01-11 8:56 ` [PATCH v2 11/23] clk: mediatek: Switch to mtk_clk_simple_probe() Miles Chen
2023-01-11 10:36 ` AngeloGioacchino Del Regno
2022-12-23 9:42 ` [PATCH v2 12/23] clk: mediatek: clk-mtk: Extend mtk_clk_simple_probe() AngeloGioacchino Del Regno
2022-12-27 16:22 ` Miles Chen
2022-12-30 7:14 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 13/23] clk: mediatek: mt8173: Migrate pericfg/topckgen to mtk_clk_simple_probe() AngeloGioacchino Del Regno
2022-12-28 7:54 ` Miles Chen
2022-12-30 7:15 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 14/23] clk: mediatek: clk-mt8192: Move CLK_TOP_CSW_F26M_D2 in top_divs AngeloGioacchino Del Regno
2022-12-28 7:58 ` Miles Chen
2022-12-30 5:17 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 15/23] clk: mediatek: mt8192: Join top_adj_divs and top_muxes AngeloGioacchino Del Regno
2022-12-28 8:31 ` Miles Chen
2022-12-30 8:09 ` Chen-Yu Tsai
2022-12-30 8:06 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 16/23] clk: mediatek: mt8186: Join top_adj_div " AngeloGioacchino Del Regno
2022-12-30 8:17 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 17/23] clk: mediatek: clk-mt8183: Join top_aud_muxes and top_aud_divs AngeloGioacchino Del Regno
2022-12-30 8:19 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 18/23] clk: mediatek: clk-mtk: Register MFG notifier in mtk_clk_simple_probe() AngeloGioacchino Del Regno
2022-12-29 8:21 ` Miles Chen
2022-12-30 8:12 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 19/23] clk: mediatek: clk-mt8192: Migrate topckgen to mtk_clk_simple_probe() AngeloGioacchino Del Regno
2022-12-30 8:18 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 20/23] clk: mediatek: clk-mt8186-topckgen: Migrate " AngeloGioacchino Del Regno
2022-12-30 5:55 ` Miles Chen
2022-12-30 8:15 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 21/23] clk: mediatek: clk-mt6795-topckgen: " AngeloGioacchino Del Regno
2022-12-30 5:56 ` Miles Chen
2022-12-30 8:13 ` Chen-Yu Tsai
2022-12-23 9:42 ` [PATCH v2 22/23] clk: mediatek: clk-mt7986-topckgen: Properly keep some clocks enabled AngeloGioacchino Del Regno
2022-12-30 5:23 ` Chen-Yu Tsai
2022-12-30 6:04 ` Miles Chen
2022-12-23 9:42 ` [PATCH v2 23/23] clk: mediatek: clk-mt7986-topckgen: Migrate to mtk_clk_simple_probe() AngeloGioacchino Del Regno
2022-12-27 16:18 ` [PATCH v2 12/23] clk: mediatek: clk-mtk: Extend mtk_clk_simple_probe() Miles Chen
2022-12-27 16:26 ` Miles Chen
2022-12-30 6:05 ` [PATCH v2 23/23] clk: mediatek: clk-mt7986-topckgen: Migrate to mtk_clk_simple_probe() Miles Chen
2022-12-30 8:14 ` Chen-Yu Tsai
2022-12-30 6:13 ` [PATCH v2 00/23] MediaTek clocks cleanups and improvements Miles Chen
2022-12-30 6:42 ` Chen-Yu Tsai
2022-12-30 7:19 ` Miles Chen
2023-01-03 9:36 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212240437.1D3FXJyP-lkp@intel.com \
--to=error27@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=ikjn@chromium.org \
--cc=johnson.wang@mediatek.com \
--cc=jose.exposito89@gmail.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lkp@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=msp@baylibre.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=pablo.sun@mediatek.com \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@kernel.org \
--cc=sam.shih@mediatek.com \
--cc=sboyd@kernel.org \
--cc=weiyi.lu@mediatek.com \
--cc=wenst@chromium.org \
--cc=y.oudjana@protonmail.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).