From: "Michał Grzelak" <mig@semihalf.com>
To: linux-kernel@vger.kernel.org
Cc: andrew@lunn.ch, sebastian.hesselbarth@gmail.com,
gregory.clement@bootlin.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
mw@semihalf.com, upstream@semihalf.com, mchl.grzlk@gmail.com,
"Michał Grzelak" <mig@semihalf.com>
Subject: [PATCH v3] ARM: dts: dove.dtsi: Move ethphy to fix schema error
Date: Thu, 29 Dec 2022 19:01:55 +0100 [thread overview]
Message-ID: <20221229180155.99303-1-mig@semihalf.com> (raw)
Running 'make dtbs_check' with schema in net/marvell,orion-mdio.yaml
gives following warnings:
mdio-bus@72004: Unevaluated properties are not allowed
('ethernet-phy' was unexpected)
arch/arm/boot/dts/dove-cubox.dtb
arch/arm/boot/dts/dove-cubox-es.dtb
arch/arm/boot/dts/dove-d2plug.dtb
arch/arm/boot/dts/dove-d2plug.dtb
arch/arm/boot/dts/dove-dove-db.dtb
arch/arm/boot/dts/dove-d3plug.dtb
arch/arm/boot/dts/dove-sbc-a510.dtb
As every subnode of mdio is expected to have an @X, ethernet-phy subnode
in dove.dtsi doesn't have one. Fix these errors by moving ethernet-phy
into relevant .dts files with correct @<reg address>.
Signed-off-by: Michał Grzelak <mig@semihalf.com>
---
Changelog:
v2->v3
- edit commit message according to
https://lore.kernel.org/all/Y6zuJrb+8j+XCksN@lunn.ch/
v1->v2
- remove patternProperties: from .yaml
- move ethphy from dove.dtsi into relevant .dts files
arch/arm/boot/dts/dove-cm-a510.dtsi | 14 +++++++++++---
arch/arm/boot/dts/dove-cubox.dts | 15 +++++++++++----
arch/arm/boot/dts/dove.dtsi | 5 -----
3 files changed, 22 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/dove-cm-a510.dtsi b/arch/arm/boot/dts/dove-cm-a510.dtsi
index 9b9dfbe07be4..2f2f0a4bf004 100644
--- a/arch/arm/boot/dts/dove-cm-a510.dtsi
+++ b/arch/arm/boot/dts/dove-cm-a510.dtsi
@@ -124,9 +124,17 @@ wifi_power: regulator@1 {
};
/* Optional RTL8211D GbE PHY on SMI address 0x03 */
-ðphy {
- reg = <3>;
- status = "disabled";
+&mdio {
+ ethphy: ethernet-phy@3 {
+ reg = <3>;
+ status = "disabled";
+ };
+};
+
+ð {
+ ethernet-port@0 {
+ phy-handle = <ðphy>;
+ };
};
&i2c0 {
diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
index 2639b9fe0ab4..170c14d7f5c8 100644
--- a/arch/arm/boot/dts/dove-cubox.dts
+++ b/arch/arm/boot/dts/dove-cubox.dts
@@ -72,11 +72,18 @@ gpu-subsystem {
&uart0 { status = "okay"; };
&sata0 { status = "okay"; };
&mdio { status = "okay"; };
-ð { status = "okay"; };
+ð {
+ status = "okay";
+ ethernet-port@0 {
+ phy-handle = <ðphy>;
+ };
+};
-ðphy {
- compatible = "marvell,88e1310";
- reg = <1>;
+&mdio {
+ ethphy: ethernet-phy@1 {
+ compatible = "marvell,88e1310";
+ reg = <1>;
+ };
};
&gpu {
diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 00a36fba2fd2..c7a3fa33c56e 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -382,7 +382,6 @@ ethernet-port@0 {
interrupts = <29>;
/* overwrite MAC address in bootloader */
local-mac-address = [00 00 00 00 00 00];
- phy-handle = <ðphy>;
};
};
@@ -394,10 +393,6 @@ mdio: mdio-bus@72004 {
interrupts = <30>;
clocks = <&gate_clk 2>;
status = "disabled";
-
- ethphy: ethernet-phy {
- /* set phy address in board file */
- };
};
sdio0: sdio-host@92000 {
--
2.34.1
next reply other threads:[~2022-12-29 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 18:01 Michał Grzelak [this message]
2022-12-30 16:00 ` [PATCH v3] ARM: dts: dove.dtsi: Move ethphy to fix schema error Andrew Lunn
2023-01-31 14:39 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229180155.99303-1-mig@semihalf.com \
--to=mig@semihalf.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchl.grzlk@gmail.com \
--cc=mw@semihalf.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox