From: Shawn Guo <shawnguo@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>, Fabio Estevam <festevam@gmail.com>
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [RFC] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
Date: Sat, 31 Dec 2022 15:04:37 +0800 [thread overview]
Message-ID: <20221231070436.GF6112@T480> (raw)
In-Reply-To: <20221119212436.2028208-1-festevam@gmail.com>
On Sat, Nov 19, 2022 at 06:24:36PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The following build warning is seen when running:
> make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
>
> arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
> From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
>
> The imx6qdl-gw560x board does not expose the UART RTS and CTS
> as native pins, so 'uart-has-rtscts' should not be used.
>
> Fix the problem by removing the 'uart-has-rtscts' property.
>
> Fixes: b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Hi,
>
> My understanding is that uart-has-rtscts indicates that the UART RTS
> and CTS pins are used natively and we cannot use uart-has-rtscts with
> rts-gpios.
>
> If this is correct, then I can also submit a patch fixing the arm64 Gateworks
> boards too.
Tim,
Any comments?
Shawn
>
> arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> index 4bc4371e6bae..4b81a975c979 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> @@ -632,7 +632,6 @@ &ssi1 {
> &uart1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_uart1>;
> - uart-has-rtscts;
> rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
> status = "okay";
> };
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-12-31 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 21:24 [RFC] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts' Fabio Estevam
2022-11-19 21:45 ` Fabio Estevam
2022-12-31 7:04 ` Shawn Guo [this message]
2023-01-03 18:09 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221231070436.GF6112@T480 \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=robh+dt@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox