devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mp-phycore-som: Remove invalid PMIC property
@ 2022-11-21 16:29 Fabio Estevam
  2022-11-23  7:47 ` Teresa Remmet
  2022-12-31  7:12 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2022-11-21 16:29 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
	Fabio Estevam, Teresa Remmet

From: Fabio Estevam <festevam@denx.de>

'regulator-compatible' is not a valid property according to
nxp,pca9450-regulator.yaml and causes the following warning:

  DTC_CHK arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb
...
pmic@25: regulators:LDO1: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)

Remove the invalid 'regulator-compatible' property.

Cc: Teresa Remmet <t.remmet@phytec.de>
Fixes: 88f7f6bcca37 ("arm64: dts: freescale: Add support for phyBOARD-Pollux-i.MX8MP")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
index 79b290a002c1..ecc4bce6db97 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
@@ -99,7 +99,6 @@ pmic: pmic@25 {
 
 		regulators {
 			buck1: BUCK1 {
-				regulator-compatible = "BUCK1";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <2187500>;
 				regulator-boot-on;
@@ -108,7 +107,6 @@ buck1: BUCK1 {
 			};
 
 			buck2: BUCK2 {
-				regulator-compatible = "BUCK2";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <2187500>;
 				regulator-boot-on;
@@ -119,7 +117,6 @@ buck2: BUCK2 {
 			};
 
 			buck4: BUCK4 {
-				regulator-compatible = "BUCK4";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <3400000>;
 				regulator-boot-on;
@@ -127,7 +124,6 @@ buck4: BUCK4 {
 			};
 
 			buck5: BUCK5 {
-				regulator-compatible = "BUCK5";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <3400000>;
 				regulator-boot-on;
@@ -135,7 +131,6 @@ buck5: BUCK5 {
 			};
 
 			buck6: BUCK6 {
-				regulator-compatible = "BUCK6";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <3400000>;
 				regulator-boot-on;
@@ -143,7 +138,6 @@ buck6: BUCK6 {
 			};
 
 			ldo1: LDO1 {
-				regulator-compatible = "LDO1";
 				regulator-min-microvolt = <1600000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
@@ -151,7 +145,6 @@ ldo1: LDO1 {
 			};
 
 			ldo2: LDO2 {
-				regulator-compatible = "LDO2";
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1150000>;
 				regulator-boot-on;
@@ -159,7 +152,6 @@ ldo2: LDO2 {
 			};
 
 			ldo3: LDO3 {
-				regulator-compatible = "LDO3";
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
@@ -167,13 +159,11 @@ ldo3: LDO3 {
 			};
 
 			ldo4: LDO4 {
-				regulator-compatible = "LDO4";
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <3300000>;
 			};
 
 			ldo5: LDO5 {
-				regulator-compatible = "LDO5";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-phycore-som: Remove invalid PMIC property
  2022-11-21 16:29 [PATCH] arm64: dts: imx8mp-phycore-som: Remove invalid PMIC property Fabio Estevam
@ 2022-11-23  7:47 ` Teresa Remmet
  2022-12-31  7:12 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Teresa Remmet @ 2022-11-23  7:47 UTC (permalink / raw)
  To: festevam@gmail.com, shawnguo@kernel.org
  Cc: linux-arm-kernel@lists.infradead.org, festevam@denx.de,
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org

Hello Fabio,

Am Montag, dem 21.11.2022 um 13:29 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
> 
> 'regulator-compatible' is not a valid property according to
> nxp,pca9450-regulator.yaml and causes the following warning:
> 
>   DTC_CHK arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb
> ...
> pmic@25: regulators:LDO1: Unevaluated properties are not allowed
> ('regulator-compatible' was unexpected)
> 
> Remove the invalid 'regulator-compatible' property.

Reviewed-by: Teresa Remmet <t.remmet@phytec.de>

thank you for the patch. I have noticed this already, too..
But the patch stack that includes this, still waits for getting 
finished up. So you where quicker.

Regards,
Teresa

> 
> Cc: Teresa Remmet <t.remmet@phytec.de>
> Fixes: 88f7f6bcca37 ("arm64: dts: freescale: Add support for
> phyBOARD-Pollux-i.MX8MP")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi | 10 -------
> ---
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> index 79b290a002c1..ecc4bce6db97 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> @@ -99,7 +99,6 @@ pmic: pmic@25 {
>  
>  		regulators {
>  			buck1: BUCK1 {
> -				regulator-compatible = "BUCK1";
>  				regulator-min-microvolt = <600000>;
>  				regulator-max-microvolt = <2187500>;
>  				regulator-boot-on;
> @@ -108,7 +107,6 @@ buck1: BUCK1 {
>  			};
>  
>  			buck2: BUCK2 {
> -				regulator-compatible = "BUCK2";
>  				regulator-min-microvolt = <600000>;
>  				regulator-max-microvolt = <2187500>;
>  				regulator-boot-on;
> @@ -119,7 +117,6 @@ buck2: BUCK2 {
>  			};
>  
>  			buck4: BUCK4 {
> -				regulator-compatible = "BUCK4";
>  				regulator-min-microvolt = <600000>;
>  				regulator-max-microvolt = <3400000>;
>  				regulator-boot-on;
> @@ -127,7 +124,6 @@ buck4: BUCK4 {
>  			};
>  
>  			buck5: BUCK5 {
> -				regulator-compatible = "BUCK5";
>  				regulator-min-microvolt = <600000>;
>  				regulator-max-microvolt = <3400000>;
>  				regulator-boot-on;
> @@ -135,7 +131,6 @@ buck5: BUCK5 {
>  			};
>  
>  			buck6: BUCK6 {
> -				regulator-compatible = "BUCK6";
>  				regulator-min-microvolt = <600000>;
>  				regulator-max-microvolt = <3400000>;
>  				regulator-boot-on;
> @@ -143,7 +138,6 @@ buck6: BUCK6 {
>  			};
>  
>  			ldo1: LDO1 {
> -				regulator-compatible = "LDO1";
>  				regulator-min-microvolt = <1600000>;
>  				regulator-max-microvolt = <3300000>;
>  				regulator-boot-on;
> @@ -151,7 +145,6 @@ ldo1: LDO1 {
>  			};
>  
>  			ldo2: LDO2 {
> -				regulator-compatible = "LDO2";
>  				regulator-min-microvolt = <800000>;
>  				regulator-max-microvolt = <1150000>;
>  				regulator-boot-on;
> @@ -159,7 +152,6 @@ ldo2: LDO2 {
>  			};
>  
>  			ldo3: LDO3 {
> -				regulator-compatible = "LDO3";
>  				regulator-min-microvolt = <800000>;
>  				regulator-max-microvolt = <3300000>;
>  				regulator-boot-on;
> @@ -167,13 +159,11 @@ ldo3: LDO3 {
>  			};
>  
>  			ldo4: LDO4 {
> -				regulator-compatible = "LDO4";
>  				regulator-min-microvolt = <800000>;
>  				regulator-max-microvolt = <3300000>;
>  			};
>  
>  			ldo5: LDO5 {
> -				regulator-compatible = "LDO5";
>  				regulator-min-microvolt = <1800000>;
>  				regulator-max-microvolt = <3300000>;
>  				regulator-boot-on;
-- 
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber |
Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE
149059855

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-phycore-som: Remove invalid PMIC property
  2022-11-21 16:29 [PATCH] arm64: dts: imx8mp-phycore-som: Remove invalid PMIC property Fabio Estevam
  2022-11-23  7:47 ` Teresa Remmet
@ 2022-12-31  7:12 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-12-31  7:12 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
	Fabio Estevam, Teresa Remmet

On Mon, Nov 21, 2022 at 01:29:11PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> 'regulator-compatible' is not a valid property according to
> nxp,pca9450-regulator.yaml and causes the following warning:
> 
>   DTC_CHK arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb
> ...
> pmic@25: regulators:LDO1: Unevaluated properties are not allowed ('regulator-compatible' was unexpected)
> 
> Remove the invalid 'regulator-compatible' property.
> 
> Cc: Teresa Remmet <t.remmet@phytec.de>
> Fixes: 88f7f6bcca37 ("arm64: dts: freescale: Add support for phyBOARD-Pollux-i.MX8MP")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-31  7:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-21 16:29 [PATCH] arm64: dts: imx8mp-phycore-som: Remove invalid PMIC property Fabio Estevam
2022-11-23  7:47 ` Teresa Remmet
2022-12-31  7:12 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).