* [PATCH] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
@ 2022-11-21 20:22 Fabio Estevam
2022-11-28 21:35 ` Tim Harvey
2022-12-31 7:19 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2022-11-21 20:22 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, tharvey,
linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The following build warning is seen when running:
make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
The imx6qdl-gw560x board does not expose the UART RTS and CTS
as native UART pins, so 'uart-has-rtscts' should not be used.
Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination
detected by serial.yaml.
Fix the problem by removing the incorrect 'uart-has-rtscts' property.
Fixes: b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
index 4bc4371e6bae..4b81a975c979 100644
--- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
@@ -632,7 +632,6 @@ &ssi1 {
&uart1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>;
- uart-has-rtscts;
rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
status = "okay";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
2022-11-21 20:22 [PATCH] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts' Fabio Estevam
@ 2022-11-28 21:35 ` Tim Harvey
2022-12-31 7:19 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Tim Harvey @ 2022-11-28 21:35 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, Fabio Estevam
On Mon, Nov 21, 2022 at 12:23 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> The following build warning is seen when running:
>
> make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
>
> arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
> From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
>
> The imx6qdl-gw560x board does not expose the UART RTS and CTS
> as native UART pins, so 'uart-has-rtscts' should not be used.
>
> Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination
> detected by serial.yaml.
>
> Fix the problem by removing the incorrect 'uart-has-rtscts' property.
>
> Fixes: b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> index 4bc4371e6bae..4b81a975c979 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
> @@ -632,7 +632,6 @@ &ssi1 {
> &uart1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_uart1>;
> - uart-has-rtscts;
> rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
> status = "okay";
> };
> --
> 2.25.1
>
Fabio,
Thanks,
Acked-by: Tim Harvey <tharvey@gateworks.com>
Best Regards,
Tim
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
2022-11-21 20:22 [PATCH] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts' Fabio Estevam
2022-11-28 21:35 ` Tim Harvey
@ 2022-12-31 7:19 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-12-31 7:19 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, tharvey,
linux-arm-kernel, Fabio Estevam
On Mon, Nov 21, 2022 at 05:22:59PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The following build warning is seen when running:
>
> make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
>
> arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
> From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
>
> The imx6qdl-gw560x board does not expose the UART RTS and CTS
> as native UART pins, so 'uart-has-rtscts' should not be used.
>
> Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination
> detected by serial.yaml.
>
> Fix the problem by removing the incorrect 'uart-has-rtscts' property.
>
> Fixes: b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-31 7:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-21 20:22 [PATCH] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts' Fabio Estevam
2022-11-28 21:35 ` Tim Harvey
2022-12-31 7:19 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).