* [PATCH v1] arm64: dts: verdin-imx8mm: fix dahlia audio playback
@ 2022-12-01 12:55 Francesco Dolcini
2022-12-08 1:18 ` Fabio Estevam
2022-12-31 12:29 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Francesco Dolcini @ 2022-12-01 12:55 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Emanuele Ghidoli, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, Francesco Dolcini
From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Set optional `simple-audio-card,mclk-fs` parameter to ensure a proper
clock to the wm8904 audio codec. Without this change with an audio
stream rate of 44.1 kHz the playback is completely distorted.
Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
index c2a5c2f7b204..7c3f5c54f040 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
@@ -9,6 +9,7 @@ sound_card: sound-card {
simple-audio-card,bitclock-master = <&dailink_master>;
simple-audio-card,format = "i2s";
simple-audio-card,frame-master = <&dailink_master>;
+ simple-audio-card,mclk-fs = <256>;
simple-audio-card,name = "imx8mm-wm8904";
simple-audio-card,routing =
"Headphone Jack", "HPOUTL",
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] arm64: dts: verdin-imx8mm: fix dahlia audio playback
2022-12-01 12:55 [PATCH v1] arm64: dts: verdin-imx8mm: fix dahlia audio playback Francesco Dolcini
@ 2022-12-08 1:18 ` Fabio Estevam
2022-12-31 12:29 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2022-12-08 1:18 UTC (permalink / raw)
To: Francesco Dolcini
Cc: linux-arm-kernel, Emanuele Ghidoli, Rob Herring,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team, devicetree,
Francesco Dolcini
On Thu, Dec 1, 2022 at 9:56 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
>
> Set optional `simple-audio-card,mclk-fs` parameter to ensure a proper
> clock to the wm8904 audio codec. Without this change with an audio
> stream rate of 44.1 kHz the playback is completely distorted.
>
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] arm64: dts: verdin-imx8mm: fix dahlia audio playback
2022-12-01 12:55 [PATCH v1] arm64: dts: verdin-imx8mm: fix dahlia audio playback Francesco Dolcini
2022-12-08 1:18 ` Fabio Estevam
@ 2022-12-31 12:29 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-12-31 12:29 UTC (permalink / raw)
To: Francesco Dolcini
Cc: linux-arm-kernel, Emanuele Ghidoli, Rob Herring,
Krzysztof Kozlowski, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, devicetree, Francesco Dolcini
On Thu, Dec 01, 2022 at 01:55:48PM +0100, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
>
> Set optional `simple-audio-card,mclk-fs` parameter to ensure a proper
> clock to the wm8904 audio codec. Without this change with an audio
> stream rate of 44.1 kHz the playback is completely distorted.
>
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-31 12:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-01 12:55 [PATCH v1] arm64: dts: verdin-imx8mm: fix dahlia audio playback Francesco Dolcini
2022-12-08 1:18 ` Fabio Estevam
2022-12-31 12:29 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).