devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Nikolaus Voss <nikolaus.voss@haag-streit.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	nv@vosn.de, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] imx6qdl.dtsi: use MAC-address from nvmem
Date: Sun, 1 Jan 2023 10:19:37 +0800	[thread overview]
Message-ID: <20230101021936.GG6112@T480> (raw)
In-Reply-To: <Y7BsmULn+VQNP3g+@lunn.ch>

On Sat, Dec 31, 2022 at 06:08:41PM +0100, Andrew Lunn wrote:
> > > @@ -1053,6 +1053,8 @@ fec: ethernet@2188000 {
> > >  					 <&clks IMX6QDL_CLK_ENET_REF>;
> > >  				clock-names = "ipg", "ahb", "ptp", "enet_out";
> > >  				fsl,stop-mode = <&gpr 0x34 27>;
> > > +				nvmem-cells = <&fec_mac_addr>;
> > > +				nvmem-cell-names = "mac-address";
> > 
> > May I ask where is the support of FEC driver for this?
> 
> The fec uses of_get_mac_address() which calls
> of_get_mac_address_nvmem() as its last place to look for the MAC
> address.

Ah, of_get_mac_address() gets extended to call of_get_mac_address_nvmem()
nowadays.  Thanks, Andrew!

Shawn

  reply	other threads:[~2023-01-01  2:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 14:27 [PATCH 2/2] imx6qdl.dtsi: use MAC-address from nvmem Nikolaus Voss
2022-12-31  6:49 ` Shawn Guo
2022-12-31 17:08   ` Andrew Lunn
2023-01-01  2:19     ` Shawn Guo [this message]
2023-01-01  2:32 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230101021936.GG6112@T480 \
    --to=shawnguo@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikolaus.voss@haag-streit.com \
    --cc=nv@vosn.de \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).