From: Rob Herring <robh@kernel.org>
To: Geoff Levand <geoff@infradead.org>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Frank Rowand <frowand.list@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] of: Fix handling CONFIG_CMDLINE* even without /chosen node
Date: Tue, 03 Jan 2023 12:00:31 -0600 [thread overview]
Message-ID: <20230103-dt-cmdline-fix-v1-0-7038e88b18b6@kernel.org> (raw)
Commit a7d550f82b445cf218b47a2c1a9c56e97ecb8c7a (of: fdt: Honor CONFIG_CMDLINE*
even without /chosen node) moved the processing of the kernel built-in command
line (CONFIG_CMDLINE) from the early_init_dt_scan_chosen routine to the
early_init_dt_scan_nodes routine.
The current powerpc startup code does not call into early_init_dt_scan_nodes, so
processing of CONFIG_CMDLINE never happens, even if CONFIG_CMDLINE_FORCE=y.
The result is an empty kernel command line, and mounting of the root file system
then fails with a kernel panic (not syncing: VFS: Unable to mount root fs).
Let's revert the above commit and redo the missing /chosen node handling
within early_init_dt_scan_chosen().
Signed-off-by: Rob Herring <robh@kernel.org>
---
Rob Herring (2):
Revert "of: fdt: Honor CONFIG_CMDLINE* even without /chosen node"
of: fdt: Honor CONFIG_CMDLINE* even without /chosen node, take 2
drivers/of/fdt.c | 54 ++++++++++++++++++++++++++++--------------------------
1 file changed, 28 insertions(+), 26 deletions(-)
---
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
change-id: 20230103-dt-cmdline-fix-e36eb7e39b75
Best regards,
--
Rob Herring <robh@kernel.org>
next reply other threads:[~2023-01-03 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 18:00 Rob Herring [this message]
2023-01-03 18:00 ` [PATCH 1/2] Revert "of: fdt: Honor CONFIG_CMDLINE* even without /chosen node" Rob Herring
2023-01-03 18:00 ` [PATCH 2/2] of: fdt: Honor CONFIG_CMDLINE* even without /chosen node, take 2 Rob Herring
2023-01-04 1:31 ` [PATCH 0/2] of: Fix handling CONFIG_CMDLINE* even without /chosen node Geoff Levand
2023-01-04 9:48 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103-dt-cmdline-fix-v1-0-7038e88b18b6@kernel.org \
--to=robh@kernel.org \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geoff@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).