From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 786C5C3DA7D for ; Tue, 3 Jan 2023 11:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236990AbjACLIm (ORCPT ); Tue, 3 Jan 2023 06:08:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237019AbjACLIU (ORCPT ); Tue, 3 Jan 2023 06:08:20 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AF485101B; Tue, 3 Jan 2023 03:08:19 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 924311516; Tue, 3 Jan 2023 03:09:00 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC7843F663; Tue, 3 Jan 2023 03:08:17 -0800 (PST) Date: Tue, 3 Jan 2023 11:08:15 +0000 From: Andre Przywara To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 1/2] ARM: dts: sunxi: Fix GPIO LED node names Message-ID: <20230103110815.0a047540@donnerap.cambridge.arm.com> In-Reply-To: <20221231225854.16320-1-samuel@sholland.org> References: <20221231225854.16320-1-samuel@sholland.org> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 31 Dec 2022 16:58:53 -0600 Samuel Holland wrote: > These board devicetrees fail to validate because the gpio-leds schema > requires its child nodes to have "led" in the node name. > > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > Changes in v2: > - Use the recommended enumerator pattern for LED node names > > arch/arm/boot/dts/sun5i-gr8-chip-pro.dts | 2 +- > arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +- > arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts > index a32cde3e32eb..5c3562b85a5b 100644 > --- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts > +++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts > @@ -70,7 +70,7 @@ chosen { > leds { > compatible = "gpio-leds"; > > - status { > + led-0 { > label = "chip-pro:white:status"; > gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>; > default-state = "on"; > diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/sun5i-r8-chip.dts > index 4bf4943d4eb7..fd37bd1f3920 100644 > --- a/arch/arm/boot/dts/sun5i-r8-chip.dts > +++ b/arch/arm/boot/dts/sun5i-r8-chip.dts > @@ -70,7 +70,7 @@ chosen { > leds { > compatible = "gpio-leds"; > > - status { > + led-0 { > label = "chip:white:status"; > gpios = <&axp_gpio 2 GPIO_ACTIVE_HIGH>; > default-state = "on"; > diff --git a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts > index 0af48e143b66..56956352914d 100644 > --- a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts > +++ b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts > @@ -67,7 +67,7 @@ hdmi_con_in: endpoint { > leds { > compatible = "gpio-leds"; > > - status { > + led-0 { > label = "sina31s:status:usr"; > gpios = <&pio 7 13 GPIO_ACTIVE_HIGH>; /* PH13 */ > };