* [PATCH] dt-bindings: clock: qcom,videocc: correct clocks per variant
@ 2022-12-24 15:41 Krzysztof Kozlowski
2023-01-04 1:25 ` Stephen Boyd
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-24 15:41 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-arm-msm, linux-clk, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Different SoCs come with a bit different clock inputs:
sm8250-mtp.dtb: clock-controller@abf0000: clock-names:0: 'bi_tcxo' was expected
sm8250-mtp.dtb: clock-controller@abf0000: clock-names: ['iface', 'bi_tcxo', 'bi_tcxo_ao'] is too long
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/clock/qcom,videocc.yaml | 59 +++++++++++++++++--
1 file changed, 55 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
index e221985e743f..2b07146161b4 100644
--- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
@@ -30,12 +30,12 @@ properties:
- qcom,sm8250-videocc
clocks:
- items:
- - description: Board XO source
+ minItems: 1
+ maxItems: 3
clock-names:
- items:
- - const: bi_tcxo
+ minItems: 1
+ maxItems: 3
'#clock-cells':
const: 1
@@ -68,6 +68,57 @@ required:
- '#reset-cells'
- '#power-domain-cells'
+allOf:
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sc7180-videocc
+ - qcom,sdm845-videocc
+ - qcom,sm8150-videocc
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Board XO source
+ clock-names:
+ items:
+ - const: bi_tcxo
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sc7280-videocc
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Board XO source
+ - description: Board active XO source
+ clock-names:
+ items:
+ - const: bi_tcxo
+ - const: bi_tcxo_ao
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sm8250-videocc
+ then:
+ properties:
+ clocks:
+ items:
+ - description: AHB
+ - description: Board XO source
+ - description: Board active XO source
+ clock-names:
+ items:
+ - const: iface
+ - const: bi_tcxo
+ - const: bi_tcxo_ao
+
additionalProperties: false
examples:
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: qcom,videocc: correct clocks per variant
2022-12-24 15:41 [PATCH] dt-bindings: clock: qcom,videocc: correct clocks per variant Krzysztof Kozlowski
@ 2023-01-04 1:25 ` Stephen Boyd
2023-01-17 16:50 ` Rob Herring
2023-01-17 18:24 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2023-01-04 1:25 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski,
Krzysztof Kozlowski, Michael Turquette, Rob Herring, Taniya Das,
devicetree, linux-arm-msm, linux-clk, linux-kernel
Cc: Krzysztof Kozlowski
Quoting Krzysztof Kozlowski (2022-12-24 07:41:52)
> Different SoCs come with a bit different clock inputs:
>
> sm8250-mtp.dtb: clock-controller@abf0000: clock-names:0: 'bi_tcxo' was expected
> sm8250-mtp.dtb: clock-controller@abf0000: clock-names: ['iface', 'bi_tcxo', 'bi_tcxo_ao'] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: qcom,videocc: correct clocks per variant
2022-12-24 15:41 [PATCH] dt-bindings: clock: qcom,videocc: correct clocks per variant Krzysztof Kozlowski
2023-01-04 1:25 ` Stephen Boyd
@ 2023-01-17 16:50 ` Rob Herring
2023-01-17 18:24 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-01-17 16:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-clk, Bjorn Andersson, Andy Gross, linux-arm-msm,
Krzysztof Kozlowski, Stephen Boyd, devicetree, linux-kernel,
Rob Herring, Michael Turquette, Konrad Dybcio, Taniya Das
On Sat, 24 Dec 2022 16:41:52 +0100, Krzysztof Kozlowski wrote:
> Different SoCs come with a bit different clock inputs:
>
> sm8250-mtp.dtb: clock-controller@abf0000: clock-names:0: 'bi_tcxo' was expected
> sm8250-mtp.dtb: clock-controller@abf0000: clock-names: ['iface', 'bi_tcxo', 'bi_tcxo_ao'] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/clock/qcom,videocc.yaml | 59 +++++++++++++++++--
> 1 file changed, 55 insertions(+), 4 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: qcom,videocc: correct clocks per variant
2022-12-24 15:41 [PATCH] dt-bindings: clock: qcom,videocc: correct clocks per variant Krzysztof Kozlowski
2023-01-04 1:25 ` Stephen Boyd
2023-01-17 16:50 ` Rob Herring
@ 2023-01-17 18:24 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-01-17 18:24 UTC (permalink / raw)
To: devicetree, sboyd, linux-arm-msm, robh+dt, krzysztof.kozlowski,
mturquette, tdas, agross, krzysztof.kozlowski+dt, konrad.dybcio,
linux-clk, linux-kernel
On Sat, 24 Dec 2022 16:41:52 +0100, Krzysztof Kozlowski wrote:
> Different SoCs come with a bit different clock inputs:
>
> sm8250-mtp.dtb: clock-controller@abf0000: clock-names:0: 'bi_tcxo' was expected
> sm8250-mtp.dtb: clock-controller@abf0000: clock-names: ['iface', 'bi_tcxo', 'bi_tcxo_ao'] is too long
>
>
Applied, thanks!
[1/1] dt-bindings: clock: qcom,videocc: correct clocks per variant
commit: 06839dfc87984ae73d2204a8efa4c7e7b6e12d97
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-17 19:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-24 15:41 [PATCH] dt-bindings: clock: qcom,videocc: correct clocks per variant Krzysztof Kozlowski
2023-01-04 1:25 ` Stephen Boyd
2023-01-17 16:50 ` Rob Herring
2023-01-17 18:24 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).