From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479F5C5479D for ; Fri, 6 Jan 2023 14:09:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbjAFOJB (ORCPT ); Fri, 6 Jan 2023 09:09:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233697AbjAFOJA (ORCPT ); Fri, 6 Jan 2023 09:09:00 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82A5F77AFC for ; Fri, 6 Jan 2023 06:08:59 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDnOz-0003ne-8H; Fri, 06 Jan 2023 15:08:57 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pDnOx-00045e-8P; Fri, 06 Jan 2023 15:08:55 +0100 Date: Fri, 6 Jan 2023 15:08:55 +0100 From: Michael Tretter To: Laurent Pinchart Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/8] media: imx-pxp: explicitly disable unused blocks Message-ID: <20230106140855.GD24101@pengutronix.de> Mail-Followup-To: Michael Tretter , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org References: <20230105134729.59542-1-m.tretter@pengutronix.de> <20230105134729.59542-5-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 06 Jan 2023 14:26:40 +0200, Laurent Pinchart wrote: > On Thu, Jan 05, 2023 at 02:47:25PM +0100, Michael Tretter wrote: > > Various multiplexers in the pipeline are not used with the currently > > configured data path. Disable all unused multiplexers by selecting the > > "no output" (3) option. > > > > The datasheet doesn't explicitly require this, but the PXP has been seen > > to hang after processing a few hundreds of frames otherwise. > > On which platform(s) have you noticed that ? I didn't observe this myself, but took this information from the comment in your earlier patch [0] that disables the unused multiplexers. https://lore.kernel.org/linux-media/20200510223100.11641-2-laurent.pinchart@ideasonboard.com/ > > > As at it, add documentation for the multiplexers that are actually > > relevant for the data path. > > > > Signed-off-by: Michael Tretter > > --- > > drivers/media/platform/nxp/imx-pxp.c | 30 +++++++++++++++++----------- > > 1 file changed, 18 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c > > index a957fee88829..6ffd07cda965 100644 > > --- a/drivers/media/platform/nxp/imx-pxp.c > > +++ b/drivers/media/platform/nxp/imx-pxp.c > > @@ -731,22 +731,28 @@ static u32 pxp_data_path_ctrl0(struct pxp_ctx *ctx) > > u32 ctrl0; > > > > ctrl0 = 0; > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX15_SEL(0); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX15_SEL(3); > > + /* Bypass Dithering x3CH */ > > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX14_SEL(1); > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX13_SEL(0); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX13_SEL(3); > > + /* Select Rotation */ > > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX12_SEL(0); > > + /* Select LUT */ > > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX11_SEL(0); > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX10_SEL(0); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX10_SEL(3); > > + /* Select MUX8 for LUT */ > > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX9_SEL(1); > > + /* Select CSC 2 */ > > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX8_SEL(0); > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX7_SEL(0); > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX6_SEL(0); > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX5_SEL(0); > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX4_SEL(0); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX7_SEL(3); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX6_SEL(3); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX5_SEL(3); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX4_SEL(3); > > + /* Bypass Rotation 2 */ > > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX3_SEL(0); > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX2_SEL(0); > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX1_SEL(0); > > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX0_SEL(0); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX2_SEL(3); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX1_SEL(3); > > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX0_SEL(3); > > The muxes being disabled look fine to me, but the values of MUX8, MUX12 > and MUX14 look strange based on the i.MX7D reference manual. Maybe the > register values were different in previous SoCs ? I haven't found any > other relevant reference manual that document the mux values, I may have > overlooked something. The MUX8, MUX12 and MUX14 are documented in the i.MX6ULL reference manual section 41.11.51 and their location and function in the data path is shown in Figure 41-1. "PXP Architecture" on page 2490. Michael > > Anyway, this isn't an issue with this patch, so > > Reviewed-by: Laurent Pinchart > > > > > return ctrl0; > > } > > @@ -760,8 +766,8 @@ static void pxp_set_data_path(struct pxp_ctx *ctx) > > ctrl0 = pxp_data_path_ctrl0(ctx); > > > > ctrl1 = 0; > > - ctrl1 |= BF_PXP_DATA_PATH_CTRL1_MUX17_SEL(1); > > - ctrl1 |= BF_PXP_DATA_PATH_CTRL1_MUX16_SEL(1); > > + ctrl1 |= BF_PXP_DATA_PATH_CTRL1_MUX17_SEL(3); > > + ctrl1 |= BF_PXP_DATA_PATH_CTRL1_MUX16_SEL(3); > > > > writel(ctrl0, dev->mmio + HW_PXP_DATA_PATH_CTRL0); > > writel(ctrl1, dev->mmio + HW_PXP_DATA_PATH_CTRL1);