From: Rob Herring <robh@kernel.org>
To: Faiz Abbas <faiz.abbas@arm.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com, krzysztof.kozlowski+dt@linaro.org,
kuninori.morimoto.gx@renesas.com, Anurag.Koul@arm.com,
Deepak.Pandey@arm.com
Subject: Re: [PATCH] ASoC: dt-bindings: simple-card: Document simple-audio-card,plat
Date: Sun, 8 Jan 2023 10:37:41 -0600 [thread overview]
Message-ID: <20230108163741.GA30997-robh@kernel.org> (raw)
In-Reply-To: <20230105160346.29018-1-faiz.abbas@arm.com>
On Thu, Jan 05, 2023 at 09:33:46PM +0530, Faiz Abbas wrote:
> The simple card driver has support for adding cpu, codec and platform
> nodes with the simple-audio-card prefix. Add documentation for the plat
> binding.
Another node, is it still 'simple card'?
>
> Signed-off-by: Faiz Abbas <faiz.abbas@arm.com>
> ---
> .../bindings/sound/simple-card.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
> index ed19899bc94b..fa67c76d4dbb 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
> @@ -205,6 +205,8 @@ patternProperties:
> $ref: "#/definitions/dai"
> "^simple-audio-card,codec(@[0-9a-f]+)?$":
> $ref: "#/definitions/dai"
> + "^simple-audio-card,plat(@[0-9a-f]+)?$":
What does 'plat' mean?
Don't continue the 'simple-audio-card,' prefix.
> + $ref: "#/definitions/dai"
>
> "^simple-audio-card,dai-link(@[0-9a-f]+)?$":
> description: |
> @@ -285,6 +287,27 @@ examples:
> };
> };
>
> +#-------------------------------
> +# single DAI link with platform
> +#-------------------------------
Really need another example for 1 simple node?
> + - |
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,mclk-fs = <384>;
> + simple-audio-card,cpu {
> + sound-dai = <&iofpga_i2s>;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&hdmi_tx>;
> + };
> +
> + simple-audio-card,plat {
> + sound-dai = <&audio_formatter>;
> + };
> +};
> +
> #--------------------
> # Multi DAI links
> #--------------------
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2023-01-08 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 16:03 [PATCH] ASoC: dt-bindings: simple-card: Document simple-audio-card,plat Faiz Abbas
2023-01-06 3:18 ` Rob Herring
2023-01-08 16:37 ` Rob Herring [this message]
2023-01-10 8:23 ` Mohammad Faiz Abbas Rizvi
2023-01-10 8:45 ` Krzysztof Kozlowski
2023-01-11 10:14 ` Mohammad Faiz Abbas Rizvi
2023-01-12 10:27 ` Mark Brown
2023-01-23 16:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108163741.GA30997-robh@kernel.org \
--to=robh@kernel.org \
--cc=Anurag.Koul@arm.com \
--cc=Deepak.Pandey@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=faiz.abbas@arm.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).