devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sdm845: make DP node follow the schema
@ 2023-01-09  4:17 Dmitry Baryshkov
  2023-01-09 10:38 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-01-09  4:17 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree

Drop the #clock-cells (leftover probably from the times before the DP
PHY split) and rename dp-opp-table to just opp-table.

Fixes: eaac4e55a6f4 ("arm64: dts: qcom: sdm845: add displayport node")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 9e881e19b984..fa62479206ce 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4593,7 +4593,6 @@ mdss_dp: displayport-controller@ae90000 {
 					 <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>;
 				clock-names = "core_iface", "core_aux", "ctrl_link",
 					      "ctrl_link_iface", "stream_pixel";
-				#clock-cells = <1>;
 				assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>,
 						  <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
 				assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>;
@@ -4619,7 +4618,7 @@ port@1 {
 					};
 				};
 
-				dp_opp_table: dp-opp-table {
+				dp_opp_table: opp-table {
 					compatible = "operating-points-v2";
 
 					opp-162000000 {
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sdm845: make DP node follow the schema
  2023-01-09  4:17 [PATCH] arm64: dts: qcom: sdm845: make DP node follow the schema Dmitry Baryshkov
@ 2023-01-09 10:38 ` Krzysztof Kozlowski
  2023-01-09 11:01   ` Dmitry Baryshkov
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-09 10:38 UTC (permalink / raw)
  To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree

On 09/01/2023 05:17, Dmitry Baryshkov wrote:
> Drop the #clock-cells (leftover probably from the times before the DP
> PHY split) and rename dp-opp-table to just opp-table.
> 
> Fixes: eaac4e55a6f4 ("arm64: dts: qcom: sdm845: add displayport node")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 9e881e19b984..fa62479206ce 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4593,7 +4593,6 @@ mdss_dp: displayport-controller@ae90000 {
>  					 <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>;
>  				clock-names = "core_iface", "core_aux", "ctrl_link",
>  					      "ctrl_link_iface", "stream_pixel";
> -				#clock-cells = <1>;
>  				assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>,
>  						  <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
>  				assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>;
> @@ -4619,7 +4618,7 @@ port@1 {
>  					};
>  				};
>  
> -				dp_opp_table: dp-opp-table {
> +				dp_opp_table: opp-table {

Already done:
https://patchwork.kernel.org/project/linux-arm-msm/patch/20221225115844.55126-2-krzysztof.kozlowski@linaro.org/

Please rebase on top of my changes or just drop this part.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sdm845: make DP node follow the schema
  2023-01-09 10:38 ` Krzysztof Kozlowski
@ 2023-01-09 11:01   ` Dmitry Baryshkov
  0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-01-09 11:01 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree

On 09/01/2023 12:38, Krzysztof Kozlowski wrote:
> On 09/01/2023 05:17, Dmitry Baryshkov wrote:
>> Drop the #clock-cells (leftover probably from the times before the DP
>> PHY split) and rename dp-opp-table to just opp-table.
>>
>> Fixes: eaac4e55a6f4 ("arm64: dts: qcom: sdm845: add displayport node")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index 9e881e19b984..fa62479206ce 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -4593,7 +4593,6 @@ mdss_dp: displayport-controller@ae90000 {
>>   					 <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>;
>>   				clock-names = "core_iface", "core_aux", "ctrl_link",
>>   					      "ctrl_link_iface", "stream_pixel";
>> -				#clock-cells = <1>;
>>   				assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>,
>>   						  <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
>>   				assigned-clock-parents = <&dp_phy 0>, <&dp_phy 1>;
>> @@ -4619,7 +4618,7 @@ port@1 {
>>   					};
>>   				};
>>   
>> -				dp_opp_table: dp-opp-table {
>> +				dp_opp_table: opp-table {
> 
> Already done:
> https://patchwork.kernel.org/project/linux-arm-msm/patch/20221225115844.55126-2-krzysztof.kozlowski@linaro.org/
> 
> Please rebase on top of my changes or just drop this part.

Ack, thanks for the pointer.

-- 
With best wishes
Dmitry


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-09 11:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-09  4:17 [PATCH] arm64: dts: qcom: sdm845: make DP node follow the schema Dmitry Baryshkov
2023-01-09 10:38 ` Krzysztof Kozlowski
2023-01-09 11:01   ` Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).