From: Michael Walle <michael@walle.cc>
To: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Xu Liang <lxu@maxlinear.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael Walle <michael@walle.cc>
Subject: [PATCH net-next v3 4/4] net: phy: mxl-gpy: disable interrupts on GPY215 by default
Date: Mon, 9 Jan 2023 13:30:13 +0100 [thread overview]
Message-ID: <20230109123013.3094144-5-michael@walle.cc> (raw)
In-Reply-To: <20230109123013.3094144-1-michael@walle.cc>
The interrupts on the GPY215B and GPY215C are broken and the only viable
fix is to disable them altogether. There is still the possibilty to
opt-in via the device tree.
Signed-off-by: Michael Walle <michael@walle.cc>
---
drivers/net/phy/mxl-gpy.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
index 147d7a5a9b35..e5972b4ef6e8 100644
--- a/drivers/net/phy/mxl-gpy.c
+++ b/drivers/net/phy/mxl-gpy.c
@@ -12,6 +12,7 @@
#include <linux/mutex.h>
#include <linux/phy.h>
#include <linux/polynomial.h>
+#include <linux/property.h>
#include <linux/netdevice.h>
/* PHY ID */
@@ -292,6 +293,10 @@ static int gpy_probe(struct phy_device *phydev)
phydev->priv = priv;
mutex_init(&priv->mbox_lock);
+ if (gpy_has_broken_mdint(phydev) &&
+ !device_property_present(dev, "maxlinear,use-broken-interrupts"))
+ phydev->dev_flags |= PHY_F_NO_IRQ;
+
fw_version = phy_read(phydev, PHY_FWV);
if (fw_version < 0)
return fw_version;
--
2.30.2
next prev parent reply other threads:[~2023-01-09 12:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 12:30 [PATCH net-next v3 0/4] net: phy: mxl-gpy: broken interrupt fixes Michael Walle
2023-01-09 12:30 ` [PATCH net-next v3 1/4] dt-bindings: vendor-prefixes: add MaxLinear Michael Walle
2023-01-09 12:30 ` [PATCH net-next v3 2/4] dt-bindings: net: phy: add MaxLinear GPY2xx bindings Michael Walle
2023-01-09 13:39 ` Andrew Lunn
2023-01-11 20:26 ` Rob Herring
2023-01-11 21:24 ` Andrew Lunn
2023-01-11 22:30 ` Michael Walle
2023-01-11 22:48 ` Andrew Lunn
2023-01-13 16:38 ` Rob Herring
2023-01-13 21:48 ` Michael Walle
2023-01-09 12:30 ` [PATCH net-next v3 3/4] net: phy: allow a phy to opt-out of interrupt handling Michael Walle
2023-01-09 13:40 ` Andrew Lunn
2023-01-09 12:30 ` Michael Walle [this message]
2023-01-09 13:41 ` [PATCH net-next v3 4/4] net: phy: mxl-gpy: disable interrupts on GPY215 by default Andrew Lunn
2023-01-10 13:10 ` [PATCH net-next v3 0/4] net: phy: mxl-gpy: broken interrupt fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109123013.3094144-5-michael@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).