devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels
@ 2023-01-11  8:23 Johan Hovold
  2023-01-11  8:23 ` [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include Johan Hovold
  2023-01-11  8:23 ` [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels Johan Hovold
  0 siblings, 2 replies; 9+ messages in thread
From: Johan Hovold @ 2023-01-11  8:23 UTC (permalink / raw)
  To: Bjorn Andersson, Andy Gross
  Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Eric Chanudet,
	Andrew Halaney, Brian Masney, linux-arm-msm, devicetree,
	linux-kernel, Johan Hovold

These patches add a missing include to the new sa8540p-pmics dtsi and
rename the PMIC labels so that they reflect the actual name of the
PMICs.

Johan


Johan Hovold (2):
  arm64: dts: qcom: sa8450p-pmics: add missing interrupt include
  arm64: dts: qcom: sa8450p-pmics: rename pmic labels

 arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi | 25 +++++++++++----------
 1 file changed, 13 insertions(+), 12 deletions(-)

-- 
2.38.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include
  2023-01-11  8:23 [PATCH 0/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels Johan Hovold
@ 2023-01-11  8:23 ` Johan Hovold
  2023-01-11 10:49   ` Brian Masney
  2023-01-11 15:06   ` Eric Chanudet
  2023-01-11  8:23 ` [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels Johan Hovold
  1 sibling, 2 replies; 9+ messages in thread
From: Johan Hovold @ 2023-01-11  8:23 UTC (permalink / raw)
  To: Bjorn Andersson, Andy Gross
  Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Eric Chanudet,
	Andrew Halaney, Brian Masney, linux-arm-msm, devicetree,
	linux-kernel, Johan Hovold

Add the missing interrupt-controller include which is needed by the RTC
node.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
index c9b8da43b237..8c393f0bd6a8 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
@@ -4,6 +4,7 @@
  * Copyright (c) 2022, Linaro Limited
  */
 
+#include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/spmi/spmi.h>
 
 &spmi_bus {
-- 
2.38.2


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels
  2023-01-11  8:23 [PATCH 0/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels Johan Hovold
  2023-01-11  8:23 ` [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include Johan Hovold
@ 2023-01-11  8:23 ` Johan Hovold
  2023-01-11 10:53   ` Brian Masney
                     ` (2 more replies)
  1 sibling, 3 replies; 9+ messages in thread
From: Johan Hovold @ 2023-01-11  8:23 UTC (permalink / raw)
  To: Bjorn Andersson, Andy Gross
  Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Eric Chanudet,
	Andrew Halaney, Brian Masney, linux-arm-msm, devicetree,
	linux-kernel, Johan Hovold

The SA8540P PMICs are named PMM8540. Rename the devicetree source labels
to reflect this.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi | 24 ++++++++++-----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
index 8c393f0bd6a8..1221be89b3de 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
@@ -8,7 +8,7 @@
 #include <dt-bindings/spmi/spmi.h>
 
 &spmi_bus {
-	pm8450a: pmic@0 {
+	pmm8540a: pmic@0 {
 		compatible = "qcom,pm8150", "qcom,spmi-pmic";
 		reg = <0x0 SPMI_USID>;
 		#address-cells = <1>;
@@ -22,62 +22,62 @@ rtc@6000 {
 			wakeup-source;
 		};
 
-		pm8450a_gpios: gpio@c000 {
+		pmm8540a_gpios: gpio@c000 {
 			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
-			gpio-ranges = <&pm8450a_gpios 0 0 10>;
+			gpio-ranges = <&pmm8540a_gpios 0 0 10>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
 	};
 
-	pm8450c: pmic@4 {
+	pmm8540c: pmic@4 {
 		compatible = "qcom,pm8150", "qcom,spmi-pmic";
 		reg = <0x4 SPMI_USID>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		pm8450c_gpios: gpio@c000 {
+		pmm8540c_gpios: gpio@c000 {
 			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
-			gpio-ranges = <&pm8450c_gpios 0 0 10>;
+			gpio-ranges = <&pmm8540c_gpios 0 0 10>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
 	};
 
-	pm8450e: pmic@8 {
+	pmm8540e: pmic@8 {
 		compatible = "qcom,pm8150", "qcom,spmi-pmic";
 		reg = <0x8 SPMI_USID>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		pm8450e_gpios: gpio@c000 {
+		pmm8540e_gpios: gpio@c000 {
 			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
-			gpio-ranges = <&pm8450e_gpios 0 0 10>;
+			gpio-ranges = <&pmm8540e_gpios 0 0 10>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
 	};
 
-	pm8450g: pmic@c {
+	pmm8540g: pmic@c {
 		compatible = "qcom,pm8150", "qcom,spmi-pmic";
 		reg = <0xc SPMI_USID>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		pm8450g_gpios: gpio@c000 {
+		pmm8540g_gpios: gpio@c000 {
 			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
-			gpio-ranges = <&pm8450g_gpios 0 0 10>;
+			gpio-ranges = <&pmm8540g_gpios 0 0 10>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
-- 
2.38.2


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include
  2023-01-11  8:23 ` [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include Johan Hovold
@ 2023-01-11 10:49   ` Brian Masney
  2023-01-11 15:06   ` Eric Chanudet
  1 sibling, 0 replies; 9+ messages in thread
From: Brian Masney @ 2023-01-11 10:49 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Eric Chanudet, Andrew Halaney, linux-arm-msm,
	devicetree, linux-kernel

On Wed, Jan 11, 2023 at 09:23:30AM +0100, Johan Hovold wrote:
> Add the missing interrupt-controller include which is needed by the RTC
> node.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Brian Masney <bmasney@redhat.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels
  2023-01-11  8:23 ` [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels Johan Hovold
@ 2023-01-11 10:53   ` Brian Masney
  2023-01-11 11:54   ` Konrad Dybcio
  2023-01-11 15:12   ` Eric Chanudet
  2 siblings, 0 replies; 9+ messages in thread
From: Brian Masney @ 2023-01-11 10:53 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Eric Chanudet, Andrew Halaney, linux-arm-msm,
	devicetree, linux-kernel

On Wed, Jan 11, 2023 at 09:23:31AM +0100, Johan Hovold wrote:
> The SA8540P PMICs are named PMM8540. Rename the devicetree source labels
> to reflect this.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Brian Masney <bmasney@redhat.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels
  2023-01-11  8:23 ` [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels Johan Hovold
  2023-01-11 10:53   ` Brian Masney
@ 2023-01-11 11:54   ` Konrad Dybcio
  2023-01-11 15:12   ` Eric Chanudet
  2 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2023-01-11 11:54 UTC (permalink / raw)
  To: Johan Hovold, Bjorn Andersson, Andy Gross
  Cc: Rob Herring, Krzysztof Kozlowski, Eric Chanudet, Andrew Halaney,
	Brian Masney, linux-arm-msm, devicetree, linux-kernel



On 11.01.2023 09:23, Johan Hovold wrote:
> The SA8540P PMICs are named PMM8540. Rename the devicetree source labels
> to reflect this.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi | 24 ++++++++++-----------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
> index 8c393f0bd6a8..1221be89b3de 100644
> --- a/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi
> @@ -8,7 +8,7 @@
>  #include <dt-bindings/spmi/spmi.h>
>  
>  &spmi_bus {
> -	pm8450a: pmic@0 {
> +	pmm8540a: pmic@0 {
>  		compatible = "qcom,pm8150", "qcom,spmi-pmic";
>  		reg = <0x0 SPMI_USID>;
>  		#address-cells = <1>;
> @@ -22,62 +22,62 @@ rtc@6000 {
>  			wakeup-source;
>  		};
>  
> -		pm8450a_gpios: gpio@c000 {
> +		pmm8540a_gpios: gpio@c000 {
>  			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
>  			reg = <0xc000>;
>  			gpio-controller;
> -			gpio-ranges = <&pm8450a_gpios 0 0 10>;
> +			gpio-ranges = <&pmm8540a_gpios 0 0 10>;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  		};
>  	};
>  
> -	pm8450c: pmic@4 {
> +	pmm8540c: pmic@4 {
>  		compatible = "qcom,pm8150", "qcom,spmi-pmic";
>  		reg = <0x4 SPMI_USID>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		pm8450c_gpios: gpio@c000 {
> +		pmm8540c_gpios: gpio@c000 {
>  			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
>  			reg = <0xc000>;
>  			gpio-controller;
> -			gpio-ranges = <&pm8450c_gpios 0 0 10>;
> +			gpio-ranges = <&pmm8540c_gpios 0 0 10>;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  		};
>  	};
>  
> -	pm8450e: pmic@8 {
> +	pmm8540e: pmic@8 {
>  		compatible = "qcom,pm8150", "qcom,spmi-pmic";
>  		reg = <0x8 SPMI_USID>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		pm8450e_gpios: gpio@c000 {
> +		pmm8540e_gpios: gpio@c000 {
>  			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
>  			reg = <0xc000>;
>  			gpio-controller;
> -			gpio-ranges = <&pm8450e_gpios 0 0 10>;
> +			gpio-ranges = <&pmm8540e_gpios 0 0 10>;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  		};
>  	};
>  
> -	pm8450g: pmic@c {
> +	pmm8540g: pmic@c {
>  		compatible = "qcom,pm8150", "qcom,spmi-pmic";
>  		reg = <0xc SPMI_USID>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		pm8450g_gpios: gpio@c000 {
> +		pmm8540g_gpios: gpio@c000 {
>  			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
>  			reg = <0xc000>;
>  			gpio-controller;
> -			gpio-ranges = <&pm8450g_gpios 0 0 10>;
> +			gpio-ranges = <&pmm8540g_gpios 0 0 10>;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
>  			#interrupt-cells = <2>;

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include
  2023-01-11  8:23 ` [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include Johan Hovold
  2023-01-11 10:49   ` Brian Masney
@ 2023-01-11 15:06   ` Eric Chanudet
  2023-01-11 15:53     ` Johan Hovold
  1 sibling, 1 reply; 9+ messages in thread
From: Eric Chanudet @ 2023-01-11 15:06 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Andrew Halaney, Brian Masney, linux-arm-msm,
	devicetree, linux-kernel

On Wed, Jan 11, 2023 at 09:23:30AM +0100, Johan Hovold wrote:
> Add the missing interrupt-controller include which is needed by the RTC
> node.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Eric Chanudet <echanude@redhat.com>

Nit: sa8450p-pmics -> sa8540p-pmics in the subject. It was mistyped in
the commit renaming the file unfortunately.

-- 
Eric Chanudet


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels
  2023-01-11  8:23 ` [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels Johan Hovold
  2023-01-11 10:53   ` Brian Masney
  2023-01-11 11:54   ` Konrad Dybcio
@ 2023-01-11 15:12   ` Eric Chanudet
  2 siblings, 0 replies; 9+ messages in thread
From: Eric Chanudet @ 2023-01-11 15:12 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Andrew Halaney, Brian Masney, linux-arm-msm,
	devicetree, linux-kernel

On Wed, Jan 11, 2023 at 09:23:31AM +0100, Johan Hovold wrote:
> The SA8540P PMICs are named PMM8540. Rename the devicetree source labels
> to reflect this.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Eric Chanudet <echanude@redhat.com>

-- 
Eric Chanudet


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include
  2023-01-11 15:06   ` Eric Chanudet
@ 2023-01-11 15:53     ` Johan Hovold
  0 siblings, 0 replies; 9+ messages in thread
From: Johan Hovold @ 2023-01-11 15:53 UTC (permalink / raw)
  To: Eric Chanudet
  Cc: Johan Hovold, Bjorn Andersson, Andy Gross, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski, Andrew Halaney, Brian Masney,
	linux-arm-msm, devicetree, linux-kernel

On Wed, Jan 11, 2023 at 10:06:19AM -0500, Eric Chanudet wrote:
> On Wed, Jan 11, 2023 at 09:23:30AM +0100, Johan Hovold wrote:
> > Add the missing interrupt-controller include which is needed by the RTC
> > node.
> > 
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> 
> Reviewed-by: Eric Chanudet <echanude@redhat.com>
> 
> Nit: sa8450p-pmics -> sa8540p-pmics in the subject. It was mistyped in
> the commit renaming the file unfortunately.

Ah, good catch. I'll resend with that fixed. Thanks.

Johan

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-01-11 15:54 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-11  8:23 [PATCH 0/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels Johan Hovold
2023-01-11  8:23 ` [PATCH 1/2] arm64: dts: qcom: sa8450p-pmics: add missing interrupt include Johan Hovold
2023-01-11 10:49   ` Brian Masney
2023-01-11 15:06   ` Eric Chanudet
2023-01-11 15:53     ` Johan Hovold
2023-01-11  8:23 ` [PATCH 2/2] arm64: dts: qcom: sa8450p-pmics: rename pmic labels Johan Hovold
2023-01-11 10:53   ` Brian Masney
2023-01-11 11:54   ` Konrad Dybcio
2023-01-11 15:12   ` Eric Chanudet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).