Re: [PATCH V3 03/10] dt-bindings: remoteproc: qcom,sc7180-mss-pil: Update memory-region

Rob Herring
2023-01-12T20:50:20Z

On Thu, Jan 12, 2023 at 2:17 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Jan 11, 2023 at 05:13:30PM +0530, Sibi Sankar wrote:
> > The dynamic memory region used for metadata authentication would still
> > be a part of the kernel mapping and any access to this region by the
> > application processor after assigning it to the remote Q6 will result
> > in a XPU violation. This is fixed by using a no-map carveout instead.
> > Update the bindings to reflect the addition of the new modem metadata
> > carveout on SC7180 SoC.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> > ---
> >
> > v3:
> > * remove double space [Krzysztof]
> > * Pickup R-b
> >
> > v2:
> > * Pad commit message to explain bindings break [Krzysztof]
> > * Split dt/bindings per SoC [Krzysztof]
> >
> > .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
> > index e4a7da8020f4..b1402bef0ebe 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
> > @@ -95,6 +95,7 @@ properties:
> > items:
> > - description: MBA reserved region
> > - description: modem reserved region
> > + - description: metadata reserved region
>
> Based on dtbs_check, looks like you need 'minItems: 2'.

NM, I see those are all sc7180.

Acked-by: Rob Herring <robh@kernel.org>