From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E489C54EBC for ; Wed, 11 Jan 2023 19:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234865AbjAKTUV (ORCPT ); Wed, 11 Jan 2023 14:20:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235046AbjAKTUO (ORCPT ); Wed, 11 Jan 2023 14:20:14 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 040BEEE15 for ; Wed, 11 Jan 2023 11:20:12 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id y18so13517207ljk.11 for ; Wed, 11 Jan 2023 11:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=17wjvx5lquWSTLgeARc3IuOmIGOx1V/FnBLjjyvZvM8=; b=UOV2Bo294HuUslwpdN+qr/rgem4f407kzGTIWhZQCJRuBdayFZerxKTc+VZ65iLi3b B+Qm+UnIdob1evdSQ8DdStdzVdKL0dkQgwMmrs7gjYj+QSseUv2CZRREnUgL9v2UxkF/ vxx3sgiiCA6MfMJI1GtRTKFxDJjy0IkHy/Js7M9mUMIYQ4McBhrCbI4pJRCmHDyB0oe1 ObRkex0lQ9x4O/oTwDA/JZdgvAPHHvi+BJu0wW96fM5GArWbo4soJ3J3lAEdv9VXYwH/ UHdehI8mfy1M1w78y9naj51AI0qm4vIwJrbP6FecFPqIIV1rmCL+XNCCFNuB0XK2O76D wA+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=17wjvx5lquWSTLgeARc3IuOmIGOx1V/FnBLjjyvZvM8=; b=hHPr1JznLGnbJcpDcxx5gBemIacADakW9ti+ifybUwPPt71MpfGfVs7n6xG7fwhoDs 9R1qdkg9+LfQ2BPNfLUjvIJSoK9SLk0P4gjGtVLNvhK2jqCJ5Gu+IRPAdMF0vaViLF/T 0fMLaxjzOW0L1OaXikZ5rjbChBPbs75YxOHflyCTnkeYqnJ0BKdge07VhoGIq3aEphiP 8c0ljf87r7OXKFt4AxQ6tkILPP8mHwBMO7IU+hRqPa6CeW+4HBToF+8LpvpjrlOq8ZUU lMuSUPR/xCkaRK/0EfqGRkedux9Du4SIHDO07KrDtE4gD4AebYG/UYkrE1uPkFphengr +Wow== X-Gm-Message-State: AFqh2krMeMQzQAqzPzPup+evbdx8T+qWavX1iBkezNOEcDtutVT9dZaa Pt+/Kh7tyuKqa0H4+ZsqnYclUQ== X-Google-Smtp-Source: AMrXdXvoKJGLXP6oHTTfsvcENYN8kBLk8k/zQkatI8aWBHs2hLaxeU/qSbuPldAH0j6bPmO+6YGX8g== X-Received: by 2002:a2e:9f17:0:b0:27f:db9e:3eb6 with SMTP id u23-20020a2e9f17000000b0027fdb9e3eb6mr11564053ljk.14.1673464812209; Wed, 11 Jan 2023 11:20:12 -0800 (PST) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id bj36-20020a2eaaa4000000b0027ff2fabcb5sm1807787ljb.104.2023.01.11.11.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:20:11 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 07/13] clk: qcom: cpu-8996: setup PLLs before registering clocks Date: Wed, 11 Jan 2023 22:19:58 +0300 Message-Id: <20230111192004.2509750-8-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230111192004.2509750-1-dmitry.baryshkov@linaro.org> References: <20230111192004.2509750-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Setup all PLLs before registering clocks in the common clock framework. This ensures that the clocks are not accessed before being setup in the known way and that the CCF is in sync with the actual HW programming. Signed-off-by: Dmitry Baryshkov --- drivers/clk/qcom/clk-cpu-8996.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c index ee7e18b37832..e390f4aadff1 100644 --- a/drivers/clk/qcom/clk-cpu-8996.c +++ b/drivers/clk/qcom/clk-cpu-8996.c @@ -430,6 +430,11 @@ static int qcom_cpu_clk_msm8996_register_clks(struct device *dev, { int i, ret; + clk_alpha_pll_configure(&pwrcl_pll, regmap, &hfpll_config); + clk_alpha_pll_configure(&perfcl_pll, regmap, &hfpll_config); + clk_alpha_pll_configure(&pwrcl_alt_pll, regmap, &altpll_config); + clk_alpha_pll_configure(&perfcl_alt_pll, regmap, &altpll_config); + for (i = 0; i < ARRAY_SIZE(cpu_msm8996_hw_clks); i++) { ret = devm_clk_hw_register(dev, cpu_msm8996_hw_clks[i]); if (ret) @@ -442,11 +447,6 @@ static int qcom_cpu_clk_msm8996_register_clks(struct device *dev, return ret; } - clk_alpha_pll_configure(&pwrcl_pll, regmap, &hfpll_config); - clk_alpha_pll_configure(&perfcl_pll, regmap, &hfpll_config); - clk_alpha_pll_configure(&pwrcl_alt_pll, regmap, &altpll_config); - clk_alpha_pll_configure(&perfcl_alt_pll, regmap, &altpll_config); - /* Enable alt PLLs */ clk_prepare_enable(pwrcl_alt_pll.clkr.hw.clk); clk_prepare_enable(perfcl_alt_pll.clkr.hw.clk); -- 2.30.2