From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Devarsh Thakkar <devarsht@ti.com>
Cc: andersson@kernel.org, devicetree@vger.kernel.org,
p.zabel@pengutronix.de, linux-remoteproc@vger.kernel.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, s-anna@ti.com,
hnagalla@ti.com, praneeth@ti.com, nm@ti.com, vigneshr@ti.com,
a-bhatia1@ti.com, j-luthra@ti.com
Subject: Re: [PATCH v6 1/3] remoteproc: k3-r5: Simplify single core config set
Date: Mon, 16 Jan 2023 09:43:01 -0700 [thread overview]
Message-ID: <20230116164301.GA3239767@p14s> (raw)
In-Reply-To: <20230116151906.549384-2-devarsht@ti.com>
On Mon, Jan 16, 2023 at 08:49:04PM +0530, Devarsh Thakkar wrote:
> The config PROC_BOOT_CFG_FLAG_R5_SINGLE_CORE
> is set only when cluster mode is set to
> CLUSTER_MODE_SINGLECPU and cluster mode
> is already configured before setting this config.
>
> So directly check for cluster mode instead of checking
> soc_data->single_cpu_mode first and then checking
> cluster mode.
>
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
> V6: No change
> ---
> drivers/remoteproc/ti_k3_r5_remoteproc.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> index 0481926c6975..036c9dc217f3 100644
> --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> @@ -875,15 +875,14 @@ static int k3_r5_rproc_configure(struct k3_r5_rproc *kproc)
> boot_vec = 0x0;
> if (core == core0) {
> clr_cfg = PROC_BOOT_CFG_FLAG_R5_TEINIT;
> - if (cluster->soc_data->single_cpu_mode) {
> - /*
> - * Single-CPU configuration bit can only be configured
> - * on Core0 and system firmware will NACK any requests
> - * with the bit configured, so program it only on
> - * permitted cores
> - */
> - if (cluster->mode == CLUSTER_MODE_SINGLECPU)
> - set_cfg = PROC_BOOT_CFG_FLAG_R5_SINGLE_CORE;
> + /*
> + * Single-CPU configuration bit can only be configured
> + * on Core0 and system firmware will NACK any requests
> + * with the bit configured, so program it only on
> + * permitted cores
> + */
> + if (cluster->mode == CLUSTER_MODE_SINGLECPU) {
> + set_cfg = PROC_BOOT_CFG_FLAG_R5_SINGLE_CORE;
This is exactly the kind of buggy situation I want to avoid by asking to use
soc_data->single_cpu_mode only in probe().
> } else {
> /*
> * LockStep configuration bit is Read-only on Split-mode
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-01-16 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 15:19 [PATCH v6 0/3] Add single core R5F IPC for AM62 SoC family Devarsh Thakkar
2023-01-16 15:19 ` [PATCH v6 1/3] remoteproc: k3-r5: Simplify single core config set Devarsh Thakkar
2023-01-16 16:43 ` Mathieu Poirier [this message]
2023-01-16 15:19 ` [PATCH v6 2/3] dt-bindings: remoteproc: ti: Add new compatible for AM62 SoC family Devarsh Thakkar
2023-01-16 19:06 ` Krzysztof Kozlowski
2023-01-17 5:24 ` Devarsh Thakkar
2023-01-17 14:49 ` Raghavendra, Vignesh
2023-01-16 15:19 ` [PATCH v6 3/3] remoteproc: k3-r5: Use separate compatible string for TI AM62x " Devarsh Thakkar
2023-01-16 16:45 ` Mathieu Poirier
2023-01-17 14:41 ` Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116164301.GA3239767@p14s \
--to=mathieu.poirier@linaro.org \
--cc=a-bhatia1@ti.com \
--cc=andersson@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).