devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Stephen Boyd <swboyd@chromium.org>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v6 02/11] dt-bindings: display/msm: add SoC-specific compats to qcom,mdp5.yaml
Date: Tue, 17 Jan 2023 12:05:46 -0600	[thread overview]
Message-ID: <20230117180546.GA3323490-robh@kernel.org> (raw)
In-Reply-To: <20230113083720.39224-3-dmitry.baryshkov@linaro.org>

On Fri, Jan 13, 2023 at 10:37:11AM +0200, Dmitry Baryshkov wrote:
> Add platform-specific compatible entries to the qcom,mdp5.yaml to allow
> distinguishing between various platforms.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../bindings/display/msm/qcom,mdp5.yaml         | 17 ++++++++++++++++-
>  .../bindings/display/msm/qcom,mdss.yaml         |  6 +++++-
>  2 files changed, 21 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> index 5e3cd7abf046..cb7bf48c3a58 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> @@ -16,7 +16,22 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: qcom,mdp5
> +    oneOf:
> +      - const: qcom,mdp5
> +        deprecated: true
> +      - items:
> +          - enum:
> +              - qcom,apq8084-mdp5
> +              - qcom,msm8916-mdp5
> +              - qcom,msm8917-mdp5
> +              - qcom,msm8953-mdp5
> +              - qcom,msm8974-mdp5
> +              - qcom,msm8976-mdp5
> +              - qcom,msm8994-mdp5
> +              - qcom,msm8996-mdp5
> +              - qcom,sdm630-mdp5
> +              - qcom,sdm660-mdp5
> +          - const: qcom,mdp5
>  
>    reg:
>      maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
> index ba0460268731..dcde34ffc8d0 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
> @@ -88,7 +88,11 @@ patternProperties:
>      type: object
>      properties:
>        compatible:
> -        const: qcom,mdp5
> +        oneOf:
> +          - const: qcom,mdp5
> +          - items:
> +              - {}
> +              - const: qcom,mdp5

Just 'contains' is sufficient for all this. The exact length and order 
will be checked by qcom,mdp5.yaml. With that,

Reviewed-by: Rob Herring <robh@kernel.org>

Rob

  reply	other threads:[~2023-01-17 18:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13  8:37 [PATCH v6 00/11] dt-bindings: display/msm: rework MDP5 and MDSS schema Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 01/11] dt-bindings: display/msm: convert MDP5 schema to YAML format Dmitry Baryshkov
2023-01-13 15:26   ` Rob Herring
2023-01-13 21:11     ` Rob Herring
2023-01-13 21:12       ` Dmitry Baryshkov
2023-01-13 21:11     ` Dmitry Baryshkov
2023-01-17 18:03   ` Rob Herring
2023-01-13  8:37 ` [PATCH v6 02/11] dt-bindings: display/msm: add SoC-specific compats to qcom,mdp5.yaml Dmitry Baryshkov
2023-01-17 18:05   ` Rob Herring [this message]
2023-01-13  8:37 ` [PATCH v6 03/11] dt-bindings: display/msm: add core clock to the mdss bindings Dmitry Baryshkov
2023-01-17 18:09   ` Rob Herring
2023-01-13  8:37 ` [PATCH v6 04/11] dt-bindings: display/msm: rename mdss nodes to display-subsystem Dmitry Baryshkov
2023-01-13 15:26   ` Rob Herring
2023-01-18  2:28     ` Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 05/11] dt-bindings: display/msm: rename mdp nodes to display-controller Dmitry Baryshkov
2023-01-17 18:11   ` Rob Herring
2023-01-13  8:37 ` [PATCH v6 06/11] ARM: dts: qcom-msm8974: add SoC specific compat string to mdp5 node Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 07/11] arm64: dts: qcom: add SoC specific compat strings to mdp5 nodes Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 08/11] arm64: dts: qcom: rename mdss nodes to display-subsystem Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 09/11] ARM: dts: qcom-msm8974: rename mdss node " Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 10/11] arm64: dts: qcom: rename mdp nodes to display-controller Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 11/11] ARM: " Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230117180546.GA3323490-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).