[PATCH 0/4] dt-bindings: display/msm: more dsi-controller fixes

[PATCH 0/4] dt-bindings: display/msm: more dsi-controller fixes

[Dmitry Baryshkov]

A small set of patches to go on top of Bryan's changes to fix a small
number of remaining issues.

Dependencies: [1]

[1] https://lore.kernel.org/linux-arm-msm/20230116225217.1056258-1-bryan.odonoghue@linaro.org/

Dmitry Baryshkov (4):
  dt-bindings: display/msm: dsi-controller-main: remove
    #address/#size-cells
  dt-bindings: display/msm: dsi-controller-main: account for apq8064
  dt-bindings: display/msm: dsi-controller-main: allow using fewer lanes
  dt-binbings: display/msm: dsi-controller-main: add missing supplies

 .../display/msm/dsi-controller-main.yaml      | 26 ++++++++++++-------
 1 file changed, 17 insertions(+), 9 deletions(-)

-- 
2.39.0

[PATCH 1/4] dt-bindings: display/msm: dsi-controller-main: remove #address/#size-cells

[Dmitry Baryshkov]

Stop mentioning #address-cells/#size-cells which are defined in
display/dsi-controller.yaml. Use unevaluatedProperties instead of
additionalProperties to allow skipping properties defined in other
schema files.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../bindings/display/msm/dsi-controller-main.yaml           | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 7c326f8927fc..b07bdddc1570 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -72,10 +72,6 @@ properties:
     deprecated: true
     const: dsi
 
-  "#address-cells": true
-
-  "#size-cells": true
-
   syscon-sfpb:
     description: A phandle to mmss_sfpb syscon node (only for DSIv2).
     $ref: "/schemas/types.yaml#/definitions/phandle"
@@ -357,7 +353,7 @@ allOf:
             - const: iface
             - const: bus
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.39.0

Re: [PATCH 1/4] dt-bindings: display/msm: dsi-controller-main: remove #address/#size-cells

[Rob Herring]

On Wed, 18 Jan 2023 05:24:29 +0200, Dmitry Baryshkov wrote:
> Stop mentioning #address-cells/#size-cells which are defined in
> display/dsi-controller.yaml. Use unevaluatedProperties instead of
> additionalProperties to allow skipping properties defined in other
> schema files.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../bindings/display/msm/dsi-controller-main.yaml           | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 2/4] dt-bindings: display/msm: dsi-controller-main: account for apq8064

[Dmitry Baryshkov]

APQ8064 requires listing four clocks in the assigned-clocks /
assigned-clock-parents properties. Account for that.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../bindings/display/msm/dsi-controller-main.yaml         | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index b07bdddc1570..357036470b1f 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -83,12 +83,16 @@ properties:
       2 DSI links.
 
   assigned-clocks:
-    maxItems: 2
+    minItems: 2
+    maxItems: 4
     description: |
       Parents of "byte" and "pixel" for the given platform.
+      For DSIv2 platforms this should contain "byte", "esc", "src" and
+      "pixel_src" clocks.
 
   assigned-clock-parents:
-    maxItems: 2
+    minItems: 2
+    maxItems: 4
     description: |
       The Byte clock and Pixel clock PLL outputs provided by a DSI PHY block.
 
-- 
2.39.0

Re: [PATCH 2/4] dt-bindings: display/msm: dsi-controller-main: account for apq8064

[Rob Herring]

On Wed, 18 Jan 2023 05:24:30 +0200, Dmitry Baryshkov wrote:
> APQ8064 requires listing four clocks in the assigned-clocks /
> assigned-clock-parents properties. Account for that.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../bindings/display/msm/dsi-controller-main.yaml         | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 3/4] dt-bindings: display/msm: dsi-controller-main: allow using fewer lanes

[Dmitry Baryshkov]

Some platforms might use less than full 4 lanes DSI interface. Allow
using any amount of lanes starting from 1 up to 4.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../devicetree/bindings/display/msm/dsi-controller-main.yaml  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 357036470b1f..dc318762ef7a 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -123,7 +123,7 @@ properties:
             properties:
               data-lanes:
                 maxItems: 4
-                minItems: 4
+                minItems: 1
                 items:
                   enum: [ 0, 1, 2, 3 ]
 
@@ -139,7 +139,7 @@ properties:
             properties:
               data-lanes:
                 maxItems: 4
-                minItems: 4
+                minItems: 1
                 items:
                   enum: [ 0, 1, 2, 3 ]
 
-- 
2.39.0

Re: [PATCH 3/4] dt-bindings: display/msm: dsi-controller-main: allow using fewer lanes

[Rob Herring]

On Wed, 18 Jan 2023 05:24:31 +0200, Dmitry Baryshkov wrote:
> Some platforms might use less than full 4 lanes DSI interface. Allow
> using any amount of lanes starting from 1 up to 4.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../devicetree/bindings/display/msm/dsi-controller-main.yaml  | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 4/4] dt-binbings: display/msm: dsi-controller-main: add missing supplies

[Dmitry Baryshkov]

Describe DSI supplies used on apq8064 (vdda-supply) and msm8994/96
(vcca-supply).

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../bindings/display/msm/dsi-controller-main.yaml         | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index dc318762ef7a..31d389249c1d 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -147,6 +147,14 @@ properties:
       - port@0
       - port@1
 
+  avdd-supply:
+    description:
+      Phandle to vdd regulator device node
+
+  vcca-supply:
+    description:
+      Phandle to vdd regulator device node
+
   vdd-supply:
     description:
       VDD regulator
-- 
2.39.0

Re: [PATCH 4/4] dt-binbings: display/msm: dsi-controller-main: add missing supplies

[Rob Herring]

On Wed, 18 Jan 2023 05:24:32 +0200, Dmitry Baryshkov wrote:
> Describe DSI supplies used on apq8064 (vdda-supply) and msm8994/96
> (vcca-supply).
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../bindings/display/msm/dsi-controller-main.yaml         | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 4/4] dt-binbings: display/msm: dsi-controller-main: add missing supplies

[Rob Herring]

On Wed, Jan 18, 2023 at 10:41 AM Rob Herring <robh@kernel.org> wrote:
>
>
> On Wed, 18 Jan 2023 05:24:32 +0200, Dmitry Baryshkov wrote:
> > Describe DSI supplies used on apq8064 (vdda-supply) and msm8994/96
> > (vcca-supply).
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  .../bindings/display/msm/dsi-controller-main.yaml         | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>

That is, with the typo in the subject fixed.

Re: [PATCH 0/4] dt-bindings: display/msm: more dsi-controller fixes

[Dmitry Baryshkov]

On Wed, 18 Jan 2023 05:24:28 +0200, Dmitry Baryshkov wrote:
> A small set of patches to go on top of Bryan's changes to fix a small
> number of remaining issues.
> 
> Dependencies: [1]
> 
> [1] https://lore.kernel.org/linux-arm-msm/20230116225217.1056258-1-bryan.odonoghue@linaro.org/
> 
> [...]

Applied, thanks!

[1/4] dt-bindings: display/msm: dsi-controller-main: remove #address/#size-cells
      https://gitlab.freedesktop.org/lumag/msm/-/commit/65e835945aab
[2/4] dt-bindings: display/msm: dsi-controller-main: account for apq8064
      https://gitlab.freedesktop.org/lumag/msm/-/commit/2f8e5f8b2ea4
[3/4] dt-bindings: display/msm: dsi-controller-main: allow using fewer lanes
      https://gitlab.freedesktop.org/lumag/msm/-/commit/2fd5293df88d
[4/4] dt-binbings: display/msm: dsi-controller-main: add missing supplies
      https://gitlab.freedesktop.org/lumag/msm/-/commit/05c578d51624

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>