From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org,
Matthias Kaehlcke <mka@chromium.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Johan Hovold <johan@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 7/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c4
Date: Wed, 18 Jan 2023 04:44:15 +0000 [thread overview]
Message-ID: <20230118044418.875-8-linux.amoon@gmail.com> (raw)
In-Reply-To: <20230118044418.875-1-linux.amoon@gmail.com>
On Odroid c4 previously use gpio-hog to reset the usb hub,
switch to used on-board usb hub reset to enable the usb hub
and enable power to hub.
USB hub is combination of USB 2.0 and USB 3.0 root hub so
use peer-hub node to link then.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v2: - fix the compatible string.
- Fix the hub node to use peer-hub to link the usb 2.0 and usb 3.0.
---
.../boot/dts/amlogic/meson-sm1-odroid-c4.dts | 36 ++++++++++++-------
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
index 8c30ce63686e..d04768a66bfe 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
@@ -26,20 +26,30 @@ led-blue {
sound {
model = "ODROID-C4";
};
-};
-&gpio {
- /*
- * WARNING: The USB Hub on the Odroid-C4 needs a reset signal
- * to be turned high in order to be detected by the USB Controller
- * This signal should be handled by a USB specific power sequence
- * in order to reset the Hub when USB bus is powered down.
- */
- hog-0 {
- gpio-hog;
- gpios = <GPIOH_4 GPIO_ACTIVE_HIGH>;
- output-high;
- line-name = "usb-hub-reset";
+ /* USB hub supports both USB 2.0 and USB 3.0 root hub */
+ usb-hub {
+ dr_mode = "host";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* 2.0 hub on port 1 */
+ hub_2_0: hub@1 {
+ compatible = "usb2109,2817";
+ reg = <1>;
+ peer-hub = <&hub_3_0>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&vcc_5v>;
+ };
+
+ /* 3.1 hub on port 4 */
+ hub_3_0: hub@2 {
+ compatible = "usb2109,817";
+ reg = <2>;
+ peer-hub = <&hub_2_0>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&vcc_5v>;
+ };
};
};
--
2.38.1
next prev parent reply other threads:[~2023-01-18 4:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230118044418.875-1-linux.amoon@gmail.com>
2023-01-18 4:44 ` [PATCH v2 1/9] dt-bindings: usb: Add device id for Genesys Logic hub controller Anand Moon
2023-01-18 8:17 ` Krzysztof Kozlowski
2023-01-18 4:44 ` [PATCH v2 2/9] ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub Anand Moon
2023-01-18 8:26 ` Neil Armstrong
2023-01-18 4:44 ` [PATCH v2 3/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2 Anand Moon
2023-01-18 8:27 ` Neil Armstrong
2023-01-18 4:44 ` [PATCH v2 5/9] vendor-prefixes: Add VIA Labs, Inc Anand Moon
2023-01-18 4:44 ` [PATCH v2 6/9] dt-bindings: usb: Add binding for Via lab VL817 hub controller Anand Moon
2023-01-18 8:19 ` Krzysztof Kozlowski
2023-01-18 11:55 ` Anand Moon
2023-01-18 4:44 ` Anand Moon [this message]
2023-01-18 8:29 ` [PATCH v2 7/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c4 Neil Armstrong
2023-01-18 11:55 ` Anand Moon
2023-01-18 13:24 ` neil.armstrong
2023-01-19 7:26 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118044418.875-8-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mka@chromium.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).