From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2880C38159 for ; Wed, 18 Jan 2023 05:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229489AbjARFJz (ORCPT ); Wed, 18 Jan 2023 00:09:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjARFJy (ORCPT ); Wed, 18 Jan 2023 00:09:54 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2E7511E93; Tue, 17 Jan 2023 21:09:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 555126157D; Wed, 18 Jan 2023 05:09:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F9D9C433D2; Wed, 18 Jan 2023 05:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674018591; bh=MVabULCSkNV421jVEsP7DjhYVzrIeoLvfIJ7eMv+LXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SIQvrDQUUMEyIMpQ6bG2KNlRIB7auqTJG76u8rZ5OD9Iw2YB2an3cPlqQ8ajBjcbM rNO/PKVvm5X5x9U6VCBhE8kKM7qA47Salap0cVDwsh52I6d50VWR3IVe7ut3Kc2ZsO AhBJD8PF7NyzWv4cZBA75TP1gH9XJshTcqetx7clLPFonm6Ag6ex/y+vsvliFJr8U0 8KKmcohtYsf97eLZDs4WrMrluN0UI1g7/CwryWZyZHH1sIjRqKbyOKXvBdljPMhlpw MdNan4VNUYZvASuI0gn3C3PTKwSPf5JzwJmycu5DGM1R3UnefFsZPXsH/gZLppfGHG qqDYARAx6eZtw== Date: Tue, 17 Jan 2023 23:09:48 -0600 From: Bjorn Andersson To: Bryan O'Donoghue Cc: agross@kernel.org, konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, benl@squareup.com, shawn.guo@linaro.org, fabien.parent@linaro.org, leo.yan@linaro.org, dmitry.baryshkov@linaro.org, Jun Nie , James Willcox , Joseph Gates , Max Chen , Zac Crosby , Vincent Knecht , Stephan Gerhold Subject: Re: [PATCH v3 5/8] arm64: dts: qcom: Add msm8939 SoC Message-ID: <20230118050948.bibhq26s6sgzullg@builder.lan> References: <20230117024846.1367794-1-bryan.odonoghue@linaro.org> <20230117024846.1367794-6-bryan.odonoghue@linaro.org> <20230117205800.cqexxwxmtupapy7e@builder.lan> <28e1df7a-6577-bf39-9739-d0a047b36f12@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28e1df7a-6577-bf39-9739-d0a047b36f12@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jan 17, 2023 at 10:48:37PM +0000, Bryan O'Donoghue wrote: > On 17/01/2023 20:58, Bjorn Andersson wrote: > > On Tue, Jan 17, 2023 at 02:48:43AM +0000, Bryan O'Donoghue wrote: > > > Add msm8939 a derivative SoC of msm8916. This SoC contains a number of key > > > differences to msm8916. > > > > > > - big.LITTLE Octa Core - quad 1.5GHz + quad 1.0GHz > > > - DRAM 1x800 LPDDR3 > > > - Camera 4+4 lane CSI > > > - Venus @ 1080p60 HEVC > > > - DSI x 2 > > > - Adreno A405 > > > - WiFi wcn3660/wcn3680b 802.11ac > > > > > > Co-developed-by: Shawn Guo > > > Signed-off-by: Shawn Guo > > > Co-developed-by: Jun Nie > > > Signed-off-by: Jun Nie > > > Co-developed-by: Benjamin Li > > > Signed-off-by: Benjamin Li > > > Co-developed-by: James Willcox > > > Signed-off-by: James Willcox > > > Co-developed-by: Leo Yan > > > Signed-off-by: Leo Yan > > > Co-developed-by: Joseph Gates > > > Signed-off-by: Joseph Gates > > > Co-developed-by: Max Chen > > > Signed-off-by: Max Chen > > > Co-developed-by: Zac Crosby > > > Signed-off-by: Zac Crosby > > > Co-developed-by: Vincent Knecht > > > Signed-off-by: Vincent Knecht > > > Co-developed-by: Stephan Gerhold > > > Signed-off-by: Stephan Gerhold > > > Signed-off-by: Bryan O'Donoghue > > > > Just to make sure when I get the question, you all co-developed this > > patch, right? > > A long list but a fair one. > > > > --- > > > arch/arm64/boot/dts/qcom/msm8939.dtsi | 2393 +++++++++++++++++++++++++ > > > 1 file changed, 2393 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/qcom/msm8939.dtsi > > > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi > > > new file mode 100644 > > > index 0000000000000..8cd358a9fe623 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi > > > @@ -0,0 +1,2393 @@ > > > +// SPDX-License-Identifier: GPL-2.0-only > > > +/* > > > + * Copyright (c) 2013-2015, The Linux Foundation. All rights reserved. > > > + * Copyright (c) 2020-2023, Linaro Limited > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +/ { > > > + interrupt-parent = <&intc>; > > > + > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > > Why do you use a default of 2? In particular since you reduce it to 1 in > > /soc... > > You asked that before, and I took a note of the answer but, then because I > was away from the main machine when I sent V2, I didn't have the log. > > Here's what I wrote down. > > " - address-cells/size-cells = 1 in /soc - Bjorn > I experimentally changed address/cell sizes to 2 > I'm finding that lk chokes " > > So AFAIR LK was unhappy about changing the top level address/size cells to > <1> <1> and converting the /soc address/size cells to <2> <2> caused a > number of breakages during boot. > > To be honest, this pattern is copied from the msm8916.dtsi original. > msm8953.dtsi has the same thing. msm8994 too, and 8998. > > If you think it needs changing, then I'll have to see what can be done with > soc@{} entries. > Sounds like problems not worth pursuing further. How about leaving a comment for the next person here about LK's expectation of these being 2? Thanks, Bjorn