From: Bjorn Andersson <andersson@kernel.org>
To: Yang Xiwen <forbidden405@foxmail.com>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jaime Breva <jbreva@nayarsystems.com>,
Nikita Travkin <nikita@trvn.ru>,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8916-zhihe: Add initial device tree for zhihe Wifi/LTE dongle UFI-001C and uf896
Date: Wed, 18 Jan 2023 18:24:09 -0600 [thread overview]
Message-ID: <20230119002409.2neba7eczftdxkc4@builder.lan> (raw)
In-Reply-To: <tencent_A7FA00B086BB0EFFDC1C64744FF85DAD2B06@qq.com>
On Tue, Jan 10, 2023 at 11:50:14PM +0800, Yang Xiwen wrote:
> This commit adds support for the ufi-001C and uf896 WiFi/LTE dongle made by
> unknown manufactures based on MSM8916.
> uf896 is another variant for the zhihe usb stick. The board design
> difers by using different gpios for the keys and leds.
>
> Note: The original firmware does not support 64-bit OS. It is necessary
> to flash 64-bit TZ firmware to boot arm64.
>
> Currently supported:
> - All CPU cores
> - Buttons
> - LEDs
> - Modem
> - SDHC
> - USB Device Mode
> - UART
>
> Co-developed-by: Jaime Breva <jbreva@nayarsystems.com>
> Signed-off-by: Jaime Breva <jbreva@nayarsystems.com>
> Co-developed-by: Nikita Travkin <nikita@trvn.ru>
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> Signed-off-by: Yang Xiwen <forbidden405@foxmail.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 2 +
> .../boot/dts/qcom/msm8916-zhihe-uf896.dts | 41 +++
> .../boot/dts/qcom/msm8916-zhihe-ufi001c.dts | 39 +++
> arch/arm64/boot/dts/qcom/msm8916-zhihe.dtsi | 246 ++++++++++++++++++
> 4 files changed, 328 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8916-zhihe-uf896.dts
> create mode 100644 arch/arm64/boot/dts/qcom/msm8916-zhihe-ufi001c.dts
> create mode 100644 arch/arm64/boot/dts/qcom/msm8916-zhihe.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index b42362c7be1bf..7abc7bb19c9fc 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -21,6 +21,8 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-e7.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-grandmax.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8916-zhihe-uf896.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8916-zhihe-ufi001c.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-zhihe-uf896.dts b/arch/arm64/boot/dts/qcom/msm8916-zhihe-uf896.dts
> new file mode 100644
> index 0000000000000..2ddceb1d8b210
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8916-zhihe-uf896.dts
> @@ -0,0 +1,41 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +/dts-v1/;
> +
> +#include "msm8916-zhihe.dtsi"
> +
> +/ {
> + model = "uf896 4G Modem Stick";
> + compatible = "zhihe,uf896", "qcom,msm8916";
> +};
> +
> +&button_restart {
Please sort nodes alphabetically.
> + gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>;
> +};
> +
> +&led_r {
> + gpios = <&msmgpio 82 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&led_g {
> + gpios = <&msmgpio 83 GPIO_ACTIVE_HIGH>;
> + function = LED_FUNCTION_WLAN;
> +};
> +
> +&led_b {
> + gpios = <&msmgpio 81 GPIO_ACTIVE_HIGH>;
> + function = LED_FUNCTION_WAN;
> +};
> +
> +&button_default {
> + pins = "gpio35";
> + bias-pull-up;
> +};
> +
> +&gpio_leds_default {
> + pins = "gpio81", "gpio82", "gpio83";
> +};
> +
> +&sim_ctrl_default {
> + pins = "gpio1", "gpio2";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-zhihe-ufi001c.dts b/arch/arm64/boot/dts/qcom/msm8916-zhihe-ufi001c.dts
> new file mode 100644
> index 0000000000000..715874a2b8650
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8916-zhihe-ufi001c.dts
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +/dts-v1/;
> +
> +#include "msm8916-zhihe.dtsi"
> +
> +/ {
> + model = "ufi-001c/ufi-001b 4G Modem Stick";
> + compatible = "zhihe,ufi001c", "qcom,msm8916";
> +};
> +
> +&button_restart {
> + gpios = <&msmgpio 37 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&led_r {
> + gpios = <&msmgpio 22 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&led_g {
> + gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&led_b {
> + gpios = <&msmgpio 20 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&button_default {
Same here, please sort alphabetically.
Regards,
Bjorn
prev parent reply other threads:[~2023-01-19 0:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230110155014.31664-1-forbidden405@foxmail.com>
2023-01-10 15:50 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add zhihe Yang Xiwen
2023-01-10 16:32 ` Krzysztof Kozlowski
2023-01-10 15:50 ` [PATCH 2/3] dt-bindings: qcom: Ducument bindings for new msm8916-zhihe-uf896 and msm8916-zhihe-ufi001c Yang Xiwen
2023-01-10 16:31 ` Krzysztof Kozlowski
2023-01-10 15:50 ` [PATCH 3/3] arm64: dts: qcom: msm8916-zhihe: Add initial device tree for zhihe Wifi/LTE dongle UFI-001C and uf896 Yang Xiwen
2023-01-10 16:35 ` Krzysztof Kozlowski
2023-01-10 18:17 ` forbidden405
2023-01-10 18:29 ` Krzysztof Kozlowski
2023-01-10 18:58 ` forbidden405
2023-01-10 19:25 ` Krzysztof Kozlowski
2023-01-10 19:56 ` forbidden405
2023-01-11 9:06 ` Krzysztof Kozlowski
2023-01-11 10:21 ` forbidden405
2023-01-19 0:24 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119002409.2neba7eczftdxkc4@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@foxmail.com \
--cc=jbreva@nayarsystems.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).