From: Bjorn Andersson <andersson@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>, Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: qcom,a53pll: drop operating-points-v2
Date: Wed, 18 Jan 2023 21:11:36 -0600 [thread overview]
Message-ID: <20230119031136.27vson2awemt3nkt@builder.lan> (raw)
In-Reply-To: <705c78c1d0da18089419b064832d5fed.sboyd@kernel.org>
On Wed, Jan 18, 2023 at 11:11:00AM -0800, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2023-01-15 06:35:23)
> > On 13/01/2023 21:28, Stephen Boyd wrote:
> > > Quoting Krzysztof Kozlowski (2023-01-13 06:58:59)
> > >> The CPU PLL clock node does not use OPP tables (neither driver).
> > >
> > > What device is qcom_a53pll_get_freq_tbl() operating on?
> >
> > On its own, internal table. While of course driver could be converted to
> > operating-points-v2, no one did it within last 5 years, so why it should
> > happen now?
> >
>
> The property was added mid 2021 by Shawn[1], that's not 5 years ago. I
> guess there were plans to add an OPP table that never happened[2]? Is
> Shawn still working on this? If not, we should revert the OPP code out
> of the driver.
>
@Bryan, what do you think about this?
Thanks,
Bjorn
> [1] https://lore.kernel.org/all/20210704024032.11559-4-shawn.guo@linaro.org/
> [2] https://lore.kernel.org/all/20210709021334.GB11342@dragon/
next prev parent reply other threads:[~2023-01-19 3:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 14:58 [PATCH] dt-bindings: clock: qcom,a53pll: drop operating-points-v2 Krzysztof Kozlowski
2023-01-13 20:28 ` Stephen Boyd
2023-01-15 14:35 ` Krzysztof Kozlowski
2023-01-18 19:11 ` Stephen Boyd
2023-01-19 3:11 ` Bjorn Andersson [this message]
2023-01-19 10:55 ` Bryan O'Donoghue
2023-01-19 11:04 ` Krzysztof Kozlowski
2023-01-19 11:33 ` Bryan O'Donoghue
2023-01-17 18:34 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119031136.27vson2awemt3nkt@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).