From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69AB6C004D4 for ; Thu, 19 Jan 2023 10:45:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230009AbjASKpw (ORCPT ); Thu, 19 Jan 2023 05:45:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230194AbjASKpe (ORCPT ); Thu, 19 Jan 2023 05:45:34 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB64430EE for ; Thu, 19 Jan 2023 02:45:32 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pISQF-0005tP-1N; Thu, 19 Jan 2023 11:45:31 +0100 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pISQE-0000Po-Em; Thu, 19 Jan 2023 11:45:30 +0100 Date: Thu, 19 Jan 2023 11:45:30 +0100 From: Marco Felsch To: Ahmad Fatoum Cc: Johannes Schneider , devicetree@vger.kernel.org, Richard Zhu , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Li Yang , Rob Herring , NXP Linux Team , Krzysztof Kozlowski , Fabio Estevam , Shengjiu Wang , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 1/3] arm64: dts: imx8mm-evk: move PMIC configuration Message-ID: <20230119104530.u65425ee7oc5nn2h@pengutronix.de> References: <20230110152316.1149940-1-johannes.schneider@leica-geosystems.com> <20230110152316.1149940-2-johannes.schneider@leica-geosystems.com> <20230119095112.mpo56lf4nd3udtht@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Ahamd, On 23-01-19, Ahmad Fatoum wrote: > Hello Marco, > > On 19.01.23 10:51, Marco Felsch wrote: > > Do we really need to move it into another dtsi file? I would either > > suggest to move the pmic description into the .dts file since it is not > > common anymore. This way we can avoid the imx8mm-evk-rohm-pmic.dtsi. > > The PMIC DTSIs were my suggestion. The Rohm PMIC is still common between > old LPDDR4 EVK and DDR4 EVK. Ah okay but still it is one indirection more while reading the dts file. Therefore I would prefer to put it into the dts file or keep it in the dtsi file and delete the node within the imx8mm-evkb.dts file. But this is just my opinion. Regards, Marco > > Cheers, > Ahmad > > > > > Regards, > > Marco > > > >> / { > >> model = "FSL i.MX8MM DDR4 EVK with CYW43455 WIFI/BT board"; > >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk-rohm-pmic.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk-rohm-pmic.dtsi > >> new file mode 100644 > >> index 000000000000..0b056996a27b > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk-rohm-pmic.dtsi > >> @@ -0,0 +1,118 @@ > >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> +/* > >> + * Copyright 2020 NXP > >> + */ > >> + > >> +&i2c1 { > >> + pmic@4b { > >> + compatible = "rohm,bd71847"; > >> + reg = <0x4b>; > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_pmic>; > >> + interrupt-parent = <&gpio1>; > >> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > >> + rohm,reset-snvs-powered; > >> + > >> + #clock-cells = <0>; > >> + clocks = <&osc_32k 0>; > >> + clock-output-names = "clk-32k-out"; > >> + > >> + regulators { > >> + buck1_reg: BUCK1 { > >> + regulator-name = "buck1"; > >> + regulator-min-microvolt = <700000>; > >> + regulator-max-microvolt = <1300000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + regulator-ramp-delay = <1250>; > >> + }; > >> + > >> + buck2_reg: BUCK2 { > >> + regulator-name = "buck2"; > >> + regulator-min-microvolt = <700000>; > >> + regulator-max-microvolt = <1300000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + regulator-ramp-delay = <1250>; > >> + rohm,dvs-run-voltage = <1000000>; > >> + rohm,dvs-idle-voltage = <900000>; > >> + }; > >> + > >> + buck3_reg: BUCK3 { > >> + // BUCK5 in datasheet > >> + regulator-name = "buck3"; > >> + regulator-min-microvolt = <700000>; > >> + regulator-max-microvolt = <1350000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + buck4_reg: BUCK4 { > >> + // BUCK6 in datasheet > >> + regulator-name = "buck4"; > >> + regulator-min-microvolt = <3000000>; > >> + regulator-max-microvolt = <3300000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + buck5_reg: BUCK5 { > >> + // BUCK7 in datasheet > >> + regulator-name = "buck5"; > >> + regulator-min-microvolt = <1605000>; > >> + regulator-max-microvolt = <1995000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + buck6_reg: BUCK6 { > >> + // BUCK8 in datasheet > >> + regulator-name = "buck6"; > >> + regulator-min-microvolt = <800000>; > >> + regulator-max-microvolt = <1400000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + ldo1_reg: LDO1 { > >> + regulator-name = "ldo1"; > >> + regulator-min-microvolt = <1600000>; > >> + regulator-max-microvolt = <3300000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + ldo2_reg: LDO2 { > >> + regulator-name = "ldo2"; > >> + regulator-min-microvolt = <800000>; > >> + regulator-max-microvolt = <900000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + ldo3_reg: LDO3 { > >> + regulator-name = "ldo3"; > >> + regulator-min-microvolt = <1800000>; > >> + regulator-max-microvolt = <3300000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + ldo4_reg: LDO4 { > >> + regulator-name = "ldo4"; > >> + regulator-min-microvolt = <900000>; > >> + regulator-max-microvolt = <1800000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + ldo6_reg: LDO6 { > >> + regulator-name = "ldo6"; > >> + regulator-min-microvolt = <900000>; > >> + regulator-max-microvolt = <1800000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + }; > >> + }; > >> +}; > >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > >> index a2b24d4d4e3e..d2b6d7de7e53 100644 > >> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > >> @@ -7,6 +7,7 @@ > >> > >> #include > >> #include "imx8mm-evk.dtsi" > >> +#include "imx8mm-evk-rohm-pmic.dtsi" > >> > >> / { > >> model = "FSL i.MX8MM EVK board"; > >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > >> index 7d6317d95b13..21d0614af44c 100644 > >> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > >> @@ -182,118 +182,6 @@ &i2c1 { > >> pinctrl-names = "default"; > >> pinctrl-0 = <&pinctrl_i2c1>; > >> status = "okay"; > >> - > >> - pmic@4b { > >> - compatible = "rohm,bd71847"; > >> - reg = <0x4b>; > >> - pinctrl-names = "default"; > >> - pinctrl-0 = <&pinctrl_pmic>; > >> - interrupt-parent = <&gpio1>; > >> - interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > >> - rohm,reset-snvs-powered; > >> - > >> - #clock-cells = <0>; > >> - clocks = <&osc_32k 0>; > >> - clock-output-names = "clk-32k-out"; > >> - > >> - regulators { > >> - buck1_reg: BUCK1 { > >> - regulator-name = "buck1"; > >> - regulator-min-microvolt = <700000>; > >> - regulator-max-microvolt = <1300000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - regulator-ramp-delay = <1250>; > >> - }; > >> - > >> - buck2_reg: BUCK2 { > >> - regulator-name = "buck2"; > >> - regulator-min-microvolt = <700000>; > >> - regulator-max-microvolt = <1300000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - regulator-ramp-delay = <1250>; > >> - rohm,dvs-run-voltage = <1000000>; > >> - rohm,dvs-idle-voltage = <900000>; > >> - }; > >> - > >> - buck3_reg: BUCK3 { > >> - // BUCK5 in datasheet > >> - regulator-name = "buck3"; > >> - regulator-min-microvolt = <700000>; > >> - regulator-max-microvolt = <1350000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - }; > >> - > >> - buck4_reg: BUCK4 { > >> - // BUCK6 in datasheet > >> - regulator-name = "buck4"; > >> - regulator-min-microvolt = <3000000>; > >> - regulator-max-microvolt = <3300000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - }; > >> - > >> - buck5_reg: BUCK5 { > >> - // BUCK7 in datasheet > >> - regulator-name = "buck5"; > >> - regulator-min-microvolt = <1605000>; > >> - regulator-max-microvolt = <1995000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - }; > >> - > >> - buck6_reg: BUCK6 { > >> - // BUCK8 in datasheet > >> - regulator-name = "buck6"; > >> - regulator-min-microvolt = <800000>; > >> - regulator-max-microvolt = <1400000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - }; > >> - > >> - ldo1_reg: LDO1 { > >> - regulator-name = "ldo1"; > >> - regulator-min-microvolt = <1600000>; > >> - regulator-max-microvolt = <3300000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - }; > >> - > >> - ldo2_reg: LDO2 { > >> - regulator-name = "ldo2"; > >> - regulator-min-microvolt = <800000>; > >> - regulator-max-microvolt = <900000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - }; > >> - > >> - ldo3_reg: LDO3 { > >> - regulator-name = "ldo3"; > >> - regulator-min-microvolt = <1800000>; > >> - regulator-max-microvolt = <3300000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - }; > >> - > >> - ldo4_reg: LDO4 { > >> - regulator-name = "ldo4"; > >> - regulator-min-microvolt = <900000>; > >> - regulator-max-microvolt = <1800000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - }; > >> - > >> - ldo6_reg: LDO6 { > >> - regulator-name = "ldo6"; > >> - regulator-min-microvolt = <900000>; > >> - regulator-max-microvolt = <1800000>; > >> - regulator-boot-on; > >> - regulator-always-on; > >> - }; > >> - }; > >> - }; > >> }; > >> > >> &i2c2 { > >> -- > >> 2.25.1 > >> > >> > >> > > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > >