From: Rob Herring <robh@kernel.org>
To: Astrid Rost <astrid.rost@axis.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
kernel@axis.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 4/4] ASoC: dt-bindings: simple-card: create jack for aux_devs
Date: Thu, 19 Jan 2023 10:17:57 -0600 [thread overview]
Message-ID: <20230119161757.GA1969308-robh@kernel.org> (raw)
In-Reply-To: <20230118125226.333214-5-astrid.rost@axis.com>
On Wed, Jan 18, 2023 at 01:52:26PM +0100, Astrid Rost wrote:
> Add simple-card,aux-jack-types:
> Array of snd_jack_type to create jack-input-event for jack devices in
> aux-devs. If the setting is 0, the supported type of the device is used.
> A device which has the functions set_jack and get_jack_supported_type
> counts as jack device.
>
> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
> ---
> .../bindings/sound/simple-card.yaml | 35 +++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
> index ed19899bc94b..2635b1c04fc9 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
> @@ -199,6 +199,13 @@ properties:
> maxItems: 1
> simple-audio-card,mic-det-gpio:
> maxItems: 1
> + simple-audio-card,aux-jack-types:
Drop 'simple-audio-card,'. That way we can reuse this for the
not-simple cases.
I'm pretty sure we have some vendor specific properties for this
already. Use those for inspiration and to create something which could
replace them.
> + $ref: "/schemas/types.yaml#/definitions/uint32-array"
> + description: |
> + Array of snd_jack_type to create jack-input-event for jack
> + devices in aux-devs. If the setting is 0, the supported
> + type of the device is used. A device which has the functions
> + set_jack and get_jack_supported_type counts as jack device.
Sounds like Linux details. How does BSD use this property?
Rob
prev parent reply other threads:[~2023-01-19 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230118125226.333214-1-astrid.rost@axis.com>
2023-01-18 12:52 ` [PATCH v1 4/4] ASoC: dt-bindings: simple-card: create jack for aux_devs Astrid Rost
2023-01-19 11:18 ` Krzysztof Kozlowski
2023-01-19 16:00 ` Astrid Rost
2023-01-19 16:17 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119161757.GA1969308-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=astrid.rost@axis.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).