* [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern
@ 2023-01-20 2:06 Rob Herring
2023-01-20 4:29 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2023-01-20 2:06 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
Just 'mpp' is a bit ambiguous for a pattern. It allows any prefix or
suffix. I couldn't find any actual users, so update the pattern to match
the example.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
index 72cce38bc1ce..891a7385d7cb 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
@@ -74,7 +74,7 @@ patternProperties:
oneOf:
- $ref: "#/$defs/qcom-pmic-mpp-state"
- patternProperties:
- "mpp":
+ "-mpp$":
$ref: "#/$defs/qcom-pmic-mpp-state"
additionalProperties: false
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern
2023-01-20 2:06 [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern Rob Herring
@ 2023-01-20 4:29 ` Bjorn Andersson
2023-01-20 6:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2023-01-20 4:29 UTC (permalink / raw)
To: Rob Herring
Cc: Andy Gross, Konrad Dybcio, Linus Walleij, Krzysztof Kozlowski,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Thu, Jan 19, 2023 at 08:06:00PM -0600, Rob Herring wrote:
> Just 'mpp' is a bit ambiguous for a pattern. It allows any prefix or
> suffix. I couldn't find any actual users, so update the pattern to match
> the example.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> index 72cce38bc1ce..891a7385d7cb 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> @@ -74,7 +74,7 @@ patternProperties:
> oneOf:
> - $ref: "#/$defs/qcom-pmic-mpp-state"
> - patternProperties:
> - "mpp":
> + "-mpp$":
How about aligning it with the other Qualcomm pinctrl bindings and make
it "-pins$" instead?
If my grep is correct we have one "mpp5" and two "-pins$" currently in
the sources, so this should be beneficial as well.
Regards,
Bjorn
> $ref: "#/$defs/qcom-pmic-mpp-state"
> additionalProperties: false
>
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern
2023-01-20 4:29 ` Bjorn Andersson
@ 2023-01-20 6:38 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 6:38 UTC (permalink / raw)
To: Bjorn Andersson, Rob Herring
Cc: Andy Gross, Konrad Dybcio, Linus Walleij, Krzysztof Kozlowski,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 20/01/2023 05:29, Bjorn Andersson wrote:
> On Thu, Jan 19, 2023 at 08:06:00PM -0600, Rob Herring wrote:
>> Just 'mpp' is a bit ambiguous for a pattern. It allows any prefix or
>> suffix. I couldn't find any actual users, so update the pattern to match
>> the example.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
>> index 72cce38bc1ce..891a7385d7cb 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
>> @@ -74,7 +74,7 @@ patternProperties:
>> oneOf:
>> - $ref: "#/$defs/qcom-pmic-mpp-state"
>> - patternProperties:
>> - "mpp":
>> + "-mpp$":
>
> How about aligning it with the other Qualcomm pinctrl bindings and make
> it "-pins$" instead?
>
> If my grep is correct we have one "mpp5" and two "-pins$" currently in
> the sources, so this should be beneficial as well.
Let's align it with other Qualcomm pinctrl bindings, so:
"-pins$":
I can also fix the DTS to match it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-20 6:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-20 2:06 [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern Rob Herring
2023-01-20 4:29 ` Bjorn Andersson
2023-01-20 6:38 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).