devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shravan kumar <shravan.chippa@microchip.com>
To: <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
	<mchehab@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<shawnguo@kernel.org>, <s.hauer@pengutronix.de>
Cc: <festevam@gmail.com>, <kernel@pengutronix.de>,
	<linux-imx@nxp.com>, <linux-media@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<shravan.chippa@microchip.com>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Subject: [PATCH RESEND v10 2/5] media: i2c: imx334: add missing reset values for mode 3840x2160_regs[]
Date: Sat, 21 Jan 2023 09:07:10 +0530	[thread overview]
Message-ID: <20230121033713.3535351-3-shravan.chippa@microchip.com> (raw)
In-Reply-To: <20230121033713.3535351-1-shravan.chippa@microchip.com>

From: Shravan Chippa <shravan.chippa@microchip.com>

There are some missing reset reg_mode values for the 3840x2160@60
resolution. The camera sensor still works in 3840x2160@60 resolution mode
because of the register reset values. This is an issue when we change the
modes dynamically. As an example, when we change the mode from 1920x1080@30
 resolution to 3840x2160@60 resoultion then the mode values will be written
to the registers from the array mode_3840x2160_regs[] which gives the wrong
output which is incorrect resolution.

So add the missing reset values to the mode_3840x2160_regs[].

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
---
 drivers/media/i2c/imx334.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index ebacba3059b3..40ece08f20f5 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -166,6 +166,7 @@ static const struct imx334_reg mode_3840x2160_regs[] = {
 	{0x3288, 0x21},
 	{0x328a, 0x02},
 	{0x302c, 0x3c},
+	{0x302d, 0x00},
 	{0x302e, 0x00},
 	{0x302f, 0x0f},
 	{0x3076, 0x70},
@@ -240,7 +241,26 @@ static const struct imx334_reg mode_3840x2160_regs[] = {
 	{0x3794, 0x7a},
 	{0x3796, 0xa1},
 	{0x3e04, 0x0e},
+	{0x319e, 0x00},
 	{0x3a00, 0x01},
+	{0x3a18, 0xbf},
+	{0x3a19, 0x00},
+	{0x3a1a, 0x67},
+	{0x3a1b, 0x00},
+	{0x3a1c, 0x6f},
+	{0x3a1d, 0x00},
+	{0x3a1e, 0xd7},
+	{0x3a1f, 0x01},
+	{0x3a20, 0x6f},
+	{0x3a21, 0x00},
+	{0x3a22, 0xcf},
+	{0x3a23, 0x00},
+	{0x3a24, 0x6f},
+	{0x3a25, 0x00},
+	{0x3a26, 0xb7},
+	{0x3a27, 0x00},
+	{0x3a28, 0x5f},
+	{0x3a29, 0x00},
 };
 
 /* Supported sensor mode configurations */
-- 
2.34.1


  parent reply	other threads:[~2023-01-21  3:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-21  3:37 [PATCH RESEND v10 0/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2023-01-21  3:37 ` [PATCH RESEND v10 1/5] media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range shravan kumar
2023-01-21  3:37 ` shravan kumar [this message]
2023-01-21  3:37 ` [PATCH RESEND v10 3/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2023-01-21  3:37 ` [PATCH RESEND v10 4/5] dt-bindings: media: i2c: imx334 add new link_freq shravan kumar
2023-01-22 14:07   ` Krzysztof Kozlowski
2023-01-23  6:28     ` Shravan.Chippa
2023-01-23  8:00       ` Krzysztof Kozlowski
2023-01-23 22:48         ` Rob Herring
2023-01-21  3:37 ` [PATCH RESEND v10 5/5] media: i2c: imx334: update pixel and link frequency shravan kumar
2023-01-23 23:02   ` Sakari Ailus
2023-01-24  5:34     ` Shravan.Chippa
2023-01-25  9:42       ` Sakari Ailus
2023-01-27  0:10         ` Shravan.Chippa
2023-02-06  4:43           ` Shravan.Chippa
2023-02-22  9:16             ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230121033713.3535351-3-shravan.chippa@microchip.com \
    --to=shravan.chippa@microchip.com \
    --cc=daniele.alessandrelli@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=paul.j.murphy@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).