From: Jonathan Cameron <jic23@kernel.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 0/2] arm64: dts: qcom: Use labels with generic node names for ADC channels
Date: Sat, 21 Jan 2023 16:59:54 +0000 [thread overview]
Message-ID: <20230121165954.5806ee29@jic23-huawei> (raw)
In-Reply-To: <20230119221757.wltdog4owclidejl@SoMainline.org>
On Thu, 19 Jan 2023 23:17:57 +0100
Marijn Suijten <marijn.suijten@somainline.org> wrote:
> +cc linux-iio@vger.kernel.org
>
> Apologies, I blindly copied Jonathans request [1] to send this to
> iio@vger.kernel.org, without checking for the common linux- prefix.
Oops from me!
:)
Jonathan
>
> [1]: https://lore.kernel.org/linux-arm-msm/20221211141526.463f43e6@jic23-huawei/
>
> On 2023-01-19 22:26:30, Marijn Suijten wrote:
> > As discussed in [1] it is more convenient to use a generic adc-chan node
> > name for ADC channels while storing a friendly - board-specific instead
> > of PMIC-specific - name in the label, if/when desired to overwrite the
> > channel description already contained (but previously unused) in the
> > driver [2].
> >
> > Replace the .* name pattern with the adc-chan literal, but leave the
> > label property optional for bindings to choose to fall back a channel
> > label hardcoded in the driver [2] instead.
> >
> > [1]: https://lore.kernel.org/linux-arm-msm/20221106193018.270106-1-marijn.suijten@somainline.org/T/#u
> > [2]: https://lore.kernel.org/linux-arm-msm/20230116220909.196926-4-marijn.suijten@somainline.org/
> >
> > Changes since v1:
> > - Require adc-chan name in dt-bindings;
> > - Replace more node names with adc-chan and a descriptive label, that
> > were found by running dtbs_check on adjusted bindings;
> > - sm8250-mtp.dts: Fix accidental adc-chan2 node name with pa_therm
> > label, which should have been adc-chan with pa_therm2 label.
> >
> > v1: https://lore.kernel.org/linux-arm-msm/20221209215308.1781047-1-marijn.suijten@somainline.org/
> >
> > Marijn Suijten (2):
> > dt-bindings: iio: adc: Require generic adc-chan name for channel nodes
> > arm64: dts: qcom: Use labels with generic node names for ADC channels
> >
> > .../bindings/iio/adc/qcom,spmi-vadc.yaml | 16 ++++----
> > arch/arm64/boot/dts/qcom/pm6125.dtsi | 18 ++++++---
> > arch/arm64/boot/dts/qcom/pm660.dtsi | 33 ++++++++++------
> > arch/arm64/boot/dts/qcom/pm8150.dtsi | 6 +--
> > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 8 ++--
> > arch/arm64/boot/dts/qcom/pm8150l.dtsi | 6 +--
> > arch/arm64/boot/dts/qcom/pm8950.dtsi | 39 ++++++++++++-------
> > arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi | 6 +--
> > arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi | 6 +--
> > arch/arm64/boot/dts/qcom/pmp8074.dtsi | 27 ++++++++-----
> > arch/arm64/boot/dts/qcom/pms405.dtsi | 21 ++++++----
> > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 15 ++++---
> > .../dts/qcom/sc7180-trogdor-coachz-r1.dts | 4 +-
> > .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 3 +-
> > .../dts/qcom/sc7180-trogdor-homestar.dtsi | 3 +-
> > .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 2 +-
> > .../dts/qcom/sc7180-trogdor-pompom-r1.dts | 2 +-
> > .../dts/qcom/sc7180-trogdor-pompom-r2.dts | 2 +-
> > .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 3 +-
> > .../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 3 +-
> > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 +-
> > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +-
> > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 2 +-
> > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 +-
> > .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 39 ++++++++++++-------
> > .../qcom/sm6125-sony-xperia-seine-pdx201.dts | 15 ++++---
> > arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 21 ++++++----
> > 27 files changed, 196 insertions(+), 113 deletions(-)
> >
> > --
> > 2.39.1
> >
next prev parent reply other threads:[~2023-01-21 16:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 21:26 [PATCH v2 0/2] arm64: dts: qcom: Use labels with generic node names for ADC channels Marijn Suijten
2023-01-19 21:26 ` [PATCH v2 1/2] dt-bindings: iio: adc: Require generic adc-chan name for channel nodes Marijn Suijten
2023-01-20 1:42 ` Rob Herring
2023-01-21 17:08 ` Jonathan Cameron
2023-01-22 23:37 ` Marijn Suijten
2023-01-23 10:36 ` Jonathan Cameron
2023-01-19 21:26 ` [PATCH v2 2/2] arm64: dts: qcom: Use labels with generic node names for ADC channels Marijn Suijten
2023-01-19 21:29 ` Konrad Dybcio
2023-01-19 22:17 ` [PATCH v2 0/2] " Marijn Suijten
2023-01-21 16:59 ` Jonathan Cameron [this message]
2023-01-22 23:31 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230121165954.5806ee29@jic23-huawei \
--to=jic23@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=iio@vger.kernel.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).