From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org,
Matthias Kaehlcke <mka@chromium.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Johan Hovold <johan@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2
Date: Sat, 21 Jan 2023 17:56:31 +0000 [thread overview]
Message-ID: <20230121175639.12818-4-linux.amoon@gmail.com> (raw)
In-Reply-To: <20230121175639.12818-1-linux.amoon@gmail.com>
On Odroid c2 previously use gpio-hog to reset the usb hub,
switch to used on-board usb hub reset to enable the usb hub
and enable power to hub.
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v3 - Add rev by Neil.
droped dr_mode
v2 - drop the vendor name from compatible string.
- move the hub node to USB controller node.
- drop the usb_otg_pwr since it only liked to OTG port
and link p5v0 to the vdd-supply.
---
.../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 25 ++++++++-----------
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 201596247fd9..70b10934a811 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -250,21 +250,6 @@ eth_phy0: ethernet-phy@0 {
};
};
-&gpio_ao {
- /*
- * WARNING: The USB Hub on the Odroid-C2 needs a reset signal
- * to be turned high in order to be detected by the USB Controller
- * This signal should be handled by a USB specific power sequence
- * in order to reset the Hub when USB bus is powered down.
- */
- hog-0 {
- gpio-hog;
- gpios = <GPIOAO_4 GPIO_ACTIVE_HIGH>;
- output-high;
- line-name = "usb-hub-reset";
- };
-};
-
&hdmi_tx {
status = "okay";
pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;
@@ -414,5 +399,15 @@ &usb0 {
};
&usb1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "okay";
+
+ hub@1 {
+ /* Genesys Logic GL852G USB 2.0 hub */
+ compatible = "usb5e3,610";
+ reg = <1>;
+ vdd-supply = <&p5v0>;
+ reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
+ };
};
--
2.38.1
next prev parent reply other threads:[~2023-01-21 17:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230121175639.12818-1-linux.amoon@gmail.com>
2023-01-21 17:56 ` [PATCH v3 1/9] dt-bindings: usb: Add device id for Genesys Logic hub controller Anand Moon
2023-01-25 14:34 ` Greg Kroah-Hartman
2023-01-25 14:41 ` Anand Moon
2023-01-21 17:56 ` [PATCH v3 2/9] ARM: dts: amlogic: Used onboard usb hub reset on odroid c1 Anand Moon
2023-01-21 17:56 ` Anand Moon [this message]
2023-08-02 21:06 ` [PATCH v3 3/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2 Ben Wolsieffer
2023-08-05 21:30 ` Krzysztof Kozlowski
2023-08-06 0:05 ` Ben Wolsieffer
2023-08-06 4:03 ` Anand Moon
2023-01-21 17:56 ` [PATCH v3 5/9] vendor-prefixes: Add VIA Labs, Inc Anand Moon
2023-01-21 18:51 ` Krzysztof Kozlowski
2023-01-22 7:04 ` Anand Moon
2023-01-22 9:36 ` Krzysztof Kozlowski
2023-01-22 16:38 ` Anand Moon
2023-01-21 17:56 ` [PATCH v3 6/9] dt-bindings: usb: Add Via lab VL817 hub Anand Moon
2023-01-21 18:52 ` Krzysztof Kozlowski
2023-01-21 17:56 ` [PATCH v3 7/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c4 Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230121175639.12818-4-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mka@chromium.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).