* [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees
@ 2023-01-21 20:16 Markuss Broks
2023-01-21 20:16 ` [PATCH 1/2] arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy Markuss Broks
2023-01-21 20:16 ` [PATCH 2/2] arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller Markuss Broks
0 siblings, 2 replies; 6+ messages in thread
From: Markuss Broks @ 2023-01-21 20:16 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Mark Brown, Arnd Bergmann, Olof Johansson, soc,
Rob Herring, Krzysztof Kozlowski, Alim Akhtar, linux-arm-kernel,
devicetree, linux-samsung-soc
Use the proper compatibles for the DSI host controller and MIPI
video phy, as the current ones are not compatible with the hardware.
While this fixes the kernel panic while trying to use DSI, I was still
unsuccessful to consistently produce image that isn't noise on S6E3FA2
panel of Samsung Galaxy S5. It seems to only work sometimes.
Cc: Mark Brown <broonie@kernel.org>
v1 -> v2:
- squash patch 1 and patch 3, making it one patch for adding the label and
changing the compatible
- use better subject prefixes
Markuss Broks (2):
arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller
arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
arch/arm/boot/dts/exynos5800.dtsi | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
--
2.39.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
2023-01-21 20:16 [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees Markuss Broks
@ 2023-01-21 20:16 ` Markuss Broks
2023-01-21 20:16 ` [PATCH 2/2] arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller Markuss Broks
1 sibling, 0 replies; 6+ messages in thread
From: Markuss Broks @ 2023-01-21 20:16 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Arnd Bergmann, Olof Johansson, soc, Rob Herring,
Krzysztof Kozlowski, Alim Akhtar, linux-arm-kernel, devicetree,
linux-samsung-soc
For some reason, the driver adding support for Exynos5420 MIPI phy
back in 2016 wasn't used on Exynos5420, which caused a kernel panic.
Add the proper compatible for it.
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 9f2523a873d9..62263eb91b3c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -592,7 +592,7 @@ dp_phy: dp-video-phy {
};
mipi_phy: mipi-video-phy {
- compatible = "samsung,s5pv210-mipi-video-phy";
+ compatible = "samsung,exynos5420-mipi-video-phy";
syscon = <&pmu_system_controller>;
#phy-cells = <1>;
};
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller
2023-01-21 20:16 [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees Markuss Broks
2023-01-21 20:16 ` [PATCH 1/2] arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy Markuss Broks
@ 2023-01-21 20:16 ` Markuss Broks
1 sibling, 0 replies; 6+ messages in thread
From: Markuss Broks @ 2023-01-21 20:16 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Arnd Bergmann, Olof Johansson, soc, Rob Herring,
Krzysztof Kozlowski, Alim Akhtar, linux-arm-kernel, devicetree,
linux-samsung-soc
The driver adding support for Exynos5422/Exynos5800 DSI controller was
merged in 2016, yet it wasn't actually used. Add a proper compatible
for it.
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
arch/arm/boot/dts/exynos5800.dtsi | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 62263eb91b3c..b612468515eb 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -597,7 +597,7 @@ mipi_phy: mipi-video-phy {
#phy-cells = <1>;
};
- dsi@14500000 {
+ dsi: dsi@14500000 {
compatible = "samsung,exynos5410-mipi-dsi";
reg = <0x14500000 0x10000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/arch/arm/boot/dts/exynos5800.dtsi b/arch/arm/boot/dts/exynos5800.dtsi
index 526729dad53f..8328ddb3b02f 100644
--- a/arch/arm/boot/dts/exynos5800.dtsi
+++ b/arch/arm/boot/dts/exynos5800.dtsi
@@ -148,6 +148,10 @@ opp-200000000 {
};
};
+&dsi {
+ compatible = "samsung,exynos5422-mipi-dsi";
+};
+
&mfc {
compatible = "samsung,mfc-v8";
};
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees
@ 2023-01-21 20:18 Markuss Broks
2023-01-23 15:37 ` Krzysztof Kozlowski
2023-01-24 10:36 ` Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Markuss Broks @ 2023-01-21 20:18 UTC (permalink / raw)
To: linux-kernel
Cc: Markuss Broks, Mark Brown, Arnd Bergmann, Olof Johansson, soc,
Rob Herring, Krzysztof Kozlowski, Alim Akhtar, linux-arm-kernel,
devicetree, linux-samsung-soc
Use the proper compatibles for the DSI host controller and MIPI
video phy, as the current ones are not compatible with the hardware.
While this fixes the kernel panic while trying to use DSI, I was still
unsuccessful to consistently produce image that isn't noise on S6E3FA2
panel of Samsung Galaxy S5. It seems to only work sometimes.
Cc: Mark Brown <broonie@kernel.org>
v1 -> v2:
- squash patch 1 and patch 3, making it one patch for adding the label and
changing the compatible
- use better subject prefixes
Markuss Broks (2):
arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller
arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
arch/arm/boot/dts/exynos5800.dtsi | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
--
2.39.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees
2023-01-21 20:18 [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees Markuss Broks
@ 2023-01-23 15:37 ` Krzysztof Kozlowski
2023-01-24 10:36 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 15:37 UTC (permalink / raw)
To: linux-kernel, Markuss Broks
Cc: Krzysztof Kozlowski, Alim Akhtar, Rob Herring, linux-samsung-soc,
linux-arm-kernel, Mark Brown, Arnd Bergmann, Krzysztof Kozlowski,
Olof Johansson, soc, devicetree
On Sat, 21 Jan 2023 22:18:41 +0200, Markuss Broks wrote:
> Use the proper compatibles for the DSI host controller and MIPI
> video phy, as the current ones are not compatible with the hardware.
>
> While this fixes the kernel panic while trying to use DSI, I was still
> unsuccessful to consistently produce image that isn't noise on S6E3FA2
> panel of Samsung Galaxy S5. It seems to only work sometimes.
>
> [...]
Applied, thanks!
[1/2] arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
https://git.kernel.org/krzk/linux/c/bf5de14225625627a35d1acb6739068fc126326f
[2/2] arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller
https://git.kernel.org/krzk/linux/c/234b8dac096d74e330ed1266956c756efddf3676
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees
2023-01-21 20:18 [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees Markuss Broks
2023-01-23 15:37 ` Krzysztof Kozlowski
@ 2023-01-24 10:36 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-24 10:36 UTC (permalink / raw)
To: linux-kernel, Markuss Broks
Cc: Krzysztof Kozlowski, Rob Herring, soc, Arnd Bergmann,
linux-arm-kernel, Olof Johansson, linux-samsung-soc, Alim Akhtar,
Krzysztof Kozlowski, Mark Brown, devicetree
On Sat, 21 Jan 2023 22:18:41 +0200, Markuss Broks wrote:
> Use the proper compatibles for the DSI host controller and MIPI
> video phy, as the current ones are not compatible with the hardware.
>
> While this fixes the kernel panic while trying to use DSI, I was still
> unsuccessful to consistently produce image that isn't noise on S6E3FA2
> panel of Samsung Galaxy S5. It seems to only work sometimes.
>
> [...]
Applied, thanks!
[1/2] arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
https://git.kernel.org/krzk/linux/c/bf5de14225625627a35d1acb6739068fc126326f
[2/2] arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller
https://git.kernel.org/krzk/linux/c/234b8dac096d74e330ed1266956c756efddf3676
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-24 10:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-21 20:16 [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees Markuss Broks
2023-01-21 20:16 ` [PATCH 1/2] arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy Markuss Broks
2023-01-21 20:16 ` [PATCH 2/2] arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller Markuss Broks
-- strict thread matches above, loose matches on Subject: below --
2023-01-21 20:18 [PATCH v2 0/3] Correct inaccuracies in Exynos5420 and Exynos5800 device trees Markuss Broks
2023-01-23 15:37 ` Krzysztof Kozlowski
2023-01-24 10:36 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).