From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4801C27C76 for ; Sun, 22 Jan 2023 11:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbjAVL2h (ORCPT ); Sun, 22 Jan 2023 06:28:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbjAVL2g (ORCPT ); Sun, 22 Jan 2023 06:28:36 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C358C3C02; Sun, 22 Jan 2023 03:28:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5867460BB8; Sun, 22 Jan 2023 11:28:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75696C433D2; Sun, 22 Jan 2023 11:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674386914; bh=q6F2xIhN+qHchyQBQzub9cBH2zydmSfawU0Cdk7OAoA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a6v/Ui/C2cXuciXbNwmrRFDNWZOfmxb0ufCf+AxEcH9t+3zb18Ky+JUcTcye0UDlE Ta89jN7Eb3A7WwsUSazi4Hadfq0VP0M4l+A+Hl9/7gKpJLANg0JZL4P8ZOPbIJd4Ud CtnU3tceZb7Djzhp6ym3R+FpWxiH0xVWaigOP0qO1l8uwN6HoNzTSu7b0VpD7r5OLl HIzSN4TOx981ruoOHQMvpfN9SHJdOVMvfFFEOCwzAU8tm5j0f9yaGzdCHlJMMkTA/Z S44TfyfFHPQORnEeB6eHVfNA3b6EJNxRm3x/MLDW/vbi26gBaQcGtIZ8nR8vv1x5dG QKtiuPu9+KPHQ== Received: by pali.im (Postfix) id E506D93D; Sun, 22 Jan 2023 12:28:31 +0100 (CET) Date: Sun, 22 Jan 2023 12:28:31 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Gregory Clement Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Message-ID: <20230122112831.n4zqresjeo2otsdt@pali> References: <20220713125644.3117-1-pali@kernel.org> <20220930233802.wjfzk3xkphm565uz@pali> <20221009120639.hds2nhdynwdzjizr@pali> <20221101224457.vyraefpfyphvnv4p@pali> <20221128182127.jq6255cwa44lnmxv@pali> <20221216182115.whsahozgifg5c2k7@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221216182115.whsahozgifg5c2k7@pali> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org PING? On Friday 16 December 2022 19:21:15 Pali Rohár wrote: > PING? > > On Monday 28 November 2022 19:21:27 Pali Rohár wrote: > > PING? > > > > On Tuesday 01 November 2022 23:44:57 Pali Rohár wrote: > > > PING? > > > > > > On Sunday 09 October 2022 14:06:39 Pali Rohár wrote: > > > > PING > > > > > > > > On Saturday 01 October 2022 01:38:02 Pali Rohár wrote: > > > > > Gregory: ping > > > > > > > > > > On Wednesday 13 July 2022 14:56:44 Pali Rohár wrote: > > > > > > All Armada 3720 boards have Armada 3720 processor which is of Armada 3700 > > > > > > family and do not have Armada 3710 processor. So none of them should have > > > > > > compatible string for Armada 3710 processor. > > > > > > > > > > > > Fix compatible string for all these boards by removing wrong processor > > > > > > string "marvell,armada3710" and adding family string "marvell,armada3700" > > > > > > as the last one. (Note that this is same way how are defined Armada 3710 > > > > > > DTS files). > > > > > > > > > > > > Signed-off-by: Pali Rohár > > > > > > --- > > > > > > arch/arm64/boot/dts/marvell/armada-3720-db.dts | 2 +- > > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts | 2 +- > > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 2 +- > > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts | 2 +- > > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts | 2 +- > > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 2 +- > > > > > > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- > > > > > > arch/arm64/boot/dts/marvell/armada-372x.dtsi | 2 +- > > > > > > 8 files changed, 8 insertions(+), 8 deletions(-) > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts > > > > > > index bd4e61d5448e..0cfb38492021 100644 > > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts > > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts > > > > > > @@ -18,7 +18,7 @@ > > > > > > > > > > > > / { > > > > > > model = "Marvell Armada 3720 Development Board DB-88F3720-DDR3"; > > > > > > - compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710"; > > > > > > + compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700"; > > > > > > > > > > > > chosen { > > > > > > stdout-path = "serial0:115200n8"; > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts > > > > > > index 5c4d8f379704..6715a19c1483 100644 > > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts > > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts > > > > > > @@ -18,7 +18,7 @@ > > > > > > / { > > > > > > model = "Globalscale Marvell ESPRESSOBin Board (eMMC)"; > > > > > > compatible = "globalscale,espressobin-emmc", "globalscale,espressobin", > > > > > > - "marvell,armada3720", "marvell,armada3710"; > > > > > > + "marvell,armada3720", "marvell,armada3700"; > > > > > > }; > > > > > > > > > > > > &sdhci0 { > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > > > > > index 070725b81be5..447760b69850 100644 > > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > > > > > @@ -13,7 +13,7 @@ > > > > > > / { > > > > > > model = "Globalscale Marvell ESPRESSOBin Ultra Board"; > > > > > > compatible = "globalscale,espressobin-ultra", "marvell,armada3720", > > > > > > - "marvell,armada3710"; > > > > > > + "marvell,armada3700"; > > > > > > > > > > > > aliases { > > > > > > /* ethernet1 is WAN port */ > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > > > > > > index 75401eab4d42..2a8aa3901a9f 100644 > > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > > > > > > @@ -19,7 +19,7 @@ > > > > > > model = "Globalscale Marvell ESPRESSOBin Board V7 (eMMC)"; > > > > > > compatible = "globalscale,espressobin-v7-emmc", "globalscale,espressobin-v7", > > > > > > "globalscale,espressobin", "marvell,armada3720", > > > > > > - "marvell,armada3710"; > > > > > > + "marvell,armada3700"; > > > > > > > > > > > > aliases { > > > > > > /* ethernet1 is wan port */ > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > > > > > > index 48a7f50fb427..b03af87611a9 100644 > > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > > > > > > @@ -18,7 +18,7 @@ > > > > > > / { > > > > > > model = "Globalscale Marvell ESPRESSOBin Board V7"; > > > > > > compatible = "globalscale,espressobin-v7", "globalscale,espressobin", > > > > > > - "marvell,armada3720", "marvell,armada3710"; > > > > > > + "marvell,armada3720", "marvell,armada3700"; > > > > > > > > > > > > aliases { > > > > > > /* ethernet1 is wan port */ > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > > > > > > index 1542d836c090..c5a834b33b77 100644 > > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > > > > > > @@ -16,5 +16,5 @@ > > > > > > > > > > > > / { > > > > > > model = "Globalscale Marvell ESPRESSOBin Board"; > > > > > > - compatible = "globalscale,espressobin", "marvell,armada3720", "marvell,armada3710"; > > > > > > + compatible = "globalscale,espressobin", "marvell,armada3720", "marvell,armada3700"; > > > > > > }; > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > > > > > > index caf9c8529fca..5840ed129309 100644 > > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > > > > > > @@ -14,7 +14,7 @@ > > > > > > / { > > > > > > model = "CZ.NIC Turris Mox Board"; > > > > > > compatible = "cznic,turris-mox", "marvell,armada3720", > > > > > > - "marvell,armada3710"; > > > > > > + "marvell,armada3700"; > > > > > > > > > > > > aliases { > > > > > > spi0 = &spi0; > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-372x.dtsi b/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > > > > > index 5ce55bdbb995..02ae1e153288 100644 > > > > > > --- a/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > > > > > @@ -13,7 +13,7 @@ > > > > > > > > > > > > / { > > > > > > model = "Marvell Armada 3720 SoC"; > > > > > > - compatible = "marvell,armada3720", "marvell,armada3710"; > > > > > > + compatible = "marvell,armada3720", "marvell,armada3700"; > > > > > > > > > > > > cpus { > > > > > > cpu1: cpu@1 { > > > > > > -- > > > > > > 2.20.1 > > > > > >