From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Lucas Stankus" <lucas.p.stankus@gmail.com>,
"Puranjay Mohan" <puranjay12@gmail.com>,
"Dmitry Rokosov" <ddrokosov@sberdevices.ru>,
"Alexandru Tachici" <alexandru.tachici@analog.com>,
"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
"Renato Lui Geh" <renatogeh@gmail.com>,
"Eugen Hristev" <eugen.hristev@microchip.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Andreas Klinger" <ak@it-klinger.de>,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Kent Gustavsson" <kent@minoris.se>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Oleksij Rempel" <linux@rempel-privat.de>,
kernel@pengutronix.de, "Nuno Sá" <nuno.sa@analog.com>,
"Nishant Malpani" <nish.malpani25@gmail.com>,
"Rui Miguel Silva" <rmfrfs@gmail.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
"Jean-Baptiste Maneyrol" <jmaneyrol@invensense.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Stefan Popa" <stefan.popa@analog.com>,
"Robert Yang" <decatf@gmail.com>,
"Sean Nyekjaer" <sean@geanix.com>,
"Artur Rojek" <contact@artur-rojek.eu>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Philippe Reynes" <tremyfr@yahoo.fr>,
"Alexandru Lazar" <alazar@startmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Caleb Connolly" <caleb.connolly@linaro.org>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
"Stefan Agner" <stefan@agner.ch>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
"Harald Geyer" <harald@ccbib.org>,
"Eugene Zaikonnikov" <ez@norophonic.com>,
"Phil Reid" <preid@electromag.com.au>,
"Matt Ranostay" <matt.ranostay@konsulko.com>,
"Stephen Boyd" <swboyd@chromium.org>,
"Sankar Velliangiri" <navin@linumiz.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples
Date: Sun, 22 Jan 2023 17:01:05 +0000 [thread overview]
Message-ID: <20230122170105.6a1a9766@jic23-huawei> (raw)
In-Reply-To: <45b9b378-6619-c47a-b5ea-6b6b7edca785@linaro.org>
On Sat, 21 Jan 2023 19:31:23 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 21/01/2023 18:17, Jonathan Cameron wrote:
> > On Wed, 18 Jan 2023 19:44:11 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >
> >> Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in
> >> examples.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >
> >> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> >> index 6c5ad426a016..12f75ddc4a70 100644
> >> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> >> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> >> @@ -42,7 +42,7 @@ examples:
> >> #address-cells = <1>;
> >> #size-cells = <0>;
> >>
> >> - heart_mon@0 {
> >> + heart-rate@0 {
> >
> > These are both heart-rate and pulse oximeters so measure more than just
> > the rate (oxygen saturation in the blood). Reality is they actually
> > measure light absorption over time, but you can calculate an estimate
> > of both rate and oxygen saturation from that.
> >
> > I don't really mind simplifying that to heart-rate, but wanted to
> > call this out for possible discussion.
>
> They could be heart-mon. The fix is mostly around the underscore. I
> don't have any arguments for changing it to heart-rate, thus we can go
> with whatever you prefer.
I'm fine with either and as we have a patch with heart-rate that wins
currently. I'll just let this sit for a little longer than
normal to see if we get any other responses!
Thanks,
Jonathan
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-01-22 16:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 18:44 [PATCH 1/5] dt-bindings: iio: drop unneeded quotes Krzysztof Kozlowski
2023-01-18 18:44 ` [PATCH 2/5] dt-bindings: iio: minor whitespace cleanups Krzysztof Kozlowski
2023-01-23 20:21 ` Rob Herring
2023-01-18 18:44 ` [PATCH 3/5] dt-bindings: iio: correct node names in examples Krzysztof Kozlowski
2023-01-21 17:17 ` Jonathan Cameron
2023-01-21 18:31 ` Krzysztof Kozlowski
2023-01-22 17:01 ` Jonathan Cameron [this message]
2023-01-23 20:33 ` Rob Herring
2023-01-24 7:40 ` Krzysztof Kozlowski
2023-01-23 20:36 ` Rob Herring
2023-01-18 18:44 ` [PATCH 4/5] dt-bindings: iio: use lowercase hex " Krzysztof Kozlowski
2023-01-23 20:35 ` Rob Herring
2023-01-18 18:44 ` [PATCH 5/5] dt-bindings: iio: cleanup examples - indentation Krzysztof Kozlowski
2023-01-20 19:03 ` Alexandru Lazar
2023-01-23 20:47 ` Rob Herring
2023-01-19 20:14 ` [PATCH 1/5] dt-bindings: iio: drop unneeded quotes Dmitry Rokosov
2023-01-20 8:31 ` Claudiu.Beznea
2023-01-20 22:05 ` Puranjay Mohan
2023-01-23 20:21 ` Rob Herring
2023-01-24 1:54 ` Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230122170105.6a1a9766@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=ak@it-klinger.de \
--cc=alazar@startmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alexandru.tachici@analog.com \
--cc=alim.akhtar@samsung.com \
--cc=bleung@chromium.org \
--cc=caleb.connolly@linaro.org \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@microchip.com \
--cc=contact@artur-rojek.eu \
--cc=daniel.baluta@nxp.com \
--cc=ddrokosov@sberdevices.ru \
--cc=decatf@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dragos.bogdan@analog.com \
--cc=eugen.hristev@microchip.com \
--cc=ez@norophonic.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=groeck@chromium.org \
--cc=harald@ccbib.org \
--cc=jmaneyrol@invensense.com \
--cc=kent@minoris.se \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@rempel-privat.de \
--cc=lorenzo@kernel.org \
--cc=lucas.p.stankus@gmail.com \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcus.folkesson@gmail.com \
--cc=matt.ranostay@konsulko.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=navin@linumiz.com \
--cc=nicolas.ferre@microchip.com \
--cc=nish.malpani25@gmail.com \
--cc=nuno.sa@analog.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=preid@electromag.com.au \
--cc=puranjay12@gmail.com \
--cc=renatogeh@gmail.com \
--cc=rmfrfs@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@geanix.com \
--cc=stefan.popa@analog.com \
--cc=stefan@agner.ch \
--cc=swboyd@chromium.org \
--cc=tremyfr@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).