From: Rob Herring <robh@kernel.org>
To: Astrid Rost <astrid.rost@axis.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dylan Reid <dgreid@chromium.org>,
kernel@axis.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/4] ASoC: dt-bindings: ti,ts3a227e.yaml: add jack-type
Date: Mon, 23 Jan 2023 16:09:28 -0600 [thread overview]
Message-ID: <20230123220928.GA2720169-robh@kernel.org> (raw)
In-Reply-To: <20230120102555.1523394-5-astrid.rost@axis.com>
On Fri, Jan 20, 2023 at 11:25:54AM +0100, Astrid Rost wrote:
> Add jack-type: Bitmap value of snd_jack_type to allow combining
> card drivers to create a jack for it.
>
> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
> ---
> Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> index 785930658029..1d949b805f98 100644
> --- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> @@ -27,6 +27,14 @@ properties:
> interrupts:
> maxItems: 1
>
> + jack-type:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Bitmap value of snd_jack_type to allow combining
snd_jack_type? Is that a Linux thing? Bindings are independent of Linux.
> + card drivers to create a jack for it. Supported is
> + 1 SND_JACK_HEADPHONE
> + 2 SND_JACK_MICROPHONE
> + default: 3
I'm pretty sure jack properties are more complicated than just headphone
and/or microphone. There's buttons which are detected in differing ways.
Rob
next prev parent reply other threads:[~2023-01-23 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230120102555.1523394-1-astrid.rost@axis.com>
2023-01-20 10:25 ` [PATCH v2 4/4] ASoC: dt-bindings: ti,ts3a227e.yaml: add jack-type Astrid Rost
2023-01-22 14:16 ` Krzysztof Kozlowski
2023-01-23 8:39 ` Astrid Rost
2023-01-23 9:05 ` Krzysztof Kozlowski
2023-01-23 9:19 ` Astrid Rost
2023-01-23 22:09 ` Rob Herring [this message]
2023-01-24 8:46 ` Astrid Rost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123220928.GA2720169-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=astrid.rost@axis.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).