* [PATCH 2/3] dt-bindings: power: fsl,imx-gpc: correct compatibles
2023-01-20 7:17 [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible Krzysztof Kozlowski
@ 2023-01-20 7:17 ` Krzysztof Kozlowski
2023-01-23 21:58 ` Rob Herring
2023-01-20 7:17 ` [PATCH 3/3] dt-bindings: power: fsl,imx-gpc: document interrupt-controller Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 7:17 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Philipp Zabel, devicetree, linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
fsl,imx6qp-gpc, fsl,imx6sl-gpc and fsl,imx6sx-gpc use generic fallback
fsl,imx6q-gpc in the DTS, even though these are different devices. The
common part (thus the fallback) is a interrupt controller routing back
to GIC.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
index 85658da3672f..a5ea45b8c04e 100644
--- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
+++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
@@ -26,11 +26,11 @@ properties:
oneOf:
- enum:
- fsl,imx6q-gpc
- - fsl,imx6qp-gpc
- - fsl,imx6sl-gpc
- - fsl,imx6sx-gpc
- items:
- enum:
+ - fsl,imx6qp-gpc
+ - fsl,imx6sl-gpc
+ - fsl,imx6sx-gpc
- fsl,imx6ul-gpc
- const: fsl,imx6q-gpc
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/3] dt-bindings: power: fsl,imx-gpc: correct compatibles
2023-01-20 7:17 ` [PATCH 2/3] dt-bindings: power: fsl,imx-gpc: correct compatibles Krzysztof Kozlowski
@ 2023-01-23 21:58 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-01-23 21:58 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, NXP Linux Team, Fabio Estevam, Philipp Zabel,
devicetree, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, linux-kernel, linux-arm-kernel
On Fri, 20 Jan 2023 08:17:16 +0100, Krzysztof Kozlowski wrote:
> fsl,imx6qp-gpc, fsl,imx6sl-gpc and fsl,imx6sx-gpc use generic fallback
> fsl,imx6q-gpc in the DTS, even though these are different devices. The
> common part (thus the fallback) is a interrupt controller routing back
> to GIC.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] dt-bindings: power: fsl,imx-gpc: document interrupt-controller
2023-01-20 7:17 [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible Krzysztof Kozlowski
2023-01-20 7:17 ` [PATCH 2/3] dt-bindings: power: fsl,imx-gpc: correct compatibles Krzysztof Kozlowski
@ 2023-01-20 7:17 ` Krzysztof Kozlowski
2023-01-23 21:58 ` Rob Herring
2023-01-23 21:56 ` [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible Rob Herring
2023-01-26 8:42 ` Shawn Guo
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 7:17 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Philipp Zabel, devicetree, linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
The fsl,imx6q-gpc is used as interrupt controller (routing back to GIC):
imx6sl-evk.dtb: gpc@20dc000: '#interrupt-cells', 'interrupt-controller' do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
index a5ea45b8c04e..c21a66422d4f 100644
--- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
+++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
@@ -40,6 +40,10 @@ properties:
interrupts:
maxItems: 1
+ interrupt-controller: true
+ '#interrupt-cells':
+ const: 3
+
clocks:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] dt-bindings: power: fsl,imx-gpc: document interrupt-controller
2023-01-20 7:17 ` [PATCH 3/3] dt-bindings: power: fsl,imx-gpc: document interrupt-controller Krzysztof Kozlowski
@ 2023-01-23 21:58 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-01-23 21:58 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Pengutronix Kernel Team, Shawn Guo, linux-kernel, Rob Herring,
NXP Linux Team, Sascha Hauer, Fabio Estevam, devicetree,
Philipp Zabel, linux-arm-kernel, Krzysztof Kozlowski
On Fri, 20 Jan 2023 08:17:17 +0100, Krzysztof Kozlowski wrote:
> The fsl,imx6q-gpc is used as interrupt controller (routing back to GIC):
>
> imx6sl-evk.dtb: gpc@20dc000: '#interrupt-cells', 'interrupt-controller' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible
2023-01-20 7:17 [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible Krzysztof Kozlowski
2023-01-20 7:17 ` [PATCH 2/3] dt-bindings: power: fsl,imx-gpc: correct compatibles Krzysztof Kozlowski
2023-01-20 7:17 ` [PATCH 3/3] dt-bindings: power: fsl,imx-gpc: document interrupt-controller Krzysztof Kozlowski
@ 2023-01-23 21:56 ` Rob Herring
2023-01-26 8:42 ` Shawn Guo
3 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-01-23 21:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Fabio Estevam, Krzysztof Kozlowski, devicetree,
Sascha Hauer, linux-arm-kernel, NXP Linux Team, linux-kernel,
Pengutronix Kernel Team, Shawn Guo, Philipp Zabel
On Fri, 20 Jan 2023 08:17:15 +0100, Krzysztof Kozlowski wrote:
> Document existing fsl,imx6ul-gpc compatible used with fsl,imx6q-gpc
> fallback:
>
> imx6sl-evk.dtb: gpc@20dc000: compatible: ['fsl,imx6sl-gpc', 'fsl,imx6q-gpc'] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/power/fsl,imx-gpc.yaml | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible
2023-01-20 7:17 [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-01-23 21:56 ` [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible Rob Herring
@ 2023-01-26 8:42 ` Shawn Guo
3 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2023-01-26 8:42 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Philipp Zabel, devicetree, linux-arm-kernel, linux-kernel
On Fri, Jan 20, 2023 at 08:17:15AM +0100, Krzysztof Kozlowski wrote:
> Document existing fsl,imx6ul-gpc compatible used with fsl,imx6q-gpc
> fallback:
>
> imx6sl-evk.dtb: gpc@20dc000: compatible: ['fsl,imx6sl-gpc', 'fsl,imx6q-gpc'] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied all, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread