From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Markuss Broks <markuss.broks@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Zhigang Shi <Zhigang.Shi@liteon.com>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Paul Gazzillo <paul@pgazz.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] iio: light: Add support for AMS TCS3490 light sensor
Date: Thu, 26 Jan 2023 17:41:19 +0000 [thread overview]
Message-ID: <20230126174119.000056da@Huawei.com> (raw)
In-Reply-To: <a782a0d9-c47e-4328-774f-6bef78161d81@gmail.com>
On Thu, 26 Jan 2023 17:54:56 +0200
Markuss Broks <markuss.broks@gmail.com> wrote:
> Hi Andy,
>
> On 1/24/23 12:22, Andy Shevchenko wrote:
> > On Tue, Jan 24, 2023 at 01:10:25AM +0200, Markuss Broks wrote:
> >> Add a driver for AMS TCS3490 Color Light-to-Digital Converter. This
> >> device provides color and IR (red, green, blue, clear and IR) light
> >> sensing. The color sensing can be used for light source detection and
> >> color temperature measurements.
> > ...
> >
> >> +AMS TCS3490 DRIVER
> >> +M: Markuss Broks <markuss.broks@gmail.com>
> >> +L: linux-iio@vger.kernel.org
> >> +S: Maintained
> >> +F: Documentation/devicetree/bindings/iio/light/ams,tcs3490.yaml
> > Shouldn't actually be added with the schema patch?
> >
> >> +F: drivers/iio/light/tcs3490.c
> > I dunno what's the rules but it feels a bit inconsistent in case the schema
> > will leave while driver got, for example, rewritten (as brand new) and reverted
> > (as old one). In such (quite unlikely) circumstances we may end up with the
> > dangling file.
> >
> > Rob, Krzysztof, Jonathan, what is yours take from this?
Ideal is update the file listing as files are added, but I rarely care
enough to fix it up or complain as the patches almost always go
together.
next prev parent reply other threads:[~2023-01-26 17:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 23:10 [PATCH 0/2] Add a driver for AMS TCS3490 light sensor Markuss Broks
2023-01-23 23:10 ` [PATCH 1/2] dt-bindings: iio: tcs3490: Add bindings " Markuss Broks
2023-01-24 10:32 ` Krzysztof Kozlowski
2023-01-23 23:10 ` [PATCH 2/2] iio: light: Add support " Markuss Broks
2023-01-24 10:22 ` Andy Shevchenko
2023-01-26 15:54 ` Markuss Broks
2023-01-26 17:41 ` Jonathan Cameron [this message]
2023-01-27 9:09 ` Andy Shevchenko
2023-01-28 17:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126174119.000056da@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Zhigang.Shi@liteon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=paul@pgazz.com \
--cc=robh+dt@kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).