From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F48CC54EAA for ; Mon, 30 Jan 2023 17:09:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235634AbjA3RJ3 (ORCPT ); Mon, 30 Jan 2023 12:09:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjA3RJ2 (ORCPT ); Mon, 30 Jan 2023 12:09:28 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10BA83FF2B; Mon, 30 Jan 2023 09:09:26 -0800 (PST) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4P5F4p1T6vz6J9gC; Tue, 31 Jan 2023 01:08:26 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 30 Jan 2023 17:09:24 +0000 Date: Mon, 30 Jan 2023 17:09:23 +0000 From: Jonathan Cameron To: Rob Herring CC: Jonathan Cameron , Lars-Peter Clausen , , , Krzysztof Kozlowski , Michael Hennerich Subject: Re: [PATCH v2 12/12] dt-bindings: iio: accel: Add ADIS16203 Inclinometer Message-ID: <20230130170923.00000752@Huawei.com> In-Reply-To: <20230130152137.GA2586655-robh@kernel.org> References: <20230129155602.740743-1-jic23@kernel.org> <20230129155602.740743-13-jic23@kernel.org> <167502679603.787347.16663590794832817182.robh@kernel.org> <20230130152137.GA2586655-robh@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 30 Jan 2023 09:21:37 -0600 Rob Herring wrote: > On Mon, Jan 30, 2023 at 07:35:26AM -0600, Rob Herring wrote: > > > > On Sun, 29 Jan 2023 15:56:02 +0000, Jonathan Cameron wrote: > > > From: Jonathan Cameron > > > > > > There has been a driver in staging for quite a while. > > > Given we are now moving it to the main tree, time to make sure it > > > has binding documentation. > > > > > > Signed-off-by: Jonathan Cameron > > > > > > -- > > > V2: > > > - maxItems/minItems added where needed. > > > - fix interrupt-names to allow multiple entries. > > > --- > > > .../bindings/iio/accel/adi,adis16203.yaml | 64 +++++++++++++++++++ > > > 1 file changed, 64 insertions(+) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adis16203.example.dtb: accelerometer@0: Unevaluated properties are not allowed ('interrupt-names' was unexpected) > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml > > I was scratching my head on this one... Check the compatible string in > the example. You've got 201 instead of 203. > > Are these parts that different? > > Rob Gah, Not sure why I didn't see this error - definitely something odd going on when I test at the moment. The parts are not particularly related. I'll fix that and send a v3.