From: Rob Herring <robh@kernel.org>
To: Hermes Zhang <chenhuiz@axis.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
kernel@axis.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property
Date: Mon, 30 Jan 2023 16:44:12 -0600 [thread overview]
Message-ID: <20230130224412.GA3658652-robh@kernel.org> (raw)
In-Reply-To: <20230130064433.962712-1-chenhuiz@axis.com>
On Mon, Jan 30, 2023 at 02:44:33PM +0800, Hermes Zhang wrote:
> Add a new property: cap-aggressive-pm to enable the
> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.
Is that a kernel feature or something from the MMC or SD specifications?
The former doesn't belong in DT. Set this based on the compatible string
of the controller.
>
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
>
> Notes:
> Update commit message
>
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 86c73fd825fd..7ca674263dba 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -177,6 +177,11 @@ properties:
> description:
> enable SDIO IRQ signalling on this interface
>
> + cap-aggressive-pm:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + enable MMC_CAP_AGGRESSIVE_PM feature
> +
> full-pwr-cycle:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.30.2
>
next prev parent reply other threads:[~2023-01-30 22:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 6:44 [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property Hermes Zhang
2023-01-30 22:44 ` Rob Herring [this message]
2023-01-31 19:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130224412.GA3658652-robh@kernel.org \
--to=robh@kernel.org \
--cc=chenhuiz@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).