* [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property
@ 2023-01-30 6:44 Hermes Zhang
2023-01-30 22:44 ` Rob Herring
2023-01-31 19:16 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Hermes Zhang @ 2023-01-30 6:44 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski
Cc: kernel, Hermes Zhang, linux-mmc, devicetree, linux-kernel
Add a new property: cap-aggressive-pm to enable the
MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.
Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
---
Notes:
Update commit message
Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index 86c73fd825fd..7ca674263dba 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -177,6 +177,11 @@ properties:
description:
enable SDIO IRQ signalling on this interface
+ cap-aggressive-pm:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ enable MMC_CAP_AGGRESSIVE_PM feature
+
full-pwr-cycle:
$ref: /schemas/types.yaml#/definitions/flag
description:
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property
2023-01-30 6:44 [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property Hermes Zhang
@ 2023-01-30 22:44 ` Rob Herring
2023-01-31 19:16 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-01-30 22:44 UTC (permalink / raw)
To: Hermes Zhang
Cc: Ulf Hansson, Krzysztof Kozlowski, kernel, linux-mmc, devicetree,
linux-kernel
On Mon, Jan 30, 2023 at 02:44:33PM +0800, Hermes Zhang wrote:
> Add a new property: cap-aggressive-pm to enable the
> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.
Is that a kernel feature or something from the MMC or SD specifications?
The former doesn't belong in DT. Set this based on the compatible string
of the controller.
>
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
>
> Notes:
> Update commit message
>
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 86c73fd825fd..7ca674263dba 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -177,6 +177,11 @@ properties:
> description:
> enable SDIO IRQ signalling on this interface
>
> + cap-aggressive-pm:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + enable MMC_CAP_AGGRESSIVE_PM feature
> +
> full-pwr-cycle:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property
2023-01-30 6:44 [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property Hermes Zhang
2023-01-30 22:44 ` Rob Herring
@ 2023-01-31 19:16 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-31 19:16 UTC (permalink / raw)
To: Hermes Zhang, Ulf Hansson, Rob Herring, Krzysztof Kozlowski
Cc: kernel, linux-mmc, devicetree, linux-kernel
On 30/01/2023 07:44, Hermes Zhang wrote:
> Add a new property: cap-aggressive-pm to enable the
> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.
>
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
We did not finish discussion from v1 as you did not really answer my
concerns there. Don't send v2 because it looks like you cut the
discussion and ignore the feedback.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-31 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-30 6:44 [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property Hermes Zhang
2023-01-30 22:44 ` Rob Herring
2023-01-31 19:16 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).