From: Rob Herring <robh@kernel.org>
To: Alexandre Bailon <abailon@baylibre.com>
Cc: yong.wu@mediatek.com, joro@8bytes.org, will@kernel.org,
robin.murphy@arm.com, matthias.bgg@gmail.com,
krzysztof.kozlowski@linaro.org, iommu@lists.linux.dev,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: iommu: memory: Use unmanaged iommu domain for the APU
Date: Mon, 30 Jan 2023 16:50:32 -0600 [thread overview]
Message-ID: <20230130225032.GA3667757-robh@kernel.org> (raw)
In-Reply-To: <20230130102722.133271-4-abailon@baylibre.com>
On Mon, Jan 30, 2023 at 11:27:22AM +0100, Alexandre Bailon wrote:
> This updates the iommu id to use unmanaged iommu domain for the APU.
> This is required by remoteproc to use the iommu.
Explain how a mixture of DTs with or without this value changed would
work with kernels with or without support for unmanaged domains? Looks
like a compatibility problem to me.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
> include/dt-bindings/memory/mediatek,mt8365-larb-port.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/dt-bindings/memory/mediatek,mt8365-larb-port.h b/include/dt-bindings/memory/mediatek,mt8365-larb-port.h
> index 56d5a5dd519e7..86d82a8f6017d 100644
> --- a/include/dt-bindings/memory/mediatek,mt8365-larb-port.h
> +++ b/include/dt-bindings/memory/mediatek,mt8365-larb-port.h
> @@ -24,8 +24,8 @@
> #define M4U_PORT_MDP_WROT0 MTK_M4U_ID(M4U_LARB0_ID, 7)
> #define M4U_PORT_MDP_RDMA1 MTK_M4U_ID(M4U_LARB0_ID, 8)
> #define M4U_PORT_DISP_FAKE0 MTK_M4U_ID(M4U_LARB0_ID, 9)
> -#define M4U_PORT_APU_READ MTK_M4U_ID(M4U_LARB0_ID, 10)
> -#define M4U_PORT_APU_WRITE MTK_M4U_ID(M4U_LARB0_ID, 11)
> +#define M4U_PORT_APU_READ MTK_M4U_UNMANAGED_ID(M4U_LARB0_ID, 10)
> +#define M4U_PORT_APU_WRITE MTK_M4U_UNMANAGED_ID(M4U_LARB0_ID, 11)
>
> /* larb1 */
> #define M4U_PORT_VENC_RCPU MTK_M4U_ID(M4U_LARB1_ID, 0)
> --
> 2.38.2
>
prev parent reply other threads:[~2023-01-30 22:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 10:27 [PATCH 0/3] Add support of unmanaged domain to mediatek IOMMU Alexandre Bailon
2023-01-30 10:27 ` [PATCH 1/3] dt-bindings: memory: mediatek: Add support of unmanaged iommu domain Alexandre Bailon
2023-01-30 11:57 ` Alexandre Mergnat
2023-01-30 11:58 ` Robin Murphy
2023-01-30 10:27 ` [PATCH 2/3] iommu: " Alexandre Bailon
2023-01-30 12:04 ` Alexandre Mergnat
2023-01-30 12:04 ` Robin Murphy
2023-01-31 13:08 ` Alexandre Bailon
2023-01-31 14:15 ` Robin Murphy
2023-01-31 15:31 ` Alexandre Bailon
2023-02-14 5:48 ` Yong Wu (吴勇)
2023-09-14 8:07 ` Alexandre Bailon
2023-09-14 14:19 ` Robin Murphy
2023-01-30 10:27 ` [PATCH 3/3] dt-bindings: iommu: memory: Use unmanaged iommu domain for the APU Alexandre Bailon
2023-01-30 12:04 ` Alexandre Mergnat
2023-01-30 22:50 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130225032.GA3667757-robh@kernel.org \
--to=robh@kernel.org \
--cc=abailon@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).