* [PATCH] arm64: dts: imx8mq: update usb compatible string
@ 2023-01-31 9:11 Peng Fan (OSS)
2023-01-31 9:24 ` Marco Felsch
0 siblings, 1 reply; 4+ messages in thread
From: Peng Fan (OSS) @ 2023-01-31 9:11 UTC (permalink / raw)
To: shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, devicetree, linux-kernel,
linux-arm-kernel, robh+dt, krzysztof.kozlowski+dt, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
There is no fsl,imx8mq-dwc3 binding doc, no driver use this compatible
string. Drop it.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index d59156fdee0b..d308f94a7c52 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1431,7 +1431,7 @@ gpu: gpu@38000000 {
};
usb_dwc3_0: usb@38100000 {
- compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
+ compatible = "snps,dwc3";
reg = <0x38100000 0x10000>;
clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>,
<&clk IMX8MQ_CLK_USB_CORE_REF>,
@@ -1463,7 +1463,7 @@ usb3_phy0: usb-phy@381f0040 {
};
usb_dwc3_1: usb@38200000 {
- compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
+ compatible = "snps,dwc3";
reg = <0x38200000 0x10000>;
clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>,
<&clk IMX8MQ_CLK_USB_CORE_REF>,
--
2.37.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mq: update usb compatible string
2023-01-31 9:11 [PATCH] arm64: dts: imx8mq: update usb compatible string Peng Fan (OSS)
@ 2023-01-31 9:24 ` Marco Felsch
2023-01-31 9:34 ` Peng Fan
0 siblings, 1 reply; 4+ messages in thread
From: Marco Felsch @ 2023-01-31 9:24 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: shawnguo, s.hauer, devicetree, Peng Fan, krzysztof.kozlowski+dt,
linux-kernel, robh+dt, linux-imx, kernel, festevam,
linux-arm-kernel
Hi,
On 23-01-31, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> There is no fsl,imx8mq-dwc3 binding doc, no driver use this compatible
> string. Drop it.
please don't. I'm not aware of the driver state but the compatibles are
there for _possible_ quirk handling, so the driver can add a match on
demand.
Regards,
Marco
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index d59156fdee0b..d308f94a7c52 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1431,7 +1431,7 @@ gpu: gpu@38000000 {
> };
>
> usb_dwc3_0: usb@38100000 {
> - compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> + compatible = "snps,dwc3";
> reg = <0x38100000 0x10000>;
> clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>,
> <&clk IMX8MQ_CLK_USB_CORE_REF>,
> @@ -1463,7 +1463,7 @@ usb3_phy0: usb-phy@381f0040 {
> };
>
> usb_dwc3_1: usb@38200000 {
> - compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> + compatible = "snps,dwc3";
> reg = <0x38200000 0x10000>;
> clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>,
> <&clk IMX8MQ_CLK_USB_CORE_REF>,
> --
> 2.37.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] arm64: dts: imx8mq: update usb compatible string
2023-01-31 9:24 ` Marco Felsch
@ 2023-01-31 9:34 ` Peng Fan
2023-01-31 9:54 ` Marco Felsch
0 siblings, 1 reply; 4+ messages in thread
From: Peng Fan @ 2023-01-31 9:34 UTC (permalink / raw)
To: Marco Felsch, Peng Fan (OSS)
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org, dl-linux-imx,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH] arm64: dts: imx8mq: update usb compatible string
>
> Hi,
>
> On 23-01-31, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > There is no fsl,imx8mq-dwc3 binding doc, no driver use this compatible
> > string. Drop it.
>
> please don't. I'm not aware of the driver state but the compatibles are there
> for _possible_ quirk handling, so the driver can add a match on demand.
NXP downstream also not has driver use this compatible string, and pass
several GA releases.
People could add it back when it is needed together with binding doc.
Thanks,
Peng.
>
> Regards,
> Marco
>
>
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index d59156fdee0b..d308f94a7c52 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -1431,7 +1431,7 @@ gpu: gpu@38000000 {
> > };
> >
> > usb_dwc3_0: usb@38100000 {
> > - compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > + compatible = "snps,dwc3";
> > reg = <0x38100000 0x10000>;
> > clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>,
> > <&clk IMX8MQ_CLK_USB_CORE_REF>, @@ -
> 1463,7 +1463,7 @@
> > usb3_phy0: usb-phy@381f0040 {
> > };
> >
> > usb_dwc3_1: usb@38200000 {
> > - compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > + compatible = "snps,dwc3";
> > reg = <0x38200000 0x10000>;
> > clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>,
> > <&clk IMX8MQ_CLK_USB_CORE_REF>,
> > --
> > 2.37.1
> >
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mq: update usb compatible string
2023-01-31 9:34 ` Peng Fan
@ 2023-01-31 9:54 ` Marco Felsch
0 siblings, 0 replies; 4+ messages in thread
From: Marco Felsch @ 2023-01-31 9:54 UTC (permalink / raw)
To: Peng Fan
Cc: Peng Fan (OSS), shawnguo@kernel.org, s.hauer@pengutronix.de,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org, dl-linux-imx,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
On 23-01-31, Peng Fan wrote:
> > Subject: Re: [PATCH] arm64: dts: imx8mq: update usb compatible string
> >
> > Hi,
> >
> > On 23-01-31, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > There is no fsl,imx8mq-dwc3 binding doc, no driver use this compatible
> > > string. Drop it.
> >
> > please don't. I'm not aware of the driver state but the compatibles are there
> > for _possible_ quirk handling, so the driver can add a match on demand.
>
> NXP downstream also not has driver use this compatible string, and pass
> several GA releases.
This shouldn't be an argument, because there is no bug at the moment
doesn't mean that there is one. Also the compatible may used by other
projects using this device tree too.
> People could add it back when it is needed together with binding doc.
Nope since a DTB is firmware which is updated relativ rare. The kernel
instead is updated more often. So please instead of removing it add
support to the dt-bindings doc.
Regards,
Marco
> Thanks,
> Peng.
>
> >
> > Regards,
> > Marco
> >
> >
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > index d59156fdee0b..d308f94a7c52 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > @@ -1431,7 +1431,7 @@ gpu: gpu@38000000 {
> > > };
> > >
> > > usb_dwc3_0: usb@38100000 {
> > > - compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > > + compatible = "snps,dwc3";
> > > reg = <0x38100000 0x10000>;
> > > clocks = <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>,
> > > <&clk IMX8MQ_CLK_USB_CORE_REF>, @@ -
> > 1463,7 +1463,7 @@
> > > usb3_phy0: usb-phy@381f0040 {
> > > };
> > >
> > > usb_dwc3_1: usb@38200000 {
> > > - compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > > + compatible = "snps,dwc3";
> > > reg = <0x38200000 0x10000>;
> > > clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>,
> > > <&clk IMX8MQ_CLK_USB_CORE_REF>,
> > > --
> > > 2.37.1
> > >
> > >
> > >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-31 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-31 9:11 [PATCH] arm64: dts: imx8mq: update usb compatible string Peng Fan (OSS)
2023-01-31 9:24 ` Marco Felsch
2023-01-31 9:34 ` Peng Fan
2023-01-31 9:54 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).