From: kernel test robot <lkp@intel.com>
To: Mohammad Rafi Shaik <quic_mohs@quicinc.com>,
krzysztof.kozlowski+dt@linaro.org, agross@kernel.org,
andersson@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com,
srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org, devicetree@vger.kernel.org,
konrad.dybcio@linaro.org
Cc: oe-kbuild-all@lists.linux.dev,
Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Subject: Re: [PATCH 08/14] ASoC: q6dsp: q6apm-dai: Add open/free compress DAI callbacks
Date: Thu, 2 Feb 2023 00:09:41 +0800 [thread overview]
Message-ID: <202302012337.pC5Q3lLy-lkp@intel.com> (raw)
In-Reply-To: <20230201134947.1638197-9-quic_mohs@quicinc.com>
Hi Mohammad,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on next-20230201]
[cannot apply to tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.2-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mohammad-Rafi-Shaik/ALSA-compress-Update-compress-set-params-for-gapless-playback/20230201-215622
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link: https://lore.kernel.org/r/20230201134947.1638197-9-quic_mohs%40quicinc.com
patch subject: [PATCH 08/14] ASoC: q6dsp: q6apm-dai: Add open/free compress DAI callbacks
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230201/202302012337.pC5Q3lLy-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/78a6016e006a8e405679fd335940ee710416c43f
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Mohammad-Rafi-Shaik/ALSA-compress-Update-compress-set-params-for-gapless-playback/20230201-215622
git checkout 78a6016e006a8e405679fd335940ee710416c43f
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash sound/soc/qcom/qdsp6/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> sound/soc/qcom/qdsp6/q6apm-dai.c:135:6: warning: no previous prototype for 'event_handler_compr' [-Wmissing-prototypes]
135 | void event_handler_compr(uint32_t opcode, uint32_t token,
| ^~~~~~~~~~~~~~~~~~~
vim +/event_handler_compr +135 sound/soc/qcom/qdsp6/q6apm-dai.c
134
> 135 void event_handler_compr(uint32_t opcode, uint32_t token,
136 uint32_t *payload, void *priv)
137 {
138 struct q6apm_dai_rtd *prtd = priv;
139 struct snd_compr_stream *substream = prtd->cstream;
140 unsigned long flags;
141 uint32_t wflags = 0;
142 uint64_t avail;
143 uint32_t bytes_written, bytes_to_write;
144 bool is_last_buffer = false;
145
146 switch (opcode) {
147 case APM_CLIENT_EVENT_CMD_EOS_DONE:
148 spin_lock_irqsave(&prtd->lock, flags);
149 if (prtd->notify_on_drain) {
150 snd_compr_drain_notify(prtd->cstream);
151 prtd->notify_on_drain = false;
152 } else {
153 prtd->state = Q6APM_STREAM_STOPPED;
154 }
155 spin_unlock_irqrestore(&prtd->lock, flags);
156 break;
157 case APM_CLIENT_EVENT_DATA_WRITE_DONE:
158 spin_lock_irqsave(&prtd->lock, flags);
159 bytes_written = token >> APM_WRITE_TOKEN_LEN_SHIFT;
160 prtd->copied_total += bytes_written;
161 snd_compr_fragment_elapsed(substream);
162
163 if (prtd->state != Q6APM_STREAM_RUNNING) {
164 spin_unlock_irqrestore(&prtd->lock, flags);
165 break;
166 }
167
168 avail = prtd->bytes_received - prtd->bytes_sent;
169
170 if (avail > prtd->pcm_count) {
171 bytes_to_write = prtd->pcm_count;
172 } else {
173 if (substream->partial_drain || prtd->notify_on_drain)
174 is_last_buffer = true;
175 bytes_to_write = avail;
176 }
177
178 if (bytes_to_write) {
179 if (substream->partial_drain && is_last_buffer)
180 wflags |= APM_LAST_BUFFER_FLAG;
181
182 q6apm_write_async_compr(prtd->graph,
183 bytes_to_write, 0, 0, wflags);
184
185 prtd->bytes_sent += bytes_to_write;
186
187 if (prtd->notify_on_drain && is_last_buffer)
188 audioreach_shared_memory_send_eos(prtd->graph);
189 }
190
191 spin_unlock_irqrestore(&prtd->lock, flags);
192 break;
193 default:
194 break;
195 }
196 }
197
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-01 16:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 13:49 [PATCH 00/14] Add support for compress offload and gapless playback Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 01/14] ALSA: compress: Update compress set params for " Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 02/14] ASoC: qcom: SC7280: audioreach: Add sc7280 hardware param fixup callback Mohammad Rafi Shaik
2023-02-01 14:40 ` Mark Brown
2023-02-03 6:33 ` Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 03/14] ASoC: q6dsp: audioreach: Add placeholder decoder for compress playback Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 04/14] ASoC: q6dsp: audioreach: Add support for compress offload commands Mohammad Rafi Shaik
2023-02-01 15:18 ` kernel test robot
2023-02-01 13:49 ` [PATCH 05/14] ASoC: q6dsp: audioreach: Add support to set compress params Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 06/14] ASoC: q6dsp: audioreach: Add support for sending real module ID to ADSP Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 07/14] ASoC: q6dsp: q6apm-dai: Add async compress write support Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 08/14] ASoC: q6dsp: q6apm-dai: Add open/free compress DAI callbacks Mohammad Rafi Shaik
2023-02-01 16:09 ` kernel test robot [this message]
2023-02-01 13:49 ` [PATCH 09/14] ASoC: q6dsp: q6apm-dai: Add compress DAI and codec caps get callbacks Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 10/14] ASoC: q6dsp: q6apm-dai: Add trigger/pointer compress DAI callbacks Mohammad Rafi Shaik
2023-02-01 16:50 ` kernel test robot
2023-02-01 13:49 ` [PATCH 11/14] ASoC: q6dsp: q6apm-dai: Add compress set params and metadata " Mohammad Rafi Shaik
2023-02-01 15:18 ` kernel test robot
2023-02-01 13:49 ` [PATCH 12/14] ASoC: q6dsp: q6apm-dai: Add mmap and copy compress " Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 13/14] ASoC: qdsp6: audioreach: Add MP3, AAC and FLAC compress format support Mohammad Rafi Shaik
2023-02-01 13:49 ` [PATCH 14/14] ASoC: q6dsp: audioreach: Add gapless feature support Mohammad Rafi Shaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302012337.pC5Q3lLy-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=quic_mohs@quicinc.com \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).